instant-labs/instant-epp

instant-epp's Issues

The results from EPP operations do not implement `ToXml`

For example domain::create::CreateData implements FromXml but does not implement ToXml. I tried deriving it and it just works. Can I submit a pull request for all of these?

InfoData::created_at should not be optional

https://github.com/instantdomain/instant-epp/blob/c5bc07b157ee9190b7689347c6afe24b2449ca43/src/domain/info.rs#L104

I think this field can be

pub created_at: Option<DateTime<Utc>>,

Add support for secDNS-1.1

It would be nice to have support for RFC 5910 Domain Name System Security Extensions Mapping for the Extensible Provisioning Protocol.

Progress

• info,
• create,
• update,

In `contact:addrType` the elements `sp` and `pc` (`contact::Address` fields `province` and `postal_code`) are optional

The elements sp, pc are optional but the struct Address in module contact makes them compulsory.

Here is the schema definition from RFC 5733, page 31

<complexType name="addrType">
  <sequence>
    <element name="street" type="contact:optPostalLineType"
     minOccurs="0" maxOccurs="3"/>
    <element name="city" type="contact:postalLineType"/>
    <element name="sp" type="contact:optPostalLineType"
     minOccurs="0"/>
    <element name="pc" type="contact:pcType"
     minOccurs="0"/>
    <element name="cc" type="contact:ccType"/>
  </sequence>
</complexType>

Should I fix this and submit PR?

This was originaly filed as masalachai/epp-client#96

Login with no service extensions serialize to invalid XML EPP document

When the ext_uris argument to Login::new() is None, Login serializes to and XML document that is invalid against the EPP schema. That's because it outputs an empty <svcExtension/> element, whereas the schema is:

<complexType name="loginSvcType">
  <sequence>
    <element name="objURI" type="anyURI"
     maxOccurs="unbounded"/>
    <element name="svcExtension" type="epp:extURIType"
     minOccurs="0"/>
  </sequence>
</complexType>
<complexType name="extURIType">
  <sequence>
    <element name="extURI" type="anyURI"
     maxOccurs="unbounded"/>
  </sequence>
</complexType>

That means that the <svcExtension> element must contain at least one <extURI> element, it can not be empty. To indicate no service extension the <svcExtension> element should be omited.

Example of generated bogus XML:

<epp xmlns="urn:ietf:params:xml:ns:epp-1.0">
    <command>
        <login>
            <clID>username</clID>
            <pw>password</pw>
            <options>
                <version>1.0</version>
                <lang>en</lang>
            </options>
            <svcs>
                <objURI>urn:ietf:params:xml:ns:host-1.0</objURI>
                <objURI>urn:ietf:params:xml:ns:contact-1.0</objURI>
                <objURI>urn:ietf:params:xml:ns:domain-1.0</objURI>
                <svcExtension></svcExtension>
            </svcs>
        </login>
        <clTRID>cltrid:1626454866</clTRID>
    </command>
</epp>

This was originaly reported on masalachai/epp-client#94.