Comments (2)
That would be one way to do it, yes. Assuming there are faxes already existing. I can't recall if I left any Thread.Sleep
s in the tests - these were my way of trying to create outbound faxes from scratch and work with those so we didn't have to rely on anything being present, but there are some methods (such as those on inbound faxes) which can't be tested that way and the delay between faxes being accepted/sent by the API and things like images being available wasn't known or discovered at the time.
from interfax-dotnet.
The more I think about it, the more I am not sure if these kind of tests make sense. Ideally the tests should only test if the SDK passes the right arguments to the API, and if it parses the API responses correctly when they return. The actual API call returning what is expected is out of scope.
Now obviously there's a few ways to solve this. In Ruby we'd use something like VCR to record responses for certain apI calls: https://github.com/vcr/vcr. This ensures that a) if the request changes the VCR will fail and warn the user that the request changed, and b) it ensures that the responses are parsed as if a real API call was made, without actually doing so.
But to be honest, we didn't do these kind of tests in any of the other SDK, so as it stands I am happy to scrap/mock them out.
from interfax-dotnet.
Related Issues (17)
- Move LICENSE into a LICENSE file HOT 4
- Has interfax.SendFax been defined? HOT 3
- InfoundFax fails to deserialize if image status is DONT_EXIST HOT 1
- TLS 1.0 Depreciated causing Exceptions HOT 2
- Request - Fax byte[] in addition to files... HOT 4
- Rename project HOT 1
- Fix: InterFAX.Api does not have a strong name... HOT 6
- FaxClient should not set default serialization settings HOT 7
- Deploying inside Azure Functions... HOT 1
- How to set up proxy? HOT 1
- SupportedMediaTypes.json Location
- Typo README.md
- InboundFax.MessageId datatype is inconsistent API HOT 1
- Outbound.GetCompleted does not include ids HOT 3
- Error on Mac with .NET for Mac HOT 2
- Add instructions on how to run tests HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from interfax-dotnet.