FaxClient should not set default serialization settings

[interfax]

FaxClient should not set default serialization settings

[fouwels]

Agreed, have submitted to the team, will keep you updated.

[shahzadadil]

@kaelanfouwels This is an important one and should really be a critical priority item. We also encountered this issue for one of the projects. The side effect was once the settings were changed, it broke the whole application. All of the enums on all of the pages were getting translated into string values as opposed to numbers. So every functionality was breaking.

We had to create our own custom client as a workaround for this.

[fouwels]

@eyalnevo

[sdominInterfax]

Hi all, can I ask you please which version of Newtonsoft are you using? The issue may be related to the version.

[sdominInterfax]

Hi @hackked, @kaelanfouwels, @shahzadadil can I ask you please which version of Newtonsoft are you using? The issue may be related to the version. My version is Newtonsoft.Json.11.0.2

The method was obsolete in the latest version https://www.newtonsoft.com/json/help/html/P_Newtonsoft_Json_Converters_StringEnumConverter_CamelCaseText.htm

[jwyoung9]

@sdominInterfax I think you are missing the key point on this one. The library should not set the static JsonConvert.DefaultSettings property anywhere. If you do, this will overwrite whatever value an end user application may have set previously.

[ricky-shake-n-bake-bobby]

This has been resolved in version 3.1.3.