interledgerjs/ilp-plugin-ethereum

Settle Interledger payments with ETH and ERC-20 tokens

ilp-plugin-ethereum's Issues

Support custom signing keys in Machinomy paychan contracts

Since each claim requires the private key to sign it (and each stream requires signing many claims), only custodial wallets may use this. With custom signing keys, MetaMask and hardware wallet integration for client software would be feasible.

Error: Cannot find module 'machinomy/lib/payment'

Not working with Machinomy ^1.6.1

It looks like this plugin is incompatible with machinomy v.1.6.1 despite it as a dependency.

An example:
This function call: https://github.com/interledgerjs/ilp-plugin-ethereum-asym-client/blob/58a71f3c6310188ea668dfd21d431eeb98ba1f69/index.js#L93-L96
Doesn't match what machinomy expects: https://github.com/machinomy/machinomy/blob/b816cb4621bf6e0e51324920a7762dcc262abe49/index.ts#L264-L269

I found a few others incompatibilities well.

Include a link to the source code of the smart contract used

This would be helpful for anyone looking at how this plugin works under the hood

Built-in mechanism to start settling

This would trigger the counterparty to claim if it's profitable to do so, enabling the sender to get their collateral back.

Estimate gas for ERC-20 approve, then add open/deposit hardcoded gas limit

As opposed to having a hardcoded gas limit for the two combined operations. (Machinomy gas usage for those operations is probably pretty constant, but ERC-20 implementations could in theory use more or less gas.)

Logs incorrectly report fee in unit of ERC-20, rather than ETH

e.g. Depositing 10 DAI to channel for fee of 0.00048373 DAI

support a design map

Limit incoming queue to a single claim

On a T04 errors, the plugin sends the latest claim to the peer. Often, this requires verifying the signature, which if many T04s are triggered, can overwhelm the plugin/connector.

Alternatively, only allow a single validate claim task in the queue, and if a new one is enqueued, drop any others without running them.

Add more intelligent nonce management for concurrent txs

Refer to MetaMask/metamask-extension#3475 and https://github.com/MetaMask/nonce-tracker/blob/master/index.js for ideas

Add unit tests

What happened to the unit tests? I noticed the branch is gone.

A lot of those tests were testing balance/account/store logic as well as packet construction very thoroughly. If they are gone, it is very possible that somebody could edit the plugin and cause a minor breaking change (like balance logic not being calculated properly or persisted to the store) and the integration tests would still pass. I feel this could be pretty dangerous considering the plugin is in beta and will have updates.

Upgrade to Ethers v5 beta

Return ILP Reject packets instead of throwing

Same as interledgerjs/ilp-plugin-xrp-asym-server#20

Add persistent channel watcher

If a server ever goes offline and comes back online, the channel watcher currently does not watch open channels if the client is not connected.

Incorrect log when request peer to close channel fails

ilp-plugin-ethereum/src/account.ts

Line 1243 in 316ac9f

const updatedChannel = this.refreshChannel(

This line should await the updated channel state before logging that it was successful (and log if the state is not updated).

Race condition when opening client channel

There is a race condition in the code that establishes a client channel.