iolivernguyen/git-pr

git-pr's Issues

Running git-pr on a repo with no previous pull requests results in error

$ git-pr
259323a4  Rename head -> HEAD for case-sensitive filesystems

panic: failed to find last pull request number

goroutine 1 [running]:
main.must[...](...)
	/home/duane/tmp/git-pr/utils.go:49
main.main()
	/home/duane/tmp/git-pr/main.go:59 +0xfd6

Point each PR remote branch to the previous remote branch in the stack?

I've noticed when using git-pr that each PR after the first includes all commits from the first PR to N-1. This makes it difficult for reviewers, as it is not a "normal" way to configure a PR on github. (For example, my coworkers complain that it is more difficult to add a comment to a commit than to the files/lines of a PR; they also say it is confusing to see all commits together if their review is needed on only one of them).

In another tool that I've considered using, graphite, they seem to be pointing each remote branch base to the previous remote branch, like a linked list. This seems to be a reasonable compromise. Consider for example:

PR 1 (main <> pr123)
PR 2 (main <> pr124)

The above makes PR 2 show all commits from PR 1 and PR 2 in its files.

However, the following does not:

PR 1 (main <> pr123)
PR 2 (pr123 <> pr124)

In the latter example, as long as PR 1 is merged before PR 2, then everything works as expected--each PR appears to be an independent pull request showing only its commit in the stack, and merging or rebasing using the Github Button also does what it is supposed to (e.g. rebase onto main, and trigger CI build).

Is this a desirable workflow for you? Would it make sense to alter git-pr to do this, or at least make it an option?

(If so, we would no longer need the -> REVIEW <- instructions & link, as it would just be the "normal Github way").

ambiguous argument / panic

I accidentally tried running "git-pr" inside a cloned "git-pr" repo:

~/tmp/git-pr$ git-pr
fatal: ambiguous argument 'origin/main..head': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

panic: failed to find common ancestor for origin/main and head: exit status 128

goroutine 1 [running]:
main.must[...](...)
	/home/duane/tmp/git-pr/utils.go:49
main.main()
	/home/duane/tmp/git-pr/main.go:36 +0x125c

I'm new to git-pr so I'm not sure what's going on, but I thought it might be something that needs a boost so it can be more informative if this happens to others in a more serious situation.

Authentication / Token issue

I'm pretty sure I'm doing something wrong. I have my gh cli client authenticated with a token and testing it, I can access the repository. Now, when I run git-pr, I get this error message:

missing config "token"

gh auth status confirms that I'm logged in and access should be ok as well..?

  ✓ Token scopes: gist, read:gpg_key, read:org, read:project, read:public_key, read:ssh_signing_key, read:user, repo, user:email

What am I missing?