Comments (14)
@Leksat great! Closing this issue then 🚀
from composer-diff-action.
thanks both. I can confirm it works flawlessly
from composer-diff-action.
Hmm, when I run the same code as in \IonBazan\ComposerDiff\PackageDiff::getFileContents
, it works just fine.
Could it be that the action needs some kind of a GitHub permission to read from the git history?
from composer-diff-action.
I am experiencing the same issue. I've checked the workflow permissions on the repo I'm running the action on and it appears to have read permission to the repo.
from composer-diff-action.
Thanks for the reporting! I will have a closer look at this after Easter.
My first guess would be that it's related to actions/checkout
v3 - I am still using v2 in my projects and it worked last time. @Leksat can you help to check if reverting to v2 helps?
from composer-diff-action.
Affecting me too. I'm pinned to actions/checkout@v2
and it isn't helping. Debug run at https://github.com/massgov/openmass/runs/6047519645?check_suite_focus=true
from composer-diff-action.
Confirming. Downgrading actions/checkout
tov2
does not help.
from composer-diff-action.
we're also having this issue :/ on actions/checkout
v2
from composer-diff-action.
@IonBazan could you add git show
output and exit code to the exception here?
It could give us some hint.
from composer-diff-action.
@Leksat @oradwell I found that it's caused by actions/checkout#760 - I will be fixing it now here.
from composer-diff-action.
The issue should be now fixed. Please help to verify, @Leksat @oradwell @adam-delaney @weitzman. Here is one of successful runs after the fix: IonBazan/composer-diff-example#1
I have also released v1.6.1 of Composer-Diff which improves git command logging and fixes some minor compatibility problems.
Please note that it only works for repositories referenced in $GITHUB_WORKSPACE
- any other repo would require adding git config --global --add safe.directory <path>
to the workflow but at least the error will show some more details on how to fix this problem from now.
from composer-diff-action.
The error is gone 🎉 Thank you!
Now there is a new little issue. When there are no composer changes, the action output is not empty, but is set to the following:
::set-output name=composer_diff_exit_code::0
from composer-diff-action.
I believe f4eb9f4 should fix that - please try to use IonBazan/composer-diff-action@master
to see if that works.
from composer-diff-action.
@IonBazan it works like a charm on master
branch 🎉
from composer-diff-action.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from composer-diff-action.