Giter Site home page Giter Site logo

Comments (3)

IonBazan avatar IonBazan commented on July 18, 2024 1

Hi @patrick-leb, I'm glad you enjoy using this GitHub Action on your pipelines.
I think the problem is that base parameter defaults to ${{ github.event.pull_request.base.sha }} which is empty when the action is not triggered by a PR:

base:
description: 'Base composer.lock file path or git ref '
required: true
default: ${{ github.event.pull_request.base.sha }}

When providing an empty string to base, the library concats composer.lock to it, causing a comparison between same file, producing an empty output. You can try setting it to HEAD in your workflow:

      - name: Generate composer diff
        id: composer_diff # To reference the output in comment
        uses: IonBazan/composer-diff-action@v1
        with: 
          base: HEAD
          no-dev: true
          format: mdlist

I hope that helps!

from composer-diff-action.

patrick-leb avatar patrick-leb commented on July 18, 2024

That fixed it! Amazing!

May I suggest you add this use case to the docs? it will probably help someone else :)

Cheers!

from composer-diff-action.

IonBazan avatar IonBazan commented on July 18, 2024

Thanks for the suggestion - added it in the README.md since https://github.com/IonBazan/composer-diff-action/releases/tag/v1.0.6

from composer-diff-action.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.