Wrong 'output' path

[ewwink]

Wrong 'output' path

[demod-au]

thanks.. you helped me find where they were going. I have shortened my path to accommodate the problem.

[AndMetal]

I believe this is an issue with how Storage is being used in guide.ts.

In the constructor, Storage is called with no arguments:

epg/scripts/core/guide.ts

Lines 21 to 28 in a1ca6b3

	constructor({ channels, programs, logger, filepath, gzip }: GuideProps) {
	this.channels = channels
	this.programs = programs
	this.logger = logger
	this.storage = new Storage()
	this.filepath = filepath
	this.gzip = gzip || false
	}

Looking at the code for @freearhey/core (src/storage.ts), if a root directory path is passed it is used, otherwise it uses the current working directory:

  constructor(rootDir?: string) {
    this._rootDir = rootDir ? path.resolve(rootDir) : process.cwd()
  }

When the save call is made:

epg/scripts/core/guide.ts

Lines 45 to 55 in a1ca6b3

	const xmlFilepath = this.filepath
	this.logger.info(` saving to "${xmlFilepath}"...`)
	await this.storage.save(xmlFilepath, xmltv.toString())
	if (this.gzip) {
	const zip = new Zip()
	const compressed = await zip.compress(xmltv.toString())
	const gzFilepath = `${this.filepath}.gz`
	this.logger.info(` saving to "${gzFilepath}"...`)
	await this.storage.save(gzFilepath, compressed)
	}

it gets mapped to _write in Storage which adds the path to the root directory:

  async _write(filepath: string, data: any = ''): Promise<void> {
    const absFilepath = path.join(this._rootDir, filepath)
    const dir = path.dirname(absFilepath)

    await this.createDir(dir)
    await fs.writeFile(absFilepath, data, { encoding: 'utf8', flag: 'w' })
  }

which is the working directory the script was called from.

I believe the fix would be to utilize Path in @freearhey/core to get the dirname of the output option and pass that to the Storage constructor. From what I can tell if it is just a filename/pattern or references a relative path it should default to the current working directory as a base, so in theory it should be mostly backwards compatible.

Edit: as a workaround you might be able to use ../../download/xml/id.xml for the output option.

Edit 2: I confirmed ../../download/xml/id.xml works to put the file into that other directory. I still think absolute paths should be allowable and handled like I mentioned above.