irebbok/remotekeycard

An SMod & EXILED plugin for SCP: Secret Laboratory keeps door functioning with cards in your inventory

remotekeycard's Issues

Isn't working for tutorials when other plugins use that class

Add an option to make it work for tutorials. Like treat_tutorials_as_humans.

is this how it should be?

i don't think so

up to date

what to do

Where is NUKE_ACC?

https://github.com/iRebbok/RemotePermissionCard/wiki/CList-DList-PDict-PList#plist-permission-list

RK throws an exception while enabling

There seems to be a mess in the IL code of the Exiled method.

Also that part of the code requires more compatibility.

RemoteKeycard/src/RemoteKeycard.cs

Lines 75 to 78 in e54786c

	Predicate<CodeInstruction> searchPredicate = i => i.opcode == OpCodes.Ldloc_1;
	var index = newInstructions.FindIndex(searchPredicate);
	var label = newInstructions[index + 1].operand;

It might delete a wrong part of the code if there's a mess in the IL code.

RemoteKeycard/src/RemoteKeycard.cs

Line 80 in e54786c

newInstructions.RemoveRange(index, 2);

Exception stacktrace

[2021-01-08 16:00:10.601 +03:00] [ERROR] [Exiled.Loader] Plugin "RemoteKeycard" threw an exception while enabling: System.Exception: Wrong null argument: brfalse NULL
  at HarmonyLib.MethodBodyReader+<>c__DisplayClass23_0.<FinalizeILCodes>b__2 (HarmonyLib.CodeInstruction codeInstruction) [0x0015f] in <0dff4ff9ce7a4af99336d09823a08cb2>:0 
  at HarmonyLib.CollectionExtensions.Do[T] (System.Collections.Generic.IEnumerable`1[T] sequence, System.Action`1[T] action) [0x00014] in <0dff4ff9ce7a4af99336d09823a08cb2>:0 
  at HarmonyLib.MethodBodyReader.FinalizeILCodes (HarmonyLib.Emitter emitter, System.Collections.Generic.List`1[T] transpilers, System.Collections.Generic.List`1[T] endLabels, System.Boolean& hasReturnCode) [0x00203] in <0dff4ff9ce7a4af99336d09823a08cb2>:0 
  at HarmonyLib.MethodCopier.Finalize (HarmonyLib.Emitter emitter, System.Collections.Generic.List`1[T] endLabels, System.Boolean& hasReturnCode) [0x00000] in <0dff4ff9ce7a4af99336d09823a08cb2>:0 
  at HarmonyLib.MethodPatcher.CreateReplacement (System.Collections.Generic.Dictionary`2[System.Int32,HarmonyLib.CodeInstruction]& finalInstructions) [0x0021f] in <0dff4ff9ce7a4af99336d09823a08cb2>:0 
  at HarmonyLib.PatchFunctions.UpdateWrapper (System.Reflection.MethodBase original, HarmonyLib.PatchInfo patchInfo) [0x00057] in <0dff4ff9ce7a4af99336d09823a08cb2>:0 
  at HarmonyLib.PatchProcessor.Patch () [0x000fc] in <0dff4ff9ce7a4af99336d09823a08cb2>:0 
  at HarmonyLib.Harmony.Patch (System.Reflection.MethodBase original, HarmonyLib.HarmonyMethod prefix, HarmonyLib.HarmonyMethod postfix, HarmonyLib.HarmonyMethod transpiler, HarmonyLib.HarmonyMethod finalizer) [0x00028] in <0dff4ff9ce7a4af99336d09823a08cb2>:0 
  at RemoteKeycard.RemoteKeycard.OnEnabled () [0x000ae] in <f9d963baeb304ae1bf94139e6a36e338>:0 
  at Exiled.Loader.Loader.EnablePlugins () [0x00022] in <6054c0a1144349a28b73903fc4fa918d>:0 

The nuke button support

Make it support remote activation of nuke. If possible, implement support on two branches.

I think something is wrong here

Or you made a mistake and entered the wrong numbers in the wiki. Or your plugin is really conceived not according to the standard list of items, but in its own way.
https://github.com/iRebbok/RemotePermissionCard/wiki/CList-DList-PDict-PList#clist-card-list
Item List:
ITEM#000 - Janitor Keycard
ITEM#001 - Scientist Keycard
ITEM#002 - Major Scientist Keycard
ITEM#003 - Zone Manager Keycard
ITEM#004 - Guard Keycard
ITEM#005 - Senior Guard Keycard
ITEM#006 - Containment Engineer Keycard
ITEM#007 - MTF Lieutenant Keycard
ITEM#008 - MTF Commander Keycard
ITEM#009 - Facility Manager Keycard
ITEM#010 - Chaos Card
ITEM#011 - 05 Card
ITEM#012 - Radio
ITEM#013 - Com15 Pistol
ITEM#014 - Medkit
ITEM#015 - Flashlight
ITEM#016 - MicroHID
ITEM#017 - Coin
ITEM#018 - Cup
ITEM#019 - Weapon Manager Tablet
ITEM#020 - Epsilon-11 Standard Rifle
ITEM#021 - P-90
ITEM#022 - Epsilon ammo
ITEM#023 - MP7
ITEM#024 - Logicer
ITEM#025 - Grenade
ITEM#026 - Flash Grenade
ITEM#027 - Detainer
ITEM#028 - MP7/Logicer ammo
ITEM#029 - Pistol/P90 ammo

Follow recommendations

You forgot to add...

https://github.com/iRebbok/RemotePermissionCard/wiki/CList-DList-PDict-PList#clist-card-list
You forgot to add number 12 - hand SCP(I mean, for example, I need to control which doors SCP objects are allowed to open.)
https://github.com/iRebbok/RemotePermissionCard/wiki/CList-DList-PDict-PList#pdict-permission-dictionary
You forgot to add boxes with electric generators
https://github.com/iRebbok/RemotePermissionCard/wiki/CList-DList-PDict-PList#dlist-door-list
You forgot to add boxes with electric generators

NRE when accessing a locker

Error Out of Index

Getting this error with the latest version of EXILED. Happening even if this is the only plugin on the server.

This is the latest release, and the latest version of EXILED.

[2021-03-19 00:43:57.914 -05:00] [ERROR] [RemoteKeycard] An exception was thrown during patching, it won't interfere with the overall work of the plugin but affects the activating outsite panel feature.
[2021-03-19 00:43:57.924 -05:00] [ERROR] [RemoteKeycard] System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
at System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) [0x00029] in <9577ac7a62ef43179789031239ba8798>:0
at System.ThrowHelper.ThrowArgumentOutOfRangeException () [0x00000] in <9577ac7a62ef43179789031239ba8798>:0
at RemoteKeycard.RemoteKeycard+d__19.MoveNext () [0x00259] in <869b6d76a9e24d039b576cbbb74175a4>:0
at System.Collections.Generic.List1[T]..ctor (System.Collections.Generic.IEnumerable1[T] collection) [0x00077] in <9577ac7a62ef43179789031239ba8798>:0
at System.Linq.Enumerable.ToList[TSource] (System.Collections.Generic.IEnumerable1[T] source) [0x00018] in <351e49e2a5bf4fd6beabb458ce2255f3>:0 at HarmonyLib.CodeTranspiler.GetResult (System.Reflection.Emit.ILGenerator generator, System.Reflection.MethodBase method) [0x00051] in <0dff4ff9ce7a4af99336d09823a08cb2>:0 at HarmonyLib.MethodBodyReader.FinalizeILCodes (HarmonyLib.Emitter emitter, System.Collections.Generic.List1[T] transpilers, System.Collections.Generic.List1[T] endLabels, System.Boolean& hasReturnCode) [0x0014a] in <0dff4ff9ce7a4af99336d09823a08cb2>:0 at HarmonyLib.MethodCopier.Finalize (HarmonyLib.Emitter emitter, System.Collections.Generic.List1[T] endLabels, System.Boolean& hasReturnCode) [0x00000] in <0dff4ff9ce7a4af99336d09823a08cb2>:0
at HarmonyLib.MethodPatcher.CreateReplacement (System.Collections.Generic.Dictionary`2[System.Int32,HarmonyLib.CodeInstruction]& finalInstructions) [0x0021f] in <0dff4ff9ce7a4af99336d09823a08cb2>:0
at HarmonyLib.PatchFunctions.UpdateWrapper (System.Reflection.MethodBase original, HarmonyLib.PatchInfo patchInfo) [0x00057] in <0dff4ff9ce7a4af99336d09823a08cb2>:0
at HarmonyLib.PatchProcessor.Patch () [0x000fc] in <0dff4ff9ce7a4af99336d09823a08cb2>:0
at HarmonyLib.Harmony.Patch (System.Reflection.MethodBase original, HarmonyLib.HarmonyMethod prefix, HarmonyLib.HarmonyMethod postfix, HarmonyLib.HarmonyMethod transpiler, HarmonyLib.HarmonyMethod finalizer) [0x00028] in <0dff4ff9ce7a4af99336d09823a08cb2>:0