iron-e/winvoice-cli

Invoice from the command line!

Hi 👋, I'm Iron-E

• 🌱 I’m currently learning Nix
• 📫 Reach me at [email protected]
• ⛓ Other links:
  • My dotfiles

Languages & Tools

winvoice-cli's Issues

Bincode Adapter retrieve functions sometimes fail

Occasionally, the retrieve functions implemented for the bincode adapter will fail. The reason for this is unknown, although I suspect it has to do with one of the following reasons:

• Using the temporary directory for tests.
• Parallelization of tests in rust.

This issue is especially strange since the implementation of clinvoice_adapter_bincode::util::read_files. It should, in theory, ensure that all filesystem nodes iterated over by the caller are valid files. Yet, somehow a node can be a valid file during the filter operation and then immediately become a non-file after the filter is over.

However, since this issue cannot be consistently reproduced it is low-priority.

Use `NaiveDateTime` for matching

It is inferred that users are using their Local timezone.

Add negation to `Match` & `MatchStr`

Being able to negate will add functionality and remove redundancy

Don't use `naive_local` for exporting

A job might be sent to somewhere across the country or outside the country. It should be noted what timezone the user is recording in.

Allow label renaming during `Contact` information adding

Right now, the only way to change a label is to delete the contact information and re-add it. This is tiresome— users should be able to change the label for something provided that the label does not already exist.

Make `Timesheet` and `Job` a relation rather than aggregation

If multiple people want to submit a Timesheet at the same time, a database may drop entries while others submit:

1. Person A downloads data in state 1.
2. Person B downloads data in state 1.
3. Person B uploads data in state 2b.
4. Person A uploads data in state 2a, overwriting changes made in 2b.

Allow querying during `clinvoice create` operations

Right now, one can only be presented with an input::select / input::select_one prompt with every single entity in the system (of the proper type) when being asked to create a new entity which references another (e.g., Organization references Location). Instead, we should allow users to query this information if they choose.

Take care to remove duplicate logic between clinvoice create and clinvoice retrieve while doing so.

Prevent SQL Injection

#16 is vulnerable to SQL Injection, as it cannot make use of sqlx::Query::bind. To fix this, we will have to wait until launchbadge/sqlx#291 is closed and then use the proposed QueryBuilder.

`Match::AnyRange`

Allow users to specify multiple ranges when querying.

Improve query prompts

Right now, queries will give users no hint as to why they are querying. It will only show a link to the page in the CLInvoice wiki where documentation for the query can be found.

We should show users some text which shows why they are querying.

Retry queries if no results are found

Provided that CLInvoice expects that a user's query will return a result, if nothing is returned the program will simply exit. There should be a prompt for users to retry a query if no results are found, and if so, the query will run again. If not, the program will exit with the same error as before.

Create `query` to SQL functionality

The current query lib works on in-memory types. It would be very inefficient to request all rows from a database, rather than query them.

Add `Match::GreaterThan` `Match::LessThan`

Users should be able to Match on a maximum or minimum without specifying both.

Add `Match::And` and `Match::Or`

Users should be able to combine the result of multiple different kinds of conditions in a query.

Only show `Employee` `Contact` information once per exported `Job`

Right now, every Job which is exported shows the Employee's Contact information every time that the Employee appears in the Job. We should build a HashSet of Employees which have already been shown on the Job, and skip exporting that Employee's Contact info if they appear again.

Pass active connection to adapters

Currently, if I wanted to implement sqlx I would have to reconnect to the selected database every single time a function is run on an Adapter. This is obviously a problem.