ironmonk88/monks-enhanced-journal

monks-enhanced-journal's Issues

[Bug] TypeError when clicking item or monster image in encounter journal type

Feature missing show only picture in journal entry

Hi, I started to use this module a bit more thoroughly now.

When creating entries (person, quests, organizations, etc..) There's an option to only show the picture when you want to show to players. On the journal entry though, this option is not present.

I put most of my GM notes in journal entries, if I add a picture to a room description for example, I dont want my players to show briefly all my stuff when I switch to picture :)

thanks

[suggestion] Abstract rewards

The chance to add abstract rewards would be really helpful. for example, adding money or promises.

Links to compendium / world entities are mistakenly opened as a journal entry

tested on foundry 0.8.6, DnD5e 1.3.3

If a Journal Note contains an embedded link to an entity clicking on the link opens an empty page instead of opening the entity sheet.

Player preview with side menu

Hello, I'm looking on transitioning from OneJournal (still not updated for 0.8) into this one and for now I have good experience. Although I've found one thing that annoys me (Foundry 0.8.8, module 1.0.15).
When Allow Players option is disabled my players see only the entry that they open without the side menu. If I enable it, it opens journal with side menu, but they don't see the content when they are not owners of the entry.

enhanced-journal.js:769 Uncaught (in promise) Error: User Player 2 lacks permission to update JournalEntry [6Q1UYKWr74cT9uSq]

Okay, so I've debugged it a bit and it looks like just this line needs additional permission check:

if ((game.user.isGM || setting('allow-player')) && (pack == undefined || !pack.locked))
    await entity.setFlag("monks-enhanced-journal", "_viewcount", (parseInt(entity.getFlag("monks-enhanced-journal", "_viewcount")) || 0) + 1);"_viewcount")) || 0) + 1);

Add reference to actor in Person entry

Suggestions: double-click to edit entries and others

I realise I'm posting a lot about this module and that's because I love it! I've switched over to it from OneJournal because of the awesome tabs and bookmark features but there are a couple of things I liked about OneJournal which would be awesome to see in this module:

• double click to edit a journal entry
• see permissions from Permission Viewer in the sidebar
• some options to control the size of the sidebar
• be able to change the colour of the journal Folder text. The dark grey is hard to read with some backgrounds and it doesn't follow the custom text colours in the actual Journal tab.

Compatability Issues with Quick Insert

There is a compatability issue with your module and the Quick Insert module when you look up something from the compendium. Generally you can quickly ctrl-f a status like "prone" from the SRD Rules compendium and check what it does, but when using enhanced journal it only opens a blank page. This happens with every comendium entry opened through the search function of Quick Insert.

Has been tested on an empty world without any other modules active.

Error on drag items on Quest Journals

tested on foundry 0.8.5, DnD5e 1.3.2.

When trying to drag an item to a quest journal, an error is raised:

Search Journal Entries doesn't work

tested with foundry 0.8.5, DnD5e 1.3.2

Entering text on the "Search Journal Entries" does not filter the underlying entries (no console errors):

[Suggestion] Create token from person note type

Ability to quickly add a token to the map using the image in a person type journal (using default stats).

[Suggestion] Adding a Maximize button like in OneJournal

When I'm working on writing the next session, it's nice to maximize the window and be able to focus on my notes.

Issues with creating new entries and switching entries.

I'm having trouble with creating new journal entries, in particular pictures as there doesn't seem to be any way of saving them. After the picture is created I have to navigate off the entry then back to it to be able to edit it and when I have selected the image it shows up in the entry but it doesn't save. Ctrl+S doesn't work and there is no save button so when I navigate away then return it shows the hooded face vector image.

There is also another issue when switching entries. Sometimes journal appears as another? The title stays as the correct journal entry but it displays something else entirely. I get this error when moving between journals and I'm not sure if it is related.

Option to disable actor in enhenced journal or compatibility with pf2e actor

The journal is not compatible with pf2e actor sheet. A quick fix for this would be to have a setting to deactivate this feature if possible.

Quest reward

I am trying out the quest journal part and can't provide xp or reward to the party after the completion of the quest

I made a test quest with 1 objective. I put in xp as reward and I had a token on the map.
I then tried to reward the token the xp, and the token do show up in the list, but when I press the button to give xp nothing happens.
I then tried ticking the object, no change, I changed the quest to in progress, no change, I changed to completed, no change. I added coin as reward as well, no change.

I tried having the token selected and deselected in all the scenarios, but no xp was rewarded, nor was the coins distributed. I changed from no split to full split on the xp, but still nothing would work

Renaming Journals causes Foundry to reload

If I rename a Journal Entry, the website changes, and the name of the webpage link adds "?name=[Name+of+Journal]". Is this a foundry issue, an Issue with MEJ, or a thing on my side?

Compatibility with GM Screen

Is it possible to make it compatible with GM Screen?

Error creating a new slideshow

tested on foundry 0.8.5, DnD5e 1.3.2

After creating a new slideshow journal entry, viewing it gives an error:

Inconsistent refresh when dropping items on an encounter journal

tested on foundry 0.8.5, DnD5e 1.3.2:

When dragging items on an encounter journal the result of the drag is displayed when the next item is dragged

Cannot read property 'history' and 'entittyId' of undefined on FoundryVTT 0.8.6

Environment Details

Foundry VTT Version: 0.8.6

Operating System: [Linux]

How Are You Using Foundry: [Linux,Native Application (Electron), Chrome]

Which Game System: Dungeons and Dragons 5th Edition, version 1.3.4

Modules Enabled?: Yes

Module version: 1.0.6

OS, Hosting, Browser (if applicable): Linux/Node/Chrome

Description of the issue:

Error on dragging items in an encounter journal

tested on foundry 0.8.5, DnD5e 1.3.2.

In an Encounter Journal, if you try to add a DC Configuration, but then close the window without adding it, it is no longer possible to drag items due to an error:

[Suggestion] Autosave

The amount of times I've swapped tabs and lost my progress is ridiculous. If there's a way to add it in, can you please add it?

[Suggestion] Adding a bookmark to the same page more than once shouldn't be allowed

tested on foundry 0.8.6, DnD5e 1.3.3

clicking repeatedly on the bookmark for the same page adds the bookmark repeatedly.
tip: each page should only be able to be bookmarked once.

Trigger Happy Journal Links Broken

Trigger Happy links to journal pages only show a blank page when this module is enabled.

Feature request: search through multiple journal entries

Would it be possible to search for terms in several journal entries’ descriptions rather than just their titles?

Encounter items dragged from a Compendium cannot be assigned to PC due by error

tested on foundry 0.8.6, DnD5e 1.3.2.

In a Journal Encounter, dragging the elements from a compendium (which is more typical than using items from the world), the assignment of these items to the PC via drag & drop returns an error:

The problem is due to the absence of the origin pack info in the dragged data, necessary for Foundry to import the item and copy it on the sheet:

if I drag from a compendium onto the sheet:

Journal Notes cross links doesn't work

tested on foundry 0.8.5, DnD5e 1.3.2

If a Journal Notes contains a reference to another journal notes, clicking on that reference opens to a blank page. In addition, if you click on the history, you do not return to the previous page from which you clicked on the reference

Viewing a 'Picture' type journal entry makes text journal entries blank when switching back to them

I've created a number of text only and picture only journal entries but the text entries appear blank if viewed after a picture only entry.
Possibly because it's trying to switch to an image when there isn't one?

Stop SlideShow not stop the music.

once a slide starts with music, the music starts, but if the slide is paused or stopped the music does not stop.

Can't unmark quests has seen or complete

When a new quest is created the "seen" and "complete" options are checked by default and when unchecked it is not saved. Also, I'm not sure whats "seen" means.

Journal links embedded in an entry remain a text string after saving entry

I find that Journal links in a journal entry don't automatically turn into clickable links right after saving the entry, I have to navigate away from the journal entry then come back to it for the link to work:

You can see the link hasn't updated in the screenshot.

Folders not displaying correctly

Folders appears to not stretch horizontally all the way to the sides within the bounding box on the pathfinder 1e system.
Tested on pf1e 0.78.8 on FVTT 0.8.6 with no other modules enabled.

[ Suggestion ] Collapsible right menu

Hi Monk!

I'd like to know if its possible to make the journal menu collapsible, giving more space to the journal page in small screens to edit or read.

Thank you anyway! Great modules!

Entering in the edit mode loose the original style

tested on foundry 0.8.5, DnD5e 1.3.2

When you enter in the edit mode, the original style is lost, replaced by a completely different style:

[suggestion/impruvement] Assign encounter items to players

I don't know if it has already been planned, but it would be useful to be able to assign the items of a journal encounter to the player's PC sheets, either with a drag & drop or with some method to distribute them

Suggestion: Be able to share images/entries with players, not just show them

This is something I like to be able to do with a normal journal window so I was wondering if it could be added to Enhanced Journal? When showing an image it's nice to have it's permissions changed so players can look at it again themselves.

Removing an entry doesn't refresh the left panel

tested on foundry 0.8.5, DnD5e 1.3.2.

After removing an entry on the right list, if that entry was displayed on the left panel, it remains visible causing some confusion as it is still editable:

Slideshow

Forge
0.8.8
All Modules up to date.
When the GM runs a slideshow, it works fine and the Players can see it fine.
When the GM runs a 2nd slideshow, the music can be heard by everyone, but the slideshow itself cannot be seen by Players, (in window or canvas setting), but the GM can see it. Then, when the GM stops this slideshow, the music carries on playing, for everyone, and there is no way of stopping it.
Thanks

Compatibility with Forien's Quest Log

FQL adds a folder that the DM isn't really supposed to see name _fql_quests, and MEJ makes it visible. It'd be nice to not have to see that folder, as my OCD brain is bothered by the folder name.
FQL also adds a button to the bottom of the journals tab, it'd be nice to have that button also be in MEJ.

[Suggestions] Quest Journal Improvements

Hi! Really love the fact you implemented a quest journal! I can see this easily replacing Forien's Quest Log (which is now nonfunctional as of 0.8.x and effectively abandoned) with a few features.

Some suggestions or features I'd like to see:

• Add an indicator or different quest icon to differentiate completed quests from the directory
• An "objectives" tab that can easily add check box or numbered objectives; this is different and more streamlined (objectives only) from using the journal itself, which may be better for quest details.
• Maybe a way for players to set a quest or two as the actively tracked one, with an overlay of the above objectives for the HUD.

Bug secret quote not appearing on even if you are the GM

When you put a text in "secret". You can't see the secret text even if you are the GM. You need to click on EDIT to make it appear. Secret is useful when you want to partially share a journal entry without players seeing everything.

[Suggestion] The ability to quickly convert old Journal Entries to new ones

I've got a lot of towns, and I'd like to be able to convert them easily.

Cannot open pre-existing journal entries from map or journal tab

Core Version: 0.8.6
System: dnd5e 1.3.3
Module V.: 1.0.29

The issue happens only when clicking dropped journal entries on the map or in the actual Journal Entry tab, than through the enhanced journal. It works in the latter.

un-intended feature?? Character sheet in journal

hey, forst of all love you mod very useful i found out you can put a character sheet directly into the journal tabs without a person journal entry. i cant see it written anyway did you know that worked?

ohyes.mp4

[Suggestion] Currency reward

Would it be possible to set currency as a possible reward the same way you can set a XP?

Add bookmark on blank page shouldn't be allowed

tested on foundry 0.8.6, DnD5e 1.3.3

At the moment it is possible to add a bookmark on blank pages, the result is a "undefined" bookmark:

[Suggestion] Inserts links/references

Is there any way to have entries automatically link to each other? For example, if I have a journal entry for Bahamut, and I create a link to Tiamat journal entry, could a reference automatically be added to Tiamat to say "Linked from Bahamut"?

I'm going all in building a wiki like journal for my new campaign, but having some automation around the relationships between journal entries would be very welcome!

Scene Linked Notes Won't Open

Hello,

I'm very excited to use this module. It looks great. (I'm also a big fan of your other modules). Just noticed that the built-in functionality of FVTT to link journal note to scene, and then recall it

Seems to just bring up a blank journal

I'm using FVTT 0.8.8, and 5e 1.3.6. I've disabled all other modules and verified that this issue persists with only this module enabled. I also tried creating a new scene, and re-linking an existing note with the same fault occurring.

Thanks again for the awesome modules!

[Suggestion] Support for the module "Journal to Canvas Slideshow - Display Journal Art on the Canvas"

The Slideshow of Enhanced Journal would be a great addition to Journal to Canvas Slideshow

Bug journal stop responding if you close all tabs

If you close all tabs at the top and then close monk's journal. You won't be able to re-enter monk's journal from the regular journal tab in foundry. Nothing respond when you click any journal entries. You need to log out and log back in the game to reset the journal. Im running Pf2e game system and foundry 0.8.8