ishworkh/docker-image-artifact-upload

Github action for uploading docker image artifact

docker-image-artifact-upload's Issues

Getting lots of warnings when using this action

Hi - great work with this action! I use it a lot!

I've started to notice lots of warnings though when using it:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Similar with your other action (https://github.com/ishworkh/docker-image-artifact-download)

Node.js 16 actions are deprecated.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: ... ishworkh/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Possible to support string interpolation?

Would it require much work to be able to do something like this?

      - name: Build final image
        env:
          IMAGE_TAG: ${{ needs.build_image_tag.outputs.image_tag }}
        run: |
          docker build --target final -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .  # --build-arg?

....

      - name: Upload image to next job
        uses: ishworkh/docker-image-artifact-upload@v1
        with:
          image: "${ECR_REGISTRY}/${ECR_REPOSITORY}:${IMAGE_TAG}"

No support for Build and push action

The following doesn't work:

- name: Build and push
   id: docker_build
   uses: docker/build-push-action@v2
   with:
     push: false
     builder: ${{ steps.buildx.outputs.name }}
     tags: ${{ env.REGISTRY }}/${{ env.IMAGE }}:${{ github.sha }}
     build-args: |
       GIT_HEAD_COMMIT=${{ github.sha }}
       GIT_CURRENT_BRANCH=${{ github.ref }}

- name: Upload image
   uses: ishworkh/docker-image-artifact-upload@v1
   with:
     image: "${{ env.REGISTRY }}/${{ env.IMAGE }}:${{ github.sha }}"

Support retention policy

The upload artifact job has the ability for a retention policy. This would be really good to be able to specify here in this action.