island-is / island.is Goto Github PK

Monorepo for Iceland's digital services.

License: MIT License

JavaScript 3.56% TypeScript 95.90% Makefile 0.01% Dockerfile 0.01% HTML 0.02% Shell 0.13% CSS 0.02% SCSS 0.06% Handlebars 0.03% Ruby 0.02% Java 0.03% C 0.01% Objective-C 0.01% Objective-C++ 0.01% Swift 0.01% MDX 0.19% Mustache 0.01%

island.is's People

Contributors

Stargazers

Watchers

Forkers

koddsson sindrig chomman polymath-is omaroskars busla margretfinnboga arnidagur guttih nguyenvanvy1999 renatopassos jcabak saevarma fuglar-ehf unnarb valurefugl overbit buonappetort advaniasteinar rufatnazarov vugarahmadov adr-manager-anonymous pnettto msierpien rique-dev kristjan-jonsson abhijithqb cyrusvorwald2 herdismaria lwandsyj bjornbrekithorbjornsson valsarinn gunnaringireykjalin wooodhead hlodver oarnarsson khalidsheet hrefnalind muan majirosstefan vishwa-guru niklasbuchfink baohoangstan arnthorgumma karlgoffer hph

island.is's Issues

Merge bot for pull requests

Rebuilding a commit can be against a wrong "last good build"

Re-triggering a build on an old commit would cause it to get "affected" changes against the last good build on the branch which might be a much newer build and not the last good build before the commit to be rebuild.
The code to discover Git SHAs to discover is something like this:

LAST_GOOD_BUILD=`git log --format=%H --first-parent "$BRANCH" | node .github/actions/dist/index.js`

but should be more like

NUMBER_NEWER_COMMITS=`git log --format=%H --first-parent "$BRANCH"  $GITHUB_SHA... $BRANCH | wc -l`
LAST_GOOD_BUILD=`git log --format=%H --first-parent "$BRANCH" | tail -n +${NUMBER_NEWER_COMMITS+1}  | node .github/actions/dist/index.js`

Skilavottord-ws crashes on startup

Here is the log:

(node:1) UnhandledPromiseRejectionWarning: Error: EACCES: permission denied, scandir '//root'
(node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

PR run failed. fatal: reference is not a tree

Sometimes when I push to a new branch and create a PR I get this error from the pipeline:

Run git checkout $GITHUB_SHA
fatal: reference is not a tree: 7c5875c3b266acae4a2e61ca42eb3ae223b560d2
##[error]Process completed with exit code 128.

Examples:
https://github.com/island-is/island.is/runs/886903399
https://github.com/island-is/island.is/runs/886908881

Usually all I need to do is to do an empty commit and force push. Might need a few of those to make through this build step.

I think this relates to actions/checkout#23.
The solution there is to change to actions/checkout@v2 in the workflow build config.

Docker static healthchecks support

Switch to stricter TypeScript config

The default TypeScript config from NX does not have any strict flags set, eg it allows implicit any. This makes it easy to forget to add type definitions to expressions and declarations and end up with unsafe untyped code.

It's an easy change in tsconfig.json, however, we already have a lot of code this will break.

To start this migration we should turn off strict in the root tsconfig. For projects that have a significant number of errors with this flag set, we can unset it in the project-specific tsconfig. Later, someone (optimally from the project team) has time to fix these type issues and re-enable strict mode.

Failing deployment for air-discount-scheme

Reported by @dabbeg https://spinnaker.shared.devland.is/#/applications/air-discount-scheme/executions/01EFYRRPJSJGW10VNFAJ6ZWDRC?stage=1&step=0&details=deployStatus

Interference between Github Auth and innskraning.island.is callback

The POST callback from innskraning.island.is becomes GET after Github interjects into the process.
Issue pointed out by @gudjong

Responsive font size for Select controls

Since Inputs now have responsive font sizes, they leave Select controls looking funky.

Add a Docker container type for serving static content - React, etc.

We plan on using Nginx to serve the content

Extract hash key computation

Extract all cache key computation to a single step and re-use them using outputs.

Get rid of '.tgz' file in the helm/islandis chart

The file should be generated during CI build time just before it is published for safer deployments

Create reusable field wrapper components for react-hook-form

Basically what is inside libs/application/form/src/components/fields/**/* could be made more generic and moved to island-ui/core.

Currently island-ui/core only has wrappers around Formik components, which are named Field*.
But we've come to a decision to replace Formik for react-hook-form. Therefore we'll need to create similar wrapper components for that as well. Might name them *Controller, e.g. InputController.

The deadline for that is as soon as possible to avoid other developers from choosing Formik for new projects. Currently, only gjafakort uses Formik -> and that project will be removed in the beginning of next year.

Upgrade vulnerable dependencies and add package scanning to the CI

Avoid `source` in build.yml

Avoid using source as a way to get environment variables from scripts in /ci. Instead, just get them via stdout.

Created after discussions in #1152

Call for help 👉 Textarea component

In our project we are using a textarea field that looks like this 👇

What I need is to be able to choose if an input field should be rendered as a textarea or input via a prop when using the input component. I tried implementing this myself but was unable to get working due to typescript errors regarding the merging of refs in the Input component. Can anyone please help?

Build/steps timeout

If we do not fix this it can be quite expensive - https://github.com/island-is/island.is/runs/985245433?check_suite_focus=true

Document how to run the CI process locally

To help people troubleshoot CI issues on their dev machines

Add documentation how to store new env variables and secrets

Add option to publish docker images in branch in CI

After discussion with @darrikonn we decided a label on a PR would be best.

Adding a label to a PR: jq -n '{"labels": ["ci"]}' -cM | gh api --silent /repos/:owner/:repo/issues/1071/labels --input -

Add dedicated healthecheck paths to NextJS apps

They should be /liveness and /readiness

build.yml anchor support/extract common logic

Unfortunately, GitHub actions don't support anchors: https://github.community/t/support-for-yaml-anchors/16128

Look into some kind of simple generator for build.yml that has support for anchors and does not stop us from using anchors when/if GitHub actions support them at a later time.

Move helm sha1 version

Currently it resides in build.yml. Move it to somewhere more obvious.

Separate secret for init containers

Realised there is a potential issue with secrets when the same secret is used from init container and the main one. The secret key is duplicated which might cause problems. Should fix that.

Originally posted by @pshomov in #399 (comment)

Detecting correctly the last commit of the previous push

This might not be what we want, if we push up multiple commits this will only run against 1 up. Can't you use the api to fetch the last completed (successful) build and use that as a base with a fallback to master.

Originally posted by @darrikonn in #31

Security vulnerabilitie CVE-2016-4074 in containers.

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-4074

CI does not run for forked repos

Logging for unhandled exception and unhandled rejected promises

Currently these errors get dumped on the stdout and the stack traces are pretty hard to read.

Create ADR for form library

Currently, island-ui has many components which build on top of Formik. This was chosen by default, but its worth investigating other form libraries and creating an ADR for it.

Library for shared assets

Currently we have a few applications which are duplicating assets like favicons.

We should avoid duplicating assets. Instead we can create a shared library that contains these assets.

From there, they can be imported using webpack, or we can copy them to a public folder in the build step.

Forked repos can't log into ECR

See #935

Handbook is in a private repo

https://github.com/island-is/handbook 404s for me but is linked from the README 😬

Add documentation for how go gain access to secrets and other env variables

Some environment variables should not be required during development, might depend on what project you are developing

Slack notification for broken builds does not working

Fix missing login.js

It affects seems gjafakort, vidspyrna and loftbrú. For example for Loftbrú when you press “Sjá réttindi” tries to load file login.js which is missing. This is causing problems in monitoring.

Address security vulnerability with GitHub Action's `set-env`

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Success check skipped counts as completed

#1055 should have been blocked but it was not.

React static apps don't get to route url routes

Lint CODEOWNERS

As mentioned in #1081 (review), we don't want to accidentally break codeowners.

Add testId to interactive island-ui components

Our shared components need props to help with automated testing.

Interactive components should support a prop called testId, which is forwarded to data-testId on the primary interactive element in the DOM. This kind of attribute works well with Cypress and testing-library.

If a component has sub-components, it can use its testId as a prefix for those components, eg:

const Calendar = ({ testId = &#39;calendar, ...stuff }) =>
  <>
    ...
    <Button testId={`${testId}.nextMonth`} />
  </>

Run docker containers as not-root

After the most recent Dockfile changes related to avoiding generating different layers for the same node modules we needed to add the code assets to the container as root but executed it as a lower privileged user - runner.

That change brought forward the fact that when running certain types of containers - (GraphQL for example, maybe more), they are attempting to write into the current folder.
This is a security issue and we cannot allow to write into files in the current folder. The correct way would be to write content to the temp area.

We have temporarily allowed the code to run as root but we need to fix this ASAP.

Get rid of Postgres service in GitHub Actions CI setup

It is being created for every test no matter if it is using it or not
Cannot be used by tests of multiple services simultaneously easily I think
Binding to CI GHA unnecessarily

Document if resource apis should be prefixed with users collection or read from access token

Add documentation to the API Design Guide if a resource api should wrap the resource under a user collection:

/v1/users/:nationalId/documents

or if this user information should be availble from the access token, then document how resource api should read from the access token.

It should be easy to set up translated user interfaces.
Apps may be client-side or have server-side rendering.
We want to namespace translations and only fetch translations that are needed for each context.
It should be easy to add a new string to be translated, while still supporting a namespace and a description that gives context to editors/translators.
It should be possible to configure deflection and pluraility rules for different languages.
Editors should be able to tweak the copy and translators should be able to submit translations without involving developers.

One proposal is to combine Contentful with i18next (or something home built). We should create an ADR for this.