Islandora module that adds a Google map to an object's display if the object's MODS datastream contains cartographic coordinates.
License: GNU General Public License v3.0
For collection maps we currently grab 20 items at a pass, this was a random number I chose. This ticket is to make this a configurable variable with a default of 20.
Looks like this module doesn't work on objects with the Thesis CModel. Just to be sure, I've tried copying the geographic subject MODS directly from objects that do display a map - but no map on the Thesis.
After the last time I pulled Islandora Simple Map, I could no longer access my Collections tab when managing a collection. Here's what I got in my log:
PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupal.islandora_simple_map_collections_map' doesn't exist: SELECT pid from {islandora_simple_map_collections_map} WHERE pid = :pid; Array ( [:pid] => doh:root ) in _islandora_simple_map_display_collection_map() (line 201 of /opt/rh/httpd24/root/var/www/drupal7/sites/all/modules/islandora_simple_map/includes/utilities.inc).
Uninstalled the module and re-enabled it, and it works fine again. I see there's a "create table" command in the Install file that was added in December, which of course doesn't get run if you're just updating the code without reinstalling.
What would be the best way to inform users that they should uninstall and reinstall if they update their code? Google group perhaps?
When scrolling down a site, hitting the map means the map scrolls instead of the page.
I would use an option to disable scrolling altogether (or click-to-enable scrolling) - would this be welcome?
So I made the example_degrees_coords module to interpret DMS coordinates and convert them to decimal coordinates.
I think this might as well be included as a sub-module of this module, then people can just enable it if they want.
The issue is one part faulty paging logic on my part and one part IslandoraSolrQueryProcessor overriding passed parameters.
I have a fix, but I'll wait to open the PR until https://github.com/mjordan/islandora_simple_map/pull/45/files is merged.
LoC method of writing geographical subjects is different from how Google Maps processes them. Google maps prefers "Armstrong, BC" while LoC prefers "Armstrong (B.C.)".
Because of this, Simple Map using the Geographic Subject could end up showing the wrong location. "Armstrong (B.C.)" shows a bunch of shops with the name Armstrong, whereas "Armstrong, BC" shows the correct city area.
Proposing some functionality that looks for those parentheses and turns them into commas.
Due to the way compounds render as themselves and as their first child you get a map for each.
I have tested not allowing the rendering of the map when their is a islandora:compoundCModel in the $object->models. This makes only the map provided by the underlying islandora:sp_large_image_cmodel renders.
Not sure if that is okay with other users?
We have Islandora Simple Map enabled on several sites in Arca, and while it works perfectly well on Basic and Large Images, the map does not display on Book objects.
Example: http://arcabc.ca/islandora/object/ufv%3A378
Configuration is with the following XPaths:
//mods:subject/mods:cartographics/mods:coordinates
//mods:subject/mods:geographic
//mods:subject/mods:hierarchicalGeographic
Metadata is present in each of the above elements, but no map is generated.
The Google Maps JavaScript API lets you create highly customized maps, including ones displaying multipoint data. This module should provide an option to use that API instead of the simple embed API.
Related issue: #6.
Again for #17 and #10 it would be nice to get a small InfoWindow with some basic information displayed as well as a link back to the Islandora object.
Depending on the use cases it could be as simple or as complex as
I'll need this for my collection work in #17 but it could also make #10 possible.
This task is to add a simple textfield to the admin pages.
The field should be stored in a variable and the field should use the Solr autocomplete to populate.
The Solr field can store any form of coordinates (DSM, decimal, place names, etc) and (building on the work in #25) they can be parsed to the final format after retrieval.
This Solr field would be an opt-in replacement for the built-in XPath query of the MODS record. Other hook_islandora_simple_maps_get_coordinates() implementations would still get run as per normal. Therefore this could also speed up the execution of normal maps as XPaths in MODS would not be necessary.
Alternatively, we can split up these choices and add checkboxes to the admin pages to determine whether:
To make #10 happen we would almost definitely need Solr.
Meta-issue arising here.
In the code you can (and by default do), replace semi-colons with commas in the node values found in the MODS.
https://github.com/mjordan/islandora_simple_map/blob/7.x/islandora_simple_map.module#L157-L169
Why are we doing this?
Did someone have semi-colons instead of commas in their metadata?
Would be neat to generate a page that generates a map of all Islandora objects with location information, with a Solr query.
Could the config menu be tweaked to allow the admin to choose whether the map is expanded or collapsed by default?
If you change the Output to use to pass co-ordinates to maps setting from Co-ordinates (default) to GeoJson and then view a collection map with multiple markers.
The map displays correctly but when you click on a marker you do not see the popup with the title and thumbnail image as well as the link back to the original image.
Administrator is not given permission by default to configure the module, and the configure option does not appear in admin menu until the permission is checked off. Permission should be granted by default, or should accept administrator permissions bypass.
Could the collection map use the available space of the parent DIV instead of being a set size.
@mjordan has used this jQuery selector in past work.
https://github.com/mjordan/islandora_usage_stats_charts/blob/7.x/js/usageStatsChart.js#L64
I found this example for a responsive map.
https://codepen.io/hubpork/pen/xriIz
Would be super cool to see where an object was accessed from. Probably best done as a submodule of this one? Or completely separate? IP addresses stored in Stats' db tables would need to be converted to lat/long to be used by Maps.
System variable islandora_simple_map_collection_maps is absent from islandora_simple_map_uninstall().
Google Maps loves decimal coordinates, but if you have your data in a different format or stored using a custom way we can allow you to write a "getter" that would get the data and reformat it into the standardized way.
A collection map should zoom in to the tightest zoom level that allows all points to be seen at its initial display.
This occurs when using OpenStreetMaps but seems to not be happening for Google Maps.
I was updating documentation and I realize that if you have access to the Islandora Simple Maps admin interface you can disable anyone's collection map.
I then realized that I had half implemented this by specifying a non-existent permission to that tab.
https://github.com/mjordan/islandora_simple_map/blob/7.x/islandora_simple_map.module#L45
This task is to either change that permission to be "administer site configuration" like the others or implement the other permission?
I added a hook for retrieving coordinates but even my example module still uses the MODS datastream. Then it parses the new coordinates.
Perhaps it would be better to use 2 hooks.
The existing hook_islandora_simple_map_get_coordinates(AbstractObject $object) to extract from new locations (ie. alternate datastreams) and the module provides the MODS XPath one.
Then add a new hook hook_islandora_simple_map_parse_coordinates() to allow for custom parsing functions.
This new hook would return (for example)
function example_islandora_simple_map_parse_coordinates() {
return array(
'match_regex' => 'a regular expression string to match against this coordinate type',
'function' => 'the name of the function to call with the coordinate(s) as the only argument',
'file' => 'the file in the hook implementing module to find the above function',
'weight' => 'some way to order the parsing so more common types appear first.',
);
}
The called function above would return a string or array of strings with one or more coordinates parsed into decimal coordinates. This would be what my example module should be called for.
So once we get an array of coordinate strings from the old hook_islandora_simple_map_get_coordinates(), we can run them through the functions returned by the new hook.
Once one matches we use that result (hence the weight ordering).
Might be overkill, but otherwise if you have multiple coordinate systems used in your MODS, you'll have multiple modules parsing your MODS for each set of XPaths just to get the results and then parse them differently.
What I'm not sure about is should we pass the full array of coordinates to the function and let it parse those it matches on or do loop through the coordinates and process each against all hook implementations in order.
thoughts?
We previously developed a module called Islandora Gmap, or Islandora Google Maps to provide functionality for automatically embedding Google Maps on Islandora object landing pages. This module was inspired by Islandora Simple Map, and at the time provided a superset of Islandora Simple Map functionality, but Islandora Simple Map has since been made an an official Islandora Labs module. Other functionality which is of use to us -- the ability to display a single map with multiple annotations from all of its child objects on a collection landing page, to serve as an alternate entry point to the collection -- has since been added to Islandora Simple Map. Because Islandora Simple Map now has a more sustainable maintenance structure, it behooves us to merge our Islandora Gmap functionality into Simple Map.
This functionality includes:
For values like +50.97583,-119.11583; +49.37833,-123.27194; +49.36667,-123.26667, take the first point. Split on ;.
Include in the config form additional (if not then..) options for elements that could contain a geographic reference.
Example: some objects may contain a geographic subject, but no cartographic coordinates. Others may have coordinates but no geographic subject. Module should ideally look first at one element (specified in configuration), then at another, and optionally another, etc.
When displaying huge maps (like http://digital.lib.sfu.ca/islandora/object/bcp%3Acollection/maps) the system queries for all the collection coordinates each time the map is rendered.
If we can agree on a safe way to avoid revealing objects a user doesn't have permission to see, we could cache the array which should really improve performance.
In past I have used the users roles as a key for the cache. So if two users have the same roles then they can share the cache entry. This only works if you don't assign XACML permissions based on username.
Alternatively, we could just enable a cache for anonymous users and logged in users will suffer the consequences.
Hey @mjordan, not sure if this is your module, or something to do with the book solution pack, but I'm not able to get the map to display on any book solution pack objects.
From what I can tell, the XPath if exactly the same, and I'm not seeing anything obvious in the preprocess hook, or template files for the large image solution pack or the book solution pack that would cause the map not to display.
Two examples:
Any ideas?
I can't find much by way of a direct API for using OpenStreetMap similar to how this module uses Google Maps, but the HTML that needs to be generated looks like this:
<iframe width="425" height="350" frameborder="0" scrolling="no" marginheight="0" marginwidth="0" src="http://www.openstreetmap.org/export/embed.html?bbox=-123.38882446289061%2C49.14555903725487%2C-122.93563842773436%2C49.35353208188311&layer=mapnik&marker=49.24965507167121%2C-123.1622314453125" style="border: 1px solid black"></iframe><br/><small><a href="http://www.openstreetmap.org/?mlat=49.2497&mlon=-123.1622#map=12/49.2497/-123.1622">View Larger Map</a></small>The difficulty in assembling this markup is computing the bbox values from the lat/long. A Perl implementation of how to do this is available on the OSM wiki.
Hello @mjordan, I am back to steal more of your wonderful code.
We are migrating a Public Art project, which I built using HTML and javascript many years ago. http://umanitoba.ca/libraries/units/archfa/art_tour/
My idea is to have a map on the collection page that aggregates the points from the items in the collection. For this I thought a block might be better.
I'm gonna fork this and I'll try to not move to far away from your existing implementation.
This is my fault (again), but I added two variables with islandora_simple_maps_*.
This task is to:
hook_update_N task to:
For example, http://digital.lib.sfu.ca/alping-460/niut-range-camp-ridge-north-camel-mountain-aug-22-1967 has two sets of geocordinates in one element:
<cartographics>
<coordinates>+51.585,-124.71722; +51.52333,-124.97861</coordinates>
</cartographics>In cases like this, we should give admins the choice of whether to not render a map, or to render a map showing only the first coordinate. We probably need to give the admin an option to define what characters to separate repeated coordinate on
Some sites may prefer to use a Google Maps API key. The keyed version of the Embed API is much better documented than the non-key version, and may offer some additional features not available in the non-key version. Supporting both versions of the API in this module shouldn't add a lot of complexity.
This needs to pull the entries from Solr because parsing each MODS would be too crazy. Either that or aggregate the points from all the child objects into the Collections MODS record?
I'm thinking only one level deep, again it would be too crazy otherwise. Not sure how to determine specify that a collection should display the map or not? Perhaps make it another block, then the inherent (Show block on specific pages) config can be used?
My use case is migrating this Public Art map (http://umanitoba.ca/libraries/units/archfa/art_tour/) to Islandora. So I think I will also need to be able to create custom info windows, but that may have to be discussed with the collection owner.
If anyone else has a use case, please add it in and I'll keep it in mind when I am working on this.
When building a site of objects to test the issue noted here #10 (comment). I discovered that I have created a problem where if you had an object with coordinates but 0 hooks enabled that handle them then you got no coordinates back.
I am writing up some more tests and a fix for this.
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.