isnull/xattrj

Native xattr wrapper (JNI) for java

xattrj's Issues

Probably a memory leak

I had a look to the code. I think you have to free all you reserve with malloc (also the second buffer you create to build a nul terminated string).

path with space

Code review - some potetial issues

Hi,

I'm really impressed how fast you reacted (for both, bug+feature request).
I'm just doing a full code review (for me for learning how things work and for your lib because I plan to use it in an environment where potentially then thousends of files or folders are marked using xattrs) and tell you, what I found:

You should always call ReleaseStringUTFChars if you called GetStringUTFChars before. See http://stackoverflow.com/questions/5859673/should-you-call-releasestringutfchars-if-getstringutfchars-returned-a-copy

In Java_org_securityvision_xattrj_Xattrj_listAttributes the buffer is always released at the end but might not get initialized (if (bufferLength > 0) ). No idea what will happen then.

That's all I see with my limited c++ knowledge. Good solution to split the null terminated string list on the native side - I tried it today but failed to pass the wohle buffer to java to split it there.

Regards,
Michael.

free null pointner

Hi, I found a little bug.

In the C++ code for listAttributes you do free(buffer) but buffer may not have been allocated if there are no xattr, so it'll crash.

This quick fix works for me:
if (bufferLength > 0) free(buffer);

cheers, reinhard

Feature request: removeAttribute, listAttributes

Hi,

great work. To make it complete, support for listing attribute names and removing attributes would be great.