isotoxin/toxcore-vs

All necessary libs to build static toxcore using Visual Studio 2015

toxcore-vs

All necessary libs to build static toxcore using Visual Studio 2015 (2013 is no longer supported)

Differences from the original toxcore

Current version of toxcore is toktok based, but has some advatages.

Main advantage is PERSISTENT GROUPCHATS compatible with current groupchats.

Tox_Options has addition const char * parameter:
const char * client_capabilities
if client_capabilities is NULL, toxcore-vs works identically to original one. You can provide non-NULL static string with TOX_CLIENT_CAPS_SIZE maximum length, and this string will be sent to another contact whenever the state of the contact becomes online. Other client can read this string with tox_friend_get_client_caps. This is way, that clients can identify clients to enable client-scpecific features.

There are some addition api functions in toxcore-vs:

• const uint8_t *tox_friend_get_client_caps(const Tox *tox, uint32_t friend_number);
  
• void tox_callback_cryptpacket_before_send(Tox *tox, tox_friend_cryptpacket_before_send_cb *callback, void *user_data);
  
• bool tox_friend_send_lossless_packet2(Tox *tox, uint32_t friend_number, const uint8_t *data1, size_t length1, const uint8_t *data2, size_t length2);
  

Build

1. Install Visual Studio 2015 any desktop version (if not yet)
2. run `build_libs_2015.cmd` to build 32 bit libs; run `build_libs_2015.cmd 64` to build 64 bit libs

Another way - create solution and add project (*.vcxproj) files, then build from msvs gui

PS. There are yasm.exe in vpx folder - it necessary to build asm files of vpx lib. If you don't want to run exe from untrusted source, you can download yasm.exe here: http://yasm.tortall.net/Download.html

toxcore-vs's Issues

Use-after-free if the client doesn't accept fake-invite inside the invite callback

Test case: https://github.com/TokTok/c-toxcore/blob/master/auto_tests/conference_double_invite_test.c.

Note how we don't accept the invite in the callback, resulting in undefined behaviour (use-after-free) on the next tox_iterate call. This is an issue, because:

1. Some language bindings (e.g. tox4j) defer callback handling by storing the callback data in a queue and processing it afterwards.
2. The API should generally be robust against misuse. If a standard-conforming program is using the API, it should not cause undefined behaviour inside the implementation.

Missing file: tox_api.c

This file contains tox_options_new and other tox_options functions.

Memory leak in group code (on termination)

Reproducing test case:

int main(void)
{
    // Create toxes.
    Tox *tox1 = tox_new(0, 0);

    // Create two conferences and then exit.
    tox_conference_new(tox1, 0);
    tox_conference_new(tox1, 0);

    tox_kill(tox1);

    return 0;
}

Leak check trace:

=================================================================
==31974==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 312 byte(s) in 1 object(s) allocated from:
    #0 0x7fe092e90090 in realloc (libasan.so.3+0xc2090)
    #1 0x556c66112b1b in realloc_groupchats ../toxcore/group.c:128
    #2 0x556c66119802 in del_groupchat_internal ../toxcore/group.c:1211
    #3 0x556c661279e3 in kill_groupchats ../toxcore/group.c:3885
    #4 0x556c6617807c in tox_kill ../toxcore/tox.c:208
    #5 0x556c660fcd61 in main conference_two_test.c:27
    #6 0x7fe0925cc2e0 in __libc_start_main (libc.so.6+0x202e0)

SUMMARY: AddressSanitizer: 312 byte(s) leaked in 1 allocation(s).

VS2019: error C2491: 'inet_pton': definition of dllimport function not allowed

VS2019 compile x32, but the error rise during compiling x64:
\toxcore-vs-master\toxcore\toxcore\network.c(112,1): error C2491: 'inet_pton': definition of dllimport function not allowed [c:$ABC$\TOX in VS\toxcore-vs-master\toxcore\vs\toxcore_2015_64.vcxproj]