isthereanydeal/augmentedsteam

Augments your Steam Experience

augmentedsteam's Issues

bug report

View foil badge progress button does not work

"Complete your collection" banner hides current lowest price

On store pages such as Magicka 2 which have a bundle on them if you don't own everything in the bundle.

Extension not work when store language is not english

Tried this extension in Chrome dev mode.
Found that when the store language is not english, ES will throw ReferenceError: language is not defined.

js/common.js

    if (Language.isCurrentLanguageOneOf(["brazilian", "french", "italian", "japanese", "koreana", "polish", "portuguese", "russian", "schinese", "spanish", "tchinese", "thai"])) {
       imageName = "img/overlay/early_access_banner_" + language + ".png";
   }

And change language into Language.getCurrentSteamLanguage() could fix that problem.
But I don't know if it's a correct fix.

SteamRep status reports showing donators as banned.

https://steamrep.com/list/D

Open any steam profile associated with a user on this page, instead of showing donator status on their steam community page, it'll show the banned icon/div class as so;

https://github.com/tfedor/Enhanced_Steam/blob/266dd9ca6b0601ebf1b7e2f3ac94f78f2a1d4fa6/js/community.js#L512-L554

[Suggestion] Add a filter to filter out low priced, free, and not released items

There is so much trash in Steam now that looking through "New Releases" tends to be tedious at best. There are many items that have no release date and price and an extraordinary amount of "trash" titles that tend to have low prices.

It would be nice to be able to filter items out that have no price associated with them, are free, and cost under a certain amount. I'm thinking that maybe something similar to the "Items that cost more than" functionality but reversed, where it hides x amount and below, including 0 and unknown.

Support for Chrome 73 new CORS security

Many extension features don't work in Chrome Beta 73.0.3683.27 and later. It will stop working on 12 March 2019 in Chrome 73 release as well.

The error in the Console may look like:

Cross-Origin Read Blocking (CORB) blocked cross-origin response https://... with MIME type application/json. 

See https://www.chromium.org/Home/chromium-security/extension-content-script-fetches .

Workaround: open chrome://flags, set Enable network service flag to Disabled

"Lowest price" and "Best price" inconsistency

In cases where Steam shares the same, lowest price with another store, sometimes Augmented Steam shows that external store in the "Best price" spot, even if in "lowest price" it shows Steam.

https://i.imgur.com/xzAEfXz.png

Customizing Quick Sale price doesn't work

On the Community tab, there is an option to set Quick Sale price. But the button Customize doesn't respond.

I'm using the newest stable Opera build (Currently: 58.0.3135.68) on Windows 10 Desktop.

Steam DB extension integration

Some wishlist notes from the previous repo

After Steam updated the UI for the Wishlist page, the wishlist notes (which personally was my most-used feature of ES) stopped working.

I'd like to request further development of this feature for the new fork. jshackles hinted that it could be working soon prior to the EOL of the project.

Here are references to some of the wishlist notes issues from the previous repo I think are important. Particularly getting them working again as well as being able to export/import the notes specifically. Currently they are only stored in LocalStorage which unfortunately aren't as permanent as I would hope (having lost all of my notes twice now). Maybe they could be stored in JSON or IndexedDB for easier access?

• jshackles/Enhanced_Steam#1552
• jshackles/Enhanced_Steam#1356
• jshackles/Enhanced_Steam#1238

Many thanks for taking on the project! I was so happy to see the news!

Store comparison "View in" setting should use regional prices instead of plain conversion

Self-explanatory:

Some features aren't working

Using FF 65 64bit and Win 7 if that matters. These features don't seem to be working:

Highlights don't work in the suggestion popup when typing in the store search box. Highlights and tags don't work in Wishlist. They mostly don't work in store pages. (The game title text gets highlighted if owned but that's about it)

"Show advanced navigation on inventory page" doesn't work
"Show the number of items on Wishlist" doesn't work
"Set custom background on "Edit Profile" screen" doesn't work
The custom entry under Show Profile Links To doesn't work (still works for Jshackles version)

[Suggestion] Black/Grey profile theme

Since custom profile themes/colours have been added again, would it be possible to add a few extra colour palettes such as a black/grey colour theme? At the moment the clear theme doesn't exactly seem to look too good on certain monochrome profiles.

Market Transactions show wrong currency

The price shown in the left column is okay. But instead of my local currency, it shows the lowest price in euro, which is pretty unhelpful.

[Bug] Badge progress section is broken on DLC (of games that have badges) app pages

Take https://store.steampowered.com/app/947510/Sid_Meiers_Civilization_VI_Gathering_Storm/ as an example, Steam Community badge is shown in badge progress section (and shown twice).

The cause of problem is that hasCards() method returns true since the DLC is categorized as has Steam Trading Cards by Steam.
However, it's the game instead of DLC that has cards. Also, gamecards/" + this.appid HTTP request will be redirected to profile's badge main page instead of the game's badge page.

By the way, view in Steam Card Exchange also has a similar problem.

Filtering issues on Browsing page

Firefox Developer Edition: 66.0b11

There are several issues with the "Hide" filter:
"Items you own": Working
"Items on your wishlist": Working
"Items in your cart": Working
"Items not discounted": Working on first page but the next result set is unfiltered
"Items marked not interested": If this is supposed to filter out things marked as ignored then it doesn't work
"Mixed rating items": Working on first page but the next result set is unfiltered
"Negative rating items": Working on first page but the next result set is unfiltered
"Items that cost more than": Not working

Also, there are two other behaviours that are interesting. If you have filters selected, they don't show in the tags at the top. However, if you press "Enter" inside the "Items that cost more than" text box, all selected filters will present themselves in the tags.

Clicking the top tags will untoggle the filters but will not remove the tags. To remove the tags, you have to untoggle the filters then press "Enter" inside the "Items that cost mroe than" text box.

Allow 'Add Nickname' without having to be friends

ES used to let us add nicknames for any user even if they weren't friends. This was nice because if you wanted to block or ignore someone you could add a nickname for them without having to friend them first. Can you add this feature back?

Have to dismiss update changelist popup twice

Extension update with changelist popup on https://steamcommunity.com/ - dismiss by hitting OK. Now navigate to the Store homepage, and the update changelist will appear again. You have to hit OK on both the community and the store page to actually dismiss the popup.

Issue with EU pricing on tooltips

https://i.imgur.com/kswrxXk.png

been happening since I changed to your fork on Chrome , since the original stopped working after AUD was added

as per the image, the EU price shows up as AUD

this seems to be happening with a friend in UK also, shows GBP price in place of EUR using Firefox

Many localized strings still say "Enhanced Steam" instead of "Augmented Steam"

If the name "Augmented Steam" is going to stick then updating the strings will avoid confusion.

Hiding "About" link will result in plain Steam page

When I'm enabling the "Hide 'About' link" feature in version 0.9.2 on Chrome 72.0.3626.96 every other feature stops working and the store pages will look like without the extension

Coupon Highlighting

After #80, Inventory.getCoupon(appid) is in a few places and needs to be Inventory.getCoupon(subid).

I don't know how to get subid. This needs to be fixed in common.js and community.js

Remove list of all friends that own a game (seems obsolete)

Remove (or at least hide under option) functionality for showing all friends that own a game - this seems to be obsolete, Steam seems to list all users (albeit not in one list, but split to those who played it recently and those who own the game)

Selected currency not showing

If the wallet is in a currency other than the region you're accessing the store from (determined by IP GeoLocation by Steam), it is useful to show your region's price in the comparison panel, in addition to your wallet's region which is displayed originally by the store.

Just removing this line fixes it.
https://github.com/tfedor/Enhanced_Steam/blob/083599e77e4091156ae4b519ace18ae165c8e686/js/store.js#L301
Since the API only tells the region you're currently accessing from (again, IP Geolocation) and not your wallet's region, which determines the currency displayed on the store, this check feels deprecated and hurts the practicality of the regional price comparison panel since it doesn't show your local currency.

Checking a game on BR with an AR wallet: With the line (left) I can't see the price in BR anywhere while the AR price is duped. Without it (right) AR is still duped but I can see the BR price

Lowest price doesn't update when changing sites

When you change the site of your sell listings, the lowest prices for the items won't get shown

Current Player Count Incorrect

The current player count is incorrect on https://store.steampowered.com/app/1025580/Vainglory/ for me. https://steamcharts.com/app/1025580 At the moment shows: 1,256 playing an hour ago, 1,796 24-hour peak, 1,796 all-time peak
But on the steam page it shows: 1,040 playing now, 1,040 today's peak, 1,040 all-time peak

[Suggestion] Re add HD toggle to game store videos

This seems to be removed for some reason and it was a very nice thing to have. I like to see the game im going to get in HD. Not the steam auto resolution that you can't change.

Add option to remove wishlist notes/"add wishlist note" button

This arguably useless feature breaks styles, or at least changes the visuals for the items listed on the wishlist page https://i.imgur.com/w7ZoUWg.png

Please add option to disable this feature for those who don't find it useful and, moreover, intrusive.

As a side not, "click to compute stats" should be moved to the bottom of the list for the same reason - breaking the default view of the steam wishlist.

[Request] Proper changelog for the different versions.

Please :)

[Bug] I18n isn't working properly since no method to set language.

As for the old Enhanced Steam, extension's language is automatically set to the language used on Steam pages (see https://github.com/jshackles/Enhanced_Steam/blob/270c5373b2dedd86935bda9853bc067cfdf7b369/enhancedsteam.js#L15-L27).

However, the new extension doesn't automatically set language. And there aren't a language option in options page ether. As a result, it seems that currently the only way to change extension's language is use Chrome console to exec SyncedStorage.set("language").

[Suggestion] Compare store prices in local AND set currency

The comparing prices feature has been great since original Enhanced Steam. I prefer it to set to EUR, as it's my region in most of the sites. BUT on Steam I got different currency (PLN). Would be nice to optionally make it set to both my local currency and the one I set additionaly. It's not a big deal, since my browser can convert currencies on its own, but thjat way it would be faster.

If You decide to make this to the code, I suggest to be it like:
Current Lowest Price: SET (LOCAL)

So e.g. it would be for me like that:
Current Lowest Price: 56,49€ (244,86zł)

"Default homepage tab" setting gets ignored, always shows "New and Trending"

Chrome latest, additionally tested with no other extensions enabled in Incognito mode.

Regional Price Comparison

My regional currency (PLN/Poland) is shown with EU flag and there is no EU region in the list. Adding Poland to the list doesn't list it. Changing currency from auto-detect to anything else makes the feature broken - it doesn't show at all. My store language is English.

Does not work running Firefox 56.0.2

Addon is enable, but there is no any feature enabled on Steam, as if it were disabled, also, do not saves any setting and I can´t browser to other addon menus like PRICE - COMMUNITY - NEWS - ABOUT - CREDITS

[Suggestion] Allows ES to add the Twitch video showcase without the Twitch link on profile description

Hello, I saw ES have this feature to add a video showcase on the profile when we are streaming on Twitch if we have the Twitch link on the profile description.
But I don't want to put the link on my profile description, is it possible to also read the link directly on the infobox showcase?
Thank you

Refactor SyncedStorage to use Defaults implicitly in get method

Basically we want to remove second optional argument and instead always failover to Defaults object for default value.

Improve i18n template

Some strings are not optimized for i18n, makes it's hard to translate something into languages such as Chinese (maybe some RTL languages too), e.g. "View in" and "View on". The translate friendly string should have a variable placeholder, e.g. "View in __site__", then the Chinese translation will be "在 __site__ 中查看" ("in __site__ view").

And another thing, now there is such an option in settings: "View in: [the currency select box]", this "View in" should be translate differently in Chinese, I suggest split this entry to 2 entries, e.g. "View in currency [select box]" (specify this is a currency).

There may be more strings have similar issue, I just can't list them all here.

Missing some buttons.

Missing "full window" button when watching video.
https://imgur.com/H3HPLFI

[Suggestion] Steam Skins

I just came by some random idea. As there is an option to set color for profiles, it would also be cool to make this possible for whole site. Like making Steam pink, black or red for example.

Latam language is missing

If my store is in latam spanish I get an error:

and in the option, the language is missing:

Español Latinoamericano (or "latam" as used by steam backend)

Get currency from page instead of cookie

If we get the currency from the page element <meta itemprop="priceCurrency" content="USD"> instead of the steamCountry cookie, we get the wallet region, which is what the store currency will be when logged in from another region.

[Suggestion] Filter subscribed workshop items based on whether or not you have all the required items to run it

It would be good for those of us who have a lot of workshop mods and who want to check all the mods we're subscribed to are up to date with what they need.

Best price of store I dont have selected

Currently, Augmented Steam is showing the best price of a store I unchecked in the options.

SteamID is undefined

As the title says, going to a profile it seems like the steamid is undefined. This breaks SteamRep links but also the copy perma profile tool.

Sync options across browsers

Check if we still need/want to use community/steam_store_hover.css

Add custom amount to Steam Wallet not working

Using Augmented Steam 0.9.3 on Firefox 65.0.1 on Windows 10 x64, regular window logged in. Upon setting custom amount on the add funds to wallet page and clicking the button, on the next page the amount is back to the initial default value of 10. Using Inspect Element(Q) on the button and changing in the Inspector the field data-amount then clicking the button does wield the desired value to show up next page.

New Feature Suggestion: Download size

Adding a new feature to find out the download size of a game from store front.

Options page, left-side menu scrolling down

Not really an issue, more an observation, feel free to close it if you decided to go that way:

On the old extension's settings page, as you scrolled down the menu buttons to change section ("Store", "price", etc) stayed at the top (position: fixed;).

With the new Augmented Steam, the menus disappear as you scroll. Again, this might be intended and just close this issue if you plan on leaving it this way :)

Otherwise looks good, excellent job and SUUUPER happy you took it over, I don't see anyone else who could have been more appropriate than isthereanydeal.com!

Hiding items marked as not interested doesn't work

Extension version: 0.9.3
Repro steps:

0. Log into Steam
1. Navigate to a Steam search selection where there are visible items marked "Not Interested" (https://store.steampowered.com/search/?term=)
2. Under the "Hide" filter options, select "Items marked not interested"

Expected: items marked not interested are hidden
Actual: items marked not interested are still shown
Screenshot:

Notes: This has been a bug in Enhanced Steam for a while. This would be a huge value add to the extension for me. I've marked almost 2,000 products as "Not Interested" on Steam, and it would be great to truly have those be gone instead of cluttering my searches.

EDIT: Spent some time digging into the root cause. Here's the code that's supposed to do the hiding: https://github.com/tfedor/Enhanced_Steam/blob/779d0954ae62ec64c4d1d03ed2e5c3516b5022cc/js/store.js#L2262 Unlike the code for the other hide functionality, this one doesn't node.style.display = "none";. If I manually add a css rule to .ds_ignored {display: "none";}, the games appear to be hidden correctly. I imagine this is a one-line fix of adding node.style.display = "none"; to the end of this logic. Unfortunatley, I'm not sure how to test this fix locally without a js\config.js