@tinrabuzin @MaximeBaudette I would like to address an important issue regarding the approach when changing models that have been through a sw-to-sw validation.
When modifying some "weird" blocks, or something of the model, as you are doing now, we have to be very careful not to affect models related to a domain-specific tool.
If the model has been validated against PSS/E and Eurostag, and modifications are made, we would have to do the validation against the domain specific tool again or compare with the previous implementation.
Otherwise, we can't argue that we can produce similar results than domain specific tools, and this can have a negative impact on user adoption. Remember that one key goal to make this library successful is that the users can have confidence that they will get the same (or better) results than their tool of choice. If we do not take care of this now, we will be faced with more resistance to change from the power system community, and the library will have the same fate as others in the past.
We need to establish a procedure to do this.
I open this issue so that you guys can discuss with @petitrenaudseb @dietmarw @AIAitesla on how to approach this. One suggestion is that we document this through the issue tracker: 1 model = 1 issue.
@jbheyberger and @geofjamg please add your comments about this also.
I am assigning @tinrabuzin and @MaximeBaudette to follow up on this.