itonomy/module-flowbox

Flowbox integration for Magento2

module-flowbox's Issues

"Composer require" isn't working.

  [InvalidArgumentException]
  Could not find a matching version of package itonomy/module-flowbox. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum
  -stability (stable).

Ondersteun ook Magento zonder inventorymodules

Edit: translated to English.

Subject: Support Magento without Inventory modules enabled

It's not possible to use the Flowbox module when the Inventory modules are disabled. After adding a flowboxwidget to a page and saving that page, the following error is shown:

[2021-03-05 12:51:58] report.CRITICAL: Error: Cannot instantiate interface Magento\InventoryCatalogApi\Model\GetSkusByProductIdsInterface in /home/john/doe/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:121

In code vendor/itonomy/module-flowbox/Block/Widget/Flow.php one can see that the following interface is called:

\Magento\InventoryCatalogApi\Model\GetSkusByProductIdsInterface

Could this call be rewritten so to support Magento without Inventory modules enabled. This because I don't have an option to enable those inventory modules in my Magento installation.

Tnx.

Using `dynamic-tag` the widget shows all images not images with tag

Removing line 100 in view/frontend/web/js/flowbox.js solves my issue.

lazyLoad: issue --- Wrong usage of Elvis operator ?:

It seems like even though we set lazyLoad: False in boolean (settings of your module) we'll be forced to use lazyLoad: True
Could you check it out?
I assume it should be

'lazyload' => (bool) ($this->getData('lazyload') ?: false),

module-flowbox/src/Block/Widget/Flow.php

Line 54 in 00b5a70

'lazyload' => (bool) ($this->getData('lazyload') ?: true),

Setup patch `AddAlternativeProductIdentifierAttributes` add "text" attributes as "filterable"

Hi,
after having upgraded to the 1.4.3 version of the module, we ran an issue on our product listing pages :
the 3 attributes created with the setup patch https://github.com/Itonomy/module-flowbox/blob/1.4.3/src/Setup/Patch/Data/AddAlternativeProductIdentifierAttributes.php are declared with type "text" and with the attribute "filterable" to "true", and that creates the error below with our Elastic Search integration :

ssh.eu-3.magento.cloud: [2021-09-07 07:02:52] report.CRITICAL: {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"Text fields are not optimised for operations that require per-document field data like aggregations and sorting, so these operations are disabled by default. Please use a keyword field instead. Alternatively, set fielddata=true on [ean] in order to load field data by uninverting the inverted index. Note that this can use significant memory."}],"type":"search_phase_execution_exception","reason":"all shards failed","phase":"query","grouped":true,"failed_shards":[{"shard":0,"index":"magento2_product_56_v168","node":"8EiuKSMCRnuTvSpQUznjDg","reason":{"type":"illegal_argument_exception","reason":"Text fields are not optimised for operations that require per-document field data like aggregations and sorting, so these operations are disabled by default. Please use a keyword field instead. Alternatively, set fielddata=true on [ean] in order to load field data by uninverting the inverted index. Note that this can use significant memory."}}],"caused_by":{"type":"illegal_argument_exception","reason":"Text fields are not optimised for operations that require per-document field data like aggregations and sorting, so these operations are disabled by default. Please use a keyword field instead. Alternatively, set fielddata=true on [ean] in order to load field data by uninverting the inverted index. Note that this can use significant memory.","caused_by":{"type":"illegal_argument_exception","reason":"Text fields are not optimised for operations that require per-document field data like aggregations and sorting, so these operations are disabled by default. Please use a keyword field instead. Alternatively, set fielddata=true on [ean] in order to load field data by uninverting the inverted index. Note that this can use significant memory."}}},"status":400} {"exception":"[object] (Elasticsearch\\Common\\Exceptions\\BadRequest400Exception(code: 400): {\"error\":{\"root_cause\":[{\"type\":\"illegal_argument_exception\",\"reason\":\"Text fields are not optimised for operations that require per-document field data like aggregations and sorting, so these operations are disabled by default. Please use a keyword field instead. Alternatively, set fielddata=true on [ean] in order to load field data by uninverting the inverted index. Note that this can use significant memory.\"}],\"type\":\"search_phase_execution_exception\",\"reason\":\"all shards failed\",\"phase\":\"query\",\"grouped\":true,\"failed_shards\":[{\"shard\":0,\"index\":\"magento2_product_56_v168\",\"node\":\"8EiuKSMCRnuTvSpQUznjDg\",\"reason\":{\"type\":\"illegal_argument_exception\",\"reason\":\"Text fields are not optimised for operations that require per-document field data like aggregations and sorting, so these operations are disabled by default. Please use a keyword field instead. Alternatively, set fielddata=true on [ean] in order to load field data by uninverting the inverted index. Note that this can use significant memory.\"}}],\"caused_by\":{\"type\":\"illegal_argument_exception\",\"reason\":\"Text fields are not optimised for operations that require per-document field data like aggregations and sorting, so these operations are disabled by default. Please use a keyword field instead. Alternatively, set fielddata=true on [ean] in order to load field data by uninverting the inverted index. Note that this can use significant memory.\",\"caused_by\":{\"type\":\"illegal_argument_exception\",\"reason\":\"Text fields are not optimised for operations that require per-document field data like aggregations and sorting, so these operations are disabled by default. Please use a keyword field instead. Alternatively, set fielddata=true on [ean] in order to load field data by uninverting the inverted index. Note that this can use significant memory.\"}}},\"status\":400} at /app/7t57if6dywbwe/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php:632)"} []