Giter Site home page Giter Site logo

phototweaks's People

Contributors

appriatt avatar brightsider avatar caotrido avatar giladno avatar itouch2 avatar jeffreyjackson avatar nikhilmanapure avatar wowmendezz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

phototweaks's Issues

What's the `checkScrollViewContentOffset` method do?

Firstly, thanks your fantastic works.
I checked codes and can not understand checkScrollViewContentOffset did clearly. When I commented those invocations simply, it seems that no weird actions occur.
Could you explain the related codes?

Handle Orientation Changes

The PhotoTweaksViewController does not handle orientation changes gracefully, often resulting in misplaced UI components. Could you give me some advice about handling orientation changes, or look into it yourself?

Thanks for this great component!

Memory Deallocations

Hi again!

I was running the "Analyze" in Xcode, as well as the Instruments for Memory Allocations/Leaks, and noticed that when the PhotoTweaks is used, then dismissed, the memory doesn't drop back down to where it was. Something isn't getting freed.

Running the Analyze shows in "saveBtnTapped":
Object leaked: allocated object is not referenced later in this execution path and has a retain count of +1.

I started running instruments on my app because I noticed that it's getting a lot of low memory warnings from the iOS SDK.

Rotation Issues

If trying to rotate 90 degrees to a landscape view from a portrait view it appears the limits of the window are based on the dimensions of the portrait view. Might I suggest adding either a button to rotate the image 90 degrees below the reset button or using some variant of sin((angle+M_PI_2+M_PI_4)*2)<0 to change the bounds to map height to width and width to height in those scenarios

Crop rect behaves weirdly

Hello again itouch2,

You might be aware of this issue, but I noticed a weird behavior in the crop rect, for example if I pull the lower horizontal line downwards (outside of the bounds), the WHOLE rect becomes smaller, not just that edge is restored to the lower bound of the image.

All sides collapse closer together. You can keep doing that and end up with a 1 pixel rect.

Thought to let you know, good stuffs!

Thanks!

Reset button

Hi itouch2, great module you created! :)

I edited the PhotoTweaksViewController to add a "RESET" button similar to Apple's Photos Edit feature.

At first I tried performing the reset in the PhotoTweakView class, that way I can "animate the reset", to look cool, but then I stumbled up a lot of issues because there are many moving parts (crop rect, grids, scrollview bounds, etc.)

So I ended up just adding the reset button to the PhotoTweaksVC, and drop the photoView from superview and add a new one. Which is ok, but not as cool.

Anyway, it's just a suggestion, if you have time, would be cool to have a reset button.

Thanks!

Image cropped size

version 1.0.3

Lets say image size is 2448x3264, and do the crop on screen of the the width as 1224x3264, but the final output image size is 2448x6157, this is a bug?

Want fixed options for CropView

screen shot 2017-06-15 at 5 23 35 pm

I want such options and not want to let user change CropView's frame by touching. Can you show me some way? or At least few hints about how to approach

pod

could you plz make it pod

text on photo

could you plz add this feature ability to add text on photo

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.