itsandreramon/compose-maps-app

Android app that has been built as part of the Mobile User Experience course at the University of Applied Sciences Brandenburg.

compose-maps-app's Issues

improve handling in view models when place is null

disable Google Map view reload when navigating back and forth

Review overview UI state not null check

https://github.com/itsandreramon/mux-rulona/blob/4d41fd48e5295ce64993fa770e7adb1757362c3b/ui/src/main/java/de/thb/ui/screens/places/PlaceDetailScreen.kt#L88

App Intro

Bei einigen App gibt es am Anfang 2-5 Slides, die man durch gehen kann. Alternativ gibt es unten rechts immer ein "überspringen"

Das zum Thema Anleitung vielleicht.

Use unmerged tree in ui tests

Wait for Compose Beta 08 support in Koin

InsertKoinIO/koin#1098

Use Nested Navigation

improve caching

Use Mavericks async support

https://airbnb.io/mavericks/#/async

Use Robolectric on CI

Compose Beta 09 can support Robolectric: android/compose-samples#556

Move EditState callbacks into EditState class

Fix wrong usage of applicationScope inside repositories

applicationScope should only be used when altering the database.

override suspend fun getByIdOnce(id: String): PlaceEntity? {
    return withContext(dispatcherProvider.database()) {
        applicationScope.async {
            placesRoomDao.getByIdOnce(id)
        }.await()
    }
}

State gets corrupted after setting focus in search bar

fix PlaceDetails back-navigation

Make PlaceDetails in Route separate screen

align with PlacesScreen

Use new Permissions API in Accompanist

https://google.github.io/accompanist/permissions/
https://github.com/android/compose-samples/pull/568/files

Fix place details search state flicker

2021-07-24 12:45:58.065 21626-21626/? E/RouteViewModel: new state: SearchUiState(query=b, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=BAR, name=Barnim, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=EE, name=Elbe-Elster, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=2021-07-23T13:34:02.254Z), PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=BRB, name=Brandenburg an der Havel, type=landkreis, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=CB, name=Cottbus, type=landkreis, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=BZ, name=Bautzen, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=ERZ, name=Erzgebirgskreis, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=PIR, name=Sächsische Schweiz-Osterzgebirge, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BB, name=Brandenburg, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)])
2021-07-24 12:45:58.065 21626-21626/? E/RouteViewModel: old state: RouteState(uiState=SearchUiState(query=ber, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)]))
2021-07-24 12:45:58.065 21626-21626/? E/RouteViewModel: new state: SearchUiState(query=ber, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)])
2021-07-24 12:45:58.066 21626-21626/? E/RouteViewModel: old state: RouteState(uiState=SearchUiState(query=b, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=BAR, name=Barnim, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=EE, name=Elbe-Elster, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=2021-07-23T13:34:02.254Z), PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=BRB, name=Brandenburg an der Havel, type=landkreis, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=CB, name=Cottbus, type=landkreis, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=BZ, name=Bautzen, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=ERZ, name=Erzgebirgskreis, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=PIR, name=Sächsische Schweiz-Osterzgebirge, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BB, name=Brandenburg, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)]))
2021-07-24 12:45:58.066 21626-21626/? E/RouteViewModel: new state: SearchUiState(query=b, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=BAR, name=Barnim, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=EE, name=Elbe-Elster, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=2021-07-23T13:34:02.254Z), PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=BRB, name=Brandenburg an der Havel, type=landkreis, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=CB, name=Cottbus, type=landkreis, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=BZ, name=Bautzen, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=ERZ, name=Erzgebirgskreis, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=PIR, name=Sächsische Schweiz-Osterzgebirge, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BB, name=Brandenburg, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)])
2021-07-24 12:45:58.066 21626-21626/? E/RouteViewModel: old state: RouteState(uiState=SearchUiState(query=ber, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)]))
2021-07-24 12:45:58.066 21626-21626/? E/RouteViewModel: new state: SearchUiState(query=ber, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)])
2021-07-24 12:45:58.066 21626-21626/? E/RouteViewModel: old state: RouteState(uiState=SearchUiState(query=b, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=BAR, name=Barnim, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=EE, name=Elbe-Elster, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=2021-07-23T13:34:02.254Z), PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=BRB, name=Brandenburg an der Havel, type=landkreis, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=CB, name=Cottbus, type=landkreis, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=BZ, name=Bautzen, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=ERZ, name=Erzgebirgskreis, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=PIR, name=Sächsische Schweiz-Osterzgebirge, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BB, name=Brandenburg, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)]))
2021-07-24 12:45:58.066 21626-21626/? E/RouteViewModel: new state: SearchUiState(query=b, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=BAR, name=Barnim, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=EE, name=Elbe-Elster, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=2021-07-23T13:34:02.254Z), PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=BRB, name=Brandenburg an der Havel, type=landkreis, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=CB, name=Cottbus, type=landkreis, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=BZ, name=Bautzen, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=ERZ, name=Erzgebirgskreis, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=PIR, name=Sächsische Schweiz-Osterzgebirge, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BB, name=Brandenburg, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)])
2021-07-24 12:45:58.066 21626-21626/? E/RouteViewModel: old state: RouteState(uiState=SearchUiState(query=ber, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)]))
2021-07-24 12:45:58.066 21626-21626/? E/RouteViewModel: new state: SearchUiState(query=ber, location=lat/lng: (52.2,13.4), searchedPlaces=[PlaceEntity(id=OHV, name=Oberhavel, type=landkreis, incidence=15.5, trend=0, website=https://www.oberhavel.de/, example=false, isBookmarked=true, searchedAtUtc=2021-07-21T17:07:05.156Z), PlaceEntity(id=OSL, name=Oberspreewald-Lausitz, type=landkreis, incidence=0.0, trend=0, website=, example=false, isBookmarked=false, searchedAtUtc=null), PlaceEntity(id=DE-BE, name=Berlin, type=bundesland, incidence=0.0, trend=0, website=, example=true, isBookmarked=false, searchedAtUtc=null)])

Handle network errors

Use Constructor Injection inside ViewModels for better testing