ivarni/get-selenium

get-selenium's Issues

Communicate better via console

console.log messages could should be better at communicating what's going on.

Check code coverage for the tests

SSIA

support forceUpdate?

selenium-download provides a forceUpdate method that wipes the tmp directory but this module isn't using one. Not sure if that method makes sense and if there's any point supporting it.

Just supporting the signature and delegating to update would surely achieve the same thing?

The update method on the api isn't working

I naively thought that this would make sure the files were cleared out before calling ensure but it seems to me they're not. On a slow wifi, which I'm currently stuck with, the second test scenario runs way too fast.

Throws error if target path does not exist

Should create directory instead

Tests should verify if HTTP requests are made or not

The tests should check that files are fetched over HTTP when we expect them to be and not fetched over HTTP when we don't expect them to be.

This can be done using nock with respondWithFile and explicitly setting response headers so the checksum works out but it gets messy quick and it would be better to just spy on network traffic without mocking anything. Somehow.