Giter Site home page Giter Site logo

Comments (8)

Izheil avatar Izheil commented on August 12, 2024

Which version of firefox and OS are you using? Since they seem to change the tab selectors on Firefox 66 again, the issue you mentioned happened there. There also seems to be some differences on windows 10 and older windows versions.

If on FF65 stable, are you using the scrolling version, or the infinite rows one?

And lastly... are you using a clean install from userchrome from this repository?

To change the height you can add to your userchrome.css the variable --tab-min-height: the-height-you-want-here px !important;.

Make sure to place it after the line that says :root:-moz-lwtheme { but before the closing } (asuming you are using something else than only multirow, if not just copy that line and place the variable as mentioned).

from quantum-nox-firefox-dark-full-theme.

 avatar commented on August 12, 2024

So I use FF65 stable on Win10 x64.
Yes I put your files (and only yours, but onlyMultiRowTabLiteforFxFF67.uc.js, userChrome.css and userChrome.xml ) in chrome folder.

So I managed to reduce the height of rows, except for when one tab of the row is active and except for the last row where the + on the far right (Open a new tab) keeps this little offset up and then push the whole row slightly down.

In fact to be more precise, any active tab and the + (Open a new tab), create some pixel above which push the whole row slightly down and create a little gap.
This did not exist with your previous file of 01-02-2019.

row gap

See the difference between top row with an active tab, bottom row with the + pushing slightly up, and he middle row which has a normal gap.

from quantum-nox-firefox-dark-full-theme.

Izheil avatar Izheil commented on August 12, 2024

If you are using stable version you should be using MultiRowTabLiteforFx.uc.js, not the FF67 versions, since the FF67 one uses the different selectors introduced on FF66+ (so it would not work right with FF65). You will only need to use the FF67 versions once firefox updates to FF66+.

I'll specify it better in the readme.

You also mentioned that you wanted the tabs on bottom to have the same fixed width as the full-of-tabs rows on your first post? They are suposed to resize to become smaller as more tabs are open to fit more in the row (since when they are smaller you can't fully read the titles on them), so them being bigger is the desirable effect intended.

If you want them to have the same width every time (so they won't resize), you'd have to edit the JS file for multirow, and change this line that is almost on top of the file:

    .tabbrowser-tab:not([pinned]) {
        flex-grow:1}

To this:

    .tabbrowser-tab:not([pinned]) {
        flex-grow:1;
    	max-width: var(--tab-min-width) !important}

from quantum-nox-firefox-dark-full-theme.

 avatar commented on August 12, 2024

All good now for this little gap or offset issue.
You are right, I thought that MultiRowTabLiteforFxFF67.uc.js was good for FF65 and already prepared for the next Firefox releases.

Regarding the fix width of the bottom tabs, yes this is exactly what I wish to have and it was working that way with MultiRowTabLiteforFxFF67.uc.js and not anymore with MultiRowTabLiteforFx.uc.js.
So I will try the change you propose.

And finally regarding this multirow tabs subject, I managed to reduce the height of the tabs o 20px which reduces every rows and give more space for the main window for websites.

Also, I appreciate your dark theme very much and I can see the great and huge work (even if I don't understand everything...).
Perhpas a little thing could be done regarding the selection, for example, of the content of the URL bar. The dark background becomes full whit when selecting the URL. Perhaps this could be darker es it is the only full white item displayed. In fact , this white background in other places, but I can't remember where exactly.

Thank very much again for your nice work and kind help.

Lim.

from quantum-nox-firefox-dark-full-theme.

Izheil avatar Izheil commented on August 12, 2024

I just updated userchrome and usercontent so that you can now change the background and text color of selected text on the url bar and on about: pages. They will be bluish by default now.

In userchrome you can now change the colors changing the hex values of this rule (it is located below both the :root rules in the updated version):

/* Highlight color on browser windows (url bar, library, search box, bookmarks properties...) */
#urlbar *|*::selection, .searchbar-textbox *|*::selection, #infoBox *|*::selection, 
#editBMPanel_namePicker *|*::selection, #editBMPanel_tagsField *|*::selection,
#editBMPanel_tagsSelector *|*::selection, #placesToolbar *|*::selection,
#mainDeck *|*::selection, dialog *|*::selection, #certDetails *|*::selection,
#SignonViewerDialog *|*::selection, #CookiesDialog *|*::selection {
  /* This is the background color */
  background: #a22 !important;
  /* This is the text color */
  color: #fff !important}

As for usercontent (for the about: pages), you can change the highlight colors using the
--highlight-on-selection-bg and --highlight-on-selection-text variables inside it.

from quantum-nox-firefox-dark-full-theme.

 avatar commented on August 12, 2024

Sorry for my late answer Izheil, I was a bit busy these last days.

So I changed the userChrome.css and it works perfectly. I use #666666 and #d9d9d9 and it looks fine for me.

I haven't change usercontent as I have not put this file in the Chrome folder yet. In fact, I don't see what it is for compared to userChrome. And because, I don't know coding, I try to make all this as simple as possible for my very little knowledge.

Thank you again for your kind help !

from quantum-nox-firefox-dark-full-theme.

Izheil avatar Izheil commented on August 12, 2024

Usercontent changes the about: pages of firefox, such as the preferences page, or addons page, and even some firefox support pages that couldn't be themed otherwise.

You don't really need it if you are okay with those pages being white.

Userchrome only changes the browser windows, such as the navigator toolbox (where the url bar is, etc), or some dialog windows, but it won't affect things inside the websites viewing area.

from quantum-nox-firefox-dark-full-theme.

 avatar commented on August 12, 2024

Clear explanations ! All understood. Thanks 👍

from quantum-nox-firefox-dark-full-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.