j1marotta/node-atm-machine

Updating and old ruby program into Node.

This is my atm machine program, for a challenge Friday august 3rd 2017 at Code Academy.

-- Re imagined with Node.

Our main conditions are to accept withdrawals, deposits , display balance and use a pin.

please put police.txt in the same directory to maximise effect.

Dependencies include

• https://github.com/Marak/say.js

to run node index.js

node-atm-machine's Issues

Overlapping speech on Windows

I fixed the bug locally, but worth pondering how this snippet works:

const wait = ms => {
  return new Promise(resolve => setTimeout(resolve, ms))
}

And how that relates to this snippet from the say docs:

// Fire a callback once the text has completed being spoken
say.speak("What's up, dog?", 'Good News', 1.0, (err) => {
  if (err) {
    return console.error(err)
  }
 
  console.log('Text has been spoken.')
});

Could be relevant... 🤔

Is the ATM meant to automatically exit after a withdrawal?

Should gs state be used to exit instead of process.exit?

Could speech.js just be a json file with key/value?

Seems like a switch isn't necessary.

No Quick Start?

Something like

git clone ... && npm start

or even better publish it to npm and use npx node-atm-machine.

Another option is to have your project available with a live example somewhere (if possible), in this case that's hard because of say but otherwise there's options available like runkit/glitch.

App crashes when making a deposit.

Is it ok I can deduct more money than I have?