j3fftw1/soundmuffler

Adds a SoundMuffler to Slimefun. Muffles nearby sounds.

Hi there, I'm Panda - aka J3fftw1 👋

I work as full time contractor for Tennet.

• 🌱 I’m currently learning Java and JS.
• 💬 Ask me about anything, I mean anything you want just ask me about it
• 📫 You can reach me on Discord, j3fftw
• ⚡ Fun fact: Did you know Panda.com is worth 13 million euro

Best domains I own!

• https://i-need.beer/
• https://please.com.vc/
• https://youwontpassipv6.com/
• https://youwontpassipv4.com/

soundmuffler's Issues

Much console spam with sf build 668

I can probably disable this plugin temporarily... I don't know if it is what is causing the other issue but other addon related blocks on the same network as this device run for a few moments and then vanish.

https://pastebin.com/5CheELkm

Error spamming the console

Hi, I'm running the latest builds + soundmuffler 20 devbuild:

And I'm getting these errors sometimes https://pastebin.com/H9mH2qDL

The addon needs updating.

Hello Panda,

I'm creating this today to inform you that the addon needs to be updated sometime soon so that it will work with the latest DEV Builds of Slimefun-4. The reason for this is so that server owners, administrators, or co-owners like myself don't have to constantly be waiting for an update for an addon that seems like it is abandoned by this point though it has been almost a month now. I kindly hope that you take my request and put it to use, and I hope to speak with you again sometime soon.

Regards,

Cyber
WonderCraft Administration

Warning message - question

Hi, I'm getting this warning in console, do you think that you could fix it?

[05:07:05] [Server thread/WARN]: [SoundMuffler] =================================================
[05:07:05] [Server thread/WARN]: [SoundMuffler] SoundMuffler is using a deprecated version of
[05:07:05] [Server thread/WARN]: [SoundMuffler] bStats which is bundled with Slimefun.
[05:07:05] [Server thread/WARN]: [SoundMuffler] Future versions will not include this file anymore.
[05:07:05] [Server thread/WARN]: [SoundMuffler] SoundMuffler needs to be updated as soon as possible.
[05:07:05] [Server thread/WARN]: [SoundMuffler] =================================================

Reported also to author of extraTools and got this reply Sfiguz7/ExtraTools#13.

Unhandled exception occured in onPacketSending(PacketEvent) for SoundMuffler

Loaded class dev.j3fftw.soundmuffler.SoundMufflerListener from SoundMuffler vDEV - 1 (git e83538c) which is not a depend, softdepend or loadbefore of this plugin.
[SoundMuffler] v
com.comphenix.protocol.reflect.FieldAccessException: Field index out of bounds. (Index: 1, Size: 1)
more in:
https://pastebin.com/Zbn0CvbG

[19:47:34 INFO]: Paper v1_15_R1 (89)
[19:47:34 INFO]:
[19:47:34 INFO]: CS-CoreLib vDEV - 83 (git 8081bb4f)
[19:47:34 INFO]: Slimefun vDEV - 433 (git 6f7f6c63)
[19:47:34 INFO]:
[19:47:34 INFO]: Installed Addons (13)
[19:47:34 INFO]: DyedBackpacks vDEV - 1 (git 4b4d1f0f)
[19:47:34 INFO]: SoundMuffler vDEV - 1 (git e83538c)
[19:47:34 INFO]: SlimefunOreChunks vDEV - 3 (git 7ddf966e)
[19:47:34 INFO]: SlimeXpansion vDEV - 4 (git 198cd0aa)
[19:47:34 INFO]: HotbarPets vDEV - 24 (git 0e26577b)
[19:47:34 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[19:47:34 INFO]: ExoticGarden vDEV - 30 (git d4bc7cc2)
[19:47:34 INFO]: Barrels vDEV - 8 (git 447cb487)
[19:47:34 INFO]: ElectricSpawners vDEV - 6 (git 845b6076)
[19:47:34 INFO]: ExtraHeads vDEV - 9 (git 32435a1f)
[19:47:34 INFO]: SoulJars vDEV - 10 (git 58202ab6)
[19:47:34 INFO]: PrivateStorage vDEV - 8 (git 6b242fc5)
[19:47:34 INFO]: ChestTerminal vDEV - 20 (git a698c614)

error on startup then plugin get disabled

https://gyazo.com/fd094bdc8faef8807abb3c8362dede0a

this show's up at startup

[21:57:22] [Server thread/INFO]: [SoundMuffler] Enabling SoundMuffler vDEV - 2 (git ae10df0)
[21:57:22] [Server thread/ERROR]: Error occurred while enabling SoundMuffler vDEV - 2 (git ae10df0) (Is it up to date?)
java.lang.NoSuchFieldError: ENTITY_SOUND
at dev.j3fftw.soundmuffler.SoundMufflerListener.(SoundMufflerListener.java:20) ~[?:?]
at dev.j3fftw.soundmuffler.SoundMuffler.onEnable(SoundMuffler.java:11) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[patched_1.14.4.jar:git-Paper-223]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:338) ~[patched_1.14.4.jar:git-Paper-223]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:420) ~[patched_1.14.4.jar:git-Paper-223]
at org.bukkit.craftbukkit.v1_14_R1.CraftServer.enablePlugin(CraftServer.java:467) ~[patched_1.14.4.jar:git-Paper-223]
at org.bukkit.craftbukkit.v1_14_R1.CraftServer.enablePlugins(CraftServer.java:381) ~[patched_1.14.4.jar:git-Paper-223]
at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:474) ~[patched_1.14.4.jar:git-Paper-223]
at net.minecraft.server.v1_14_R1.DedicatedServer.init(DedicatedServer.java:290) ~[patched_1.14.4.jar:git-Paper-223]
at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:876) ~[patched_1.14.4.jar:git-Paper-223]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_131]
[21:57:22] [Server thread/INFO]: [SoundMuffler] Disabling SoundMuffler vDEV - 2 (git ae10df0)

if you need more info, ping me on discord

Error on the newest SF version

[13:17:13] [Server thread/ERROR]: Error occurred while enabling SoundMuffler vDEV - 12 (git 7303b3a9) (Is it up to date?)
java.lang.NoSuchMethodError: 'void me.mrCookieSlime.Slimefun.api.Slimefun.registerResearch(me.mrCookieSlime.Slimefun.Objects.Research, org.bukkit.inventory.ItemStack[])'
	at dev.j3fftw.soundmuffler.SoundMuffler.onEnable(SoundMuffler.java:30) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[patched_1.16.1.jar:git-Paper-101]
	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:380) ~[patched_1.16.1.jar:git-Paper-101]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483) ~[patched_1.16.1.jar:git-Paper-101]
	at org.bukkit.craftbukkit.v1_16_R1.CraftServer.enablePlugin(CraftServer.java:500) ~[patched_1.16.1.jar:git-Paper-101]
	at org.bukkit.craftbukkit.v1_16_R1.CraftServer.enablePlugins(CraftServer.java:414) ~[patched_1.16.1.jar:git-Paper-101]
	at net.minecraft.server.v1_16_R1.MinecraftServer.loadWorld(MinecraftServer.java:471) ~[patched_1.16.1.jar:git-Paper-101]
	at net.minecraft.server.v1_16_R1.DedicatedServer.init(DedicatedServer.java:241) ~[patched_1.16.1.jar:git-Paper-101]
	at net.minecraft.server.v1_16_R1.MinecraftServer.v(MinecraftServer.java:940) ~[patched_1.16.1.jar:git-Paper-101]
	at net.minecraft.server.v1_16_R1.MinecraftServer.lambda$a$0(MinecraftServer.java:177) ~[patched_1.16.1.jar:git-Paper-101]
	at java.lang.Thread.run(Thread.java:832) [?:?]

Plugin doesn't work
Minecraft Version: 1.16.1
CS-CoreLib Version: 88
Slimefun Version: 588
Plugin Version: 12

@J3fftw1

Thread dumping

I went to try to get an assist from paper since there was so much connection nonsense in front of it I couldn't find a plugin to look at initially, but they found it pretty quickly... snippet of that discussion:

zAikarToday at 11:36 AM
@mr_coffee1026 remove Sound muffler plugin, its cause
mr_coffee1026Today at 11:36 AM
orly
zAikarToday at 11:36 AM
i tried to reduce risk of it last night but caused other bugs, ill try more later
that plugin is accessing world state asynchronously
not safe, and is what caused this

Things will run fine for a time then the server freezes up, even logs don't happen for a few moments before the thread dump begins. Since removing SoundMuffler, the server has run overnight now without doing this: https://pastebin.com/TtuHFXvP

I've been getting these "This is not a bug or a crash do not report to paper" insanity spam since just after Paper build 230. So up to and including build 230... SoundMuffler's approach was not an issue. I only saw anything about packet nonsense in build 244 (which I never ran), and which was reverted in 245 (which is where the above thread dump came from).

[22:19:14 INFO]: Paper v1_15_R1 (245)
[22:19:14 INFO]:
[22:19:14 INFO]: CS-CoreLib vDEV - 85 (git 4a7fce52)
[22:19:14 INFO]: Slimefun vDEV - 497 (git 4131a900)
[22:19:14 INFO]:
[22:19:14 INFO]: Installed Addons (17)
[22:19:14 INFO]: DyedBackpacks vDEV - 5 (git 129670c7)
[22:19:14 INFO]: ExtraTools vDEV - 12 (git 0b915279)
[22:19:14 INFO]: SoundMuffler vDEV - 11 (git eb3f26f)
[22:19:14 INFO]: SlimefunOreChunks vDEV - 8 (git 41e31ffc)
[22:19:14 INFO]: HotbarPets vDEV - 27 (git 975a8997)
[22:19:14 INFO]: ExtraGear vDEV - 9 (git e851d81d)
[22:19:14 INFO]: SlimefunLuckyBlocks vDEV - 19 (git 9dbab303)
[22:19:14 INFO]: ExoticGarden vDEV - 44 (git c8cccc60)
[22:19:14 INFO]: Barrels vDEV - 11 (git abecba9c)
[22:19:14 INFO]: ElectricSpawners vDEV - 10 (git 6c891f7f)
[22:19:14 INFO]: LiteXpansion vDEV - 19 (git 95ecb68d)
[22:19:14 INFO]: ExtraHeads vDEV - 14 (git 596a0822)
[22:19:14 INFO]: SoulJars vDEV - 16 (git 36dce719)
[22:19:14 INFO]: MobCapturer vDEV - 7 (git b61d3fbf)
[22:19:14 INFO]: SlimyTreeTaps vDEV - 10 (git 66d1dd72)
[22:19:14 INFO]: PrivateStorage vDEV - 11 (git b064863b)
[22:19:14 INFO]: TranscEndence vDEV - 3 (git 84fe4a50)
[22:19:14 INFO]: ChestTerminal vDEV - 30 (git 04393688)

Server went down

Hi, server went down due to SoundMuffler. https://pastebin.com/XwZ6k1Yj

Panda's voice doesn't go down

Created, positioned, and activated sound muffler, but did not affect panda voice
What can I use for it?

[02:46:07 INFO]: Paper v1_14_R1
[02:46:07 INFO]:
[02:46:07 INFO]: CS-CoreLib - DEV 83 (git 8081b)
[02:46:07 INFO]: Slimefun vDEV - 436 (git a44c6671)
[02:46:07 INFO]:
[02:46:07 INFO]: Installed Addons (6)
[02:46:07 INFO]: Barrels vDEV - 9 (git e55ec0c6)
[02:46:07 INFO]: DyedBackpacks vDEV - 1 (git 4b4d1f0f)
[02:46:07 INFO]: SoundMuffler vDEV - 1 (git e83538c)
[02:46:07 INFO]: ExtraHeads vDEV - 9 (git 32435a1f)
[02:46:07 INFO]: SlimyTreeTaps vDEV - 6 (git a85ff41b)
[02:46:07 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[03:06:20 INFO]: ProtocolLib version 4.5.0

Does not load on startup with Tuinity

Hi.

When the server starts, the plugin fails to load with this error:

[17:51:14 ERROR]: Error occurred while enabling SoundMuffler vDEV - 8 (git b700523d) (Is it up to date?)
java.lang.NoSuchMethodError: 'void dev.j3fftw.soundmuffler.SoundMufflerMachine.registerChargeableBlock(int)'
at dev.j3fftw.soundmuffler.SoundMuffler.onEnable(SoundMuffler.java:23) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[patched_1.15.2.jar:git-Tuinity-"99854e9"]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:337) ~[patched_1.15.2.jar:git-Tuinity-"99854e9"]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483) ~[patched_1.15.2.jar:git-Tuinity-"99854e9"]
at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugin(CraftServer.java:470) ~[patched_1.15.2.jar:git-Tuinity-"99854e9"]
at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugins(CraftServer.java:384) ~[patched_1.15.2.jar:git-Tuinity-"99854e9"]
at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:482) ~[patched_1.15.2.jar:git-Tuinity-"99854e9"]
at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:299) ~[patched_1.15.2.jar:git-Tuinity-"99854e9"]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:885) ~[patched_1.15.2.jar:git-Tuinity-"99854e9"]
at java.lang.Thread.run(Thread.java:834) [?:?]
[17:51:14 INFO]: [SoundMuffler] Disabling SoundMuffler vDEV - 8 (git b700523d)

I'm using Tuinity build 99854e9 (the latest version right now) and the most recent version of Slimefun4.

SoundMuffler not muffling sounds.

Slimefun + Addon Versions: https://gyazo.com/329c46c0e40ec141625f379d687ddeef

Server Version: 1.15.2
ProtocolLib Version: 4.5.0

Description of Issue: The addon doesn't muffle sounds whatsoever, whether it be a mob, a piston, a block breaking, or even a Jukebox. A video of this can be seen below:

https://www.youtube.com/watch?v=mEYU7BojdoM