jacobhearst/cardclip

A browser extension that adds clipboard functionality for Scryfall

Welcome

Hi, welcome to my README! My name is Jacob and I love OSS. While I'm not the most prolific contributor to other's projects, I like to make my own projects open source so that others can use and (hopefully) learn from them.

Products

Projects intended for consumption by the masses

• MTG Wizard
• CardClip
• GroupMe Scryfall Bot

Libraries

Projects intended to be used by other developers in their own projects

• ScryfallKit

Graveyard

Unfinished projects that I have little to no intention of coming back to but am proud of nonetheless

• Find a Climb
  • Three repositories that comprise my own version of a search engine for The Mountain Project
  • Rock Finder (backend)
  • Find a Climb (frontend)
  • MP Crawl (web crawler)

cardclip's Issues

Local Storage Needs to be cleared

I was on 1.2.0 and updated to 1.2.1.

The extension wouldn't load because I had some cards still in local storage. I had clear my local storage to get the extension to load because it couldn't parse the old local storage.

I lost the error (something along the lines of C token couldn't parse JSON) but it happened on init() and was fixed after I cleared the old local storage.

Card clipboard icon broken in Microsoft Edge

Microsoft Edge version 102.0.1245.30 (Official build) (64-bit)
Card Clip version 1.2.3

Feature Request: Add a button to the clipboard that sends you to a scryfall search page with all the cards in the clipboard

Using the syntax like this:

Copy to clipboard not working in Microsoft Edge

I installed the extension from the Chrome webstore in Microsoft Edge.

The 'Copy to clipboard' button doesn't seem to work. It flashes green when I click it, but nothing is copied to the clipboard.

Microsoft Edge version 102.0.1245.30 (Official build) (64-bit)
Card Clip version 1.2.3

Card list is un-minimized every time you add a new card

Without looking at the code(writing from my phone), this should be a pretty simple fix. Just need to make sure when we re-make the element that it's respecting visibility state

Plus/Check icon is rotated/transformed with card elements

When viewing cards that have a non-standard rotation, the "Add card" icon is transformed along with the card element. I'm sure this is because Scryfall is applying a transform to the parent element that the plus/checkmark button is added to.

Steps to reproduce:

• Search (t:plane or t:phenomenon)
• View a transform card's page and click the "Transform" button

Add an easy way to remove cards from the list

I would like an easier way to remove the cards from the copy list, a little X to the far right or simlar. Currently (if I am not missing something) I have to navigate to the actual card to remove it.

Support tagger.scryfall.com

The tagger project is a sub-project of scryfall. It can sometimes be very useful when trying to get cards correlating to a theme. It would be convenient if CardClip could support tagger too when adding cards to the "clipboard".

https://tagger.scryfall.com

CSP Violation

I had to use a CSP disabling extension to get this one to work.

This is on a chrome-based browser but that error seems big enough to likely affect all users.

Add card preview to clipboard

A Reddit user had the suggestion to make the items in the clipboard links so they can be previewed with the use of a link preview extension. I think links are a good idea, but I'd also like to add either an on-hover preview or a little button next to each item to show the card

Done whens:

• Clipboard items are links to the card's individual Scryfall page
• A preview of the card image is available either on hover or on button click