Giter Site home page Giter Site logo

Comments (6)

olamy avatar olamy commented on August 9, 2024 1

@hboutemy I'm not clear with your report. you are mentioning META-INF/LICENSE.md and META-INF/NOTICE.md but I cannot see any issues with those files,
But I can see issues with META-INF/MANIFEST.MF

unzip -p jakarta.servlet-api-6.1.0-M2.jar META-INF/MANIFEST.MF | grep jenkins
 3_1.xsd,META-INF/LICENSE.md=/home/jenkins/agent/workspace/1_servlet-api
 -build-and-stage/LICENSE.md,META-INF/NOTICE.md=/home/jenkins/agent/work

Is it your concern? I guess yes :)

from servlet.

hboutemy avatar hboutemy commented on August 9, 2024

@olamy yes, I was not clear, updated the description to clarify
any idea what creates this?

from servlet.

olamy avatar olamy commented on August 9, 2024

@hboutemy the guilty is osgi instruction Include-Resource.
And I'm not quite sure how to fix it actually.
The easiest fix is to change the bundle plugin instruction to <_removeheaders>Bnd-LastModified,Include-Resource</_removeheaders>
@markt-asf do we need the Include-Resource osgi instruction to be there?
Because ATM it's really wrong and the whole content including

Include-Resource: jakarta/servlet/LocalStrings.properties=src/main/java/
 jakarta/servlet/LocalStrings.properties,jakarta/servlet/LocalStrings_fr
 .properties=src/main/java/jakarta/servlet/LocalStrings_fr.properties

the file is definitely not within the jar in the src/main/java/jakarta/servlet/LocalStrings_fr.properties

A fix could be these instruction:

                        <Include-Resource>
                            {maven-resources},
                            META-INF/LICENSE.md=META-INF/LICENSE.md,
                            META-INF/NOTICE.md=META-INF/NOTICE.md
                        </Include-Resource>

from servlet.

olamy avatar olamy commented on August 9, 2024

see #579

from servlet.

olamy avatar olamy commented on August 9, 2024

PR merged

from servlet.

markt-asf avatar markt-asf commented on August 9, 2024

Sorry it is late but I can confirm that the updated PR fixes the issue. Thanks for taking care of this.

from servlet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.