Giter Site home page Giter Site logo

Comments (2)

markt-asf avatar markt-asf commented on August 9, 2024

I do not believe that it is intended that this test uses ServletErrorPage.

ServletErrorPage returns a plain text response but this test is expecting a content type of text\html.

The test expects the error page to echo the message passed to sendError(int sc, String msg) but ServletErrorPage only echos this message if it contains the text error page invoked which it does not in this case.

The test is only relying on documented behaviour of HttpServletResponse.sendError(int, String) (use the provided status code, send on HTML response, send the message in the response) and does not require a custom error page for this.

The use of status code 411 appears to be solely for the sendError_StringErrorPageTest.

I am curious why you think this test should invoke ServletErrorPage.

I'll leave this open for a few days in case I have missed something but unless we reach consensus that this test should call ServletErrroPage I intend to close this issue with no further action.

from servlet.

janbartel avatar janbartel commented on August 9, 2024

@markt-asf oops my bad. I was confused by the similarity of the error code used in the test and the error code mapped for the error page - looked like a typo. Closing.

from servlet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.