Giter Site home page Giter Site logo

Comments (4)

DanielSwain avatar DanielSwain commented on July 30, 2024 1

Not sure why, but my pull request for the above failed the CI. However, I MIGHT have found the error - in lines 51 through 54 of base.html, if you change it to this, then the error goes away:

var jasmineEnv = jasmine.getEnv();
jasmineEnv.updateInterval = 1000;

var htmlReporter = new jasmine.HtmlReporter(jasmineEnv);

Is that the correct fix to the problem?

from django-jasmine.

DanielSwain avatar DanielSwain commented on July 30, 2024

Could be, but the Jasmine code looks like it attempts to provide for a blank dictionary if no environment options are specified:
env = options.env || {}

Seems like if the above was changed to the following, then the problem would go away:
env = "env" in options : options.env ? {}

from django-jasmine.

DanielSwain avatar DanielSwain commented on July 30, 2024

I submitted a pull request to the Jasmine project with the above proposed fix.

from django-jasmine.

jakeharding avatar jakeharding commented on July 30, 2024

Yeah, it makes sense to me and a pretty simple fix. Feel free to submit a pull request with this. I should be able to get to it tomorrow. Sorry I haven't been keeping up with you. I'm on vacation and have some family in town, but I will do my best. Thanks for all your input!

from django-jasmine.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.