jakeharding/django-jasmine

Package to integrate Jasmine with Django

django-jasmine's Issues

Add csrf_token to base.html

Easy enough for us to do, but also easy for you to do to in order to establish this as a default situation. I know that Django's testing framework disables the csrf checking, so would this be legitimate in a testing environment?

Support a jasmine.yml file.

Investigate if the jasmine.yml will be able to replace the files.json and support test files in separate directories.

Jasmine htmlreporter throw error on rendered index.html.

This maybe caused by not loading a default boot.js. Check jasmine docs.

Integration of jasmine-jquery into django-jasmine

The following statement in the ReadMe is not clear as far as local testing:
django-jasmine also integrates the jasmine-jquery plugin, that provides a set of custom matchers for jQuery framework and an API for handling HTML fixtures in your specs.

Most of the ReadMe seems to be talking about local display of test results (i.e. when the results are rendered to index.html), so I think that the instructions should address things from this angle.

ALSO, I tried using jasmine-jquery commands in my tests, and they failed, of course, because jasmine-jquery wasn't on my local system. I placed it in my "static/js" folder and placed the following script tag as the last of the {# core files #} in base.html: <script type="text/javascript" src="{% static 'jasmine-jquery.js' %}"></script>. This caused an error because I have to reference jQuery in files.json. When I moved the script tag for jasmine-jquery to AFTER the {# source files #}, everything was then found OK.

I would suggest the following (where DJ_ stands for django-jasmine):

1. In settings.py: DJ_JQUERY_URL and then use this variable in base.html to automatically include jQuery (ideally this would be parsed so that it could be either a url within the folder structure or a CDN url if not using jQuery locally). If jasmine-jquery is being included automatically, then it seems like jQuery should be also.
2. Explain that jasmine-jquery has to be downloaded separately if testing is being done locally.
3. in settings.py: DJ_JASMINE_JQUERY_URL -- this is the location on the local system to which jasmine-jquery has been copied.

Test files not being found

I have urls set up:
url(r'^jtests/', include('django_jasmine.urls')),

and the following in settings.py:
STATIC_URL = '/static/'
BASE_DIR = os.path.dirname(os.path.dirname(__file__))
JASMINE_TEST_DIRECTORY = os.path.join(BASE_DIR, '../tests_jasmine')
(For now the tests are in a directory that is one level above the BASE_DIR.)

The following shows the incorrect script tag that appears in index.html:

Since your instructions say that the tests are to be inside a folder named 'spec', which is to be inside the JASMINE_TEST_DIRECTORY, I don't understand why /spec is not part of the above url for the script tag (not to mention the fact that the urls prefix [in my case jtests] is also included in the url). Also, if the tests can be located in any folder that is designated by JASMINE_TEST_DIRECTORY, then why do the instructions say that the STATIC_URL must be defined in settings? I can see that it could be a problem having the tests located one level above the BASE_DIR, but it seems like the urls qualifier shouldn't be in the script tag.
Thank you.