Overload with cancellation ignored when using params

[mrphil2105]

Overload with cancellation ignored when using params

[JakenVeina]

So, this isn't a bug, it's definitely working as intended. But it's definitely a common case that should be supported.

The issue is that the proper fix is more than just adding CancellationToken to the arguments list. You have also have to wrap all the other arguments. The analyzer sees these calls as "incompatible" on account of the presence of the params keyword on only one of them.

I think it's worth creating a separate diagnostic code for this case, since the codefix is a little more involved, and requires a transform of the other arguments. Might even just not provide a codefix for this, since it would basically involve re-inventing argument binding, to figure out which arguments need transformed into the params array, and which don't.

[mrphil2105]

I thought as much. It's simply something the analyzer doesn't cover at the moment, as it's a separate thing. So I guess my issue is a feature request then 😄 Is it possible to have a codefix that if it sees another overload like in my example, it will construct the array directly and pass the CancellationToken?

[JakenVeina]

Hey, anything's possible.