jakenveina/cancellationtokenanalyzers

A Roslyn Analyzer to support proper usage of CancellationToken values.

cancellationtokenanalyzers's Issues

Overload with cancellation ignored when using params

Version

1.0.1

Description

When you have a CancellationToken in scope and two methods, one that takes a params array and another that takes a regular array and a CancellationToken, for example the two following methods defined in DbSet<TEntity> in Entity Framework Core:

public virtual ValueTask<TEntity> FindAsync(object[] keyValues, CancellationToken cancellationToken);
public virtual ValueTask<TEntity> FindAsync(params object[] keyValues);

...it favors the params method as expected if you pass an object, but the analyzer doesn't give a warning that I should use the other method with manual array construction, and pass the CancellationToken

Observed and Expected Behavior

As described above, it doesn't warn when using a method that takes a params array when there's another method that takes a regular array and a CancellationToken:

// No warning here.
var server = await dbContext.Servers.FindAsync(command.Id);
// What it should tell me to do.
var server = await dbContext.Servers.FindAsync(new object[] { command.Id }, cancellationToken);

The analyzer should warn me that I should construct the array directly and use the 2nd overload and pass along the CancellationToken, as shown in the example above.