jaliborc/bagnon-scrap

Marks all junk items in Bagnon panels and provides a junk ruleset.

Bagnon Scrap 💰

Makes all your Scrap glow and have coin icons in the Bagnon or Bagnonium panels.
Furthermore, registers a ruleset for junk items.

bagnon-scrap's Issues

Change required following API changes in Bagnon 8.2.18

Thank you for this great addon. I took almost all of its code in order to integrate with Bagnon for my own addon, so now is payback time.

In this commit Jaliborc/Bagnon@66ef941#diff-05bb8930f4d1c44c1b5b8d9747e8eb5fL8 the API changed from ItemSlot to Item and so it breaks addon relying on it. For GreyHandling I've done it this way: Pierre-Sassoulas/grey-handling@b082452

I hope this help.

Desaturation and junk icon are not applied anymore

Running Software:

• Addon version: Bagnon_Scrap-10-9.2.7
• Server patch: 10.1.0.49679

Have you read the changelog?
Yes.

Describe the bug
When Bagnon scrap is enabled, it removes the default junk (currency) icon and doesn't apply the desaturation on the game junk (regardless of the Scrap options)

When it is disabled, everything works properly (even tho the icon is not desaturated)

This is a regression from previous versions. Either related to the latest releases of Scrap or Bagnon because it was working before the 10.1 releases.

To Reproduce

Install & enable
Bagnon 10.1 for wow 10.1.0
Scrap 10.1 for wow 10.1.0
Bagnon Scrap 10.1-9.2.7

These are the latest versions available on Cursforge atm
Cursforge still pointing to the 9.2.7 zip even if the 10.0.2 version exists.
10.0.2 tested and doesn't work either.

Expected behaviour
The default Blizzard junk should be desaturated and should have the junk icon.

Additional context
Did a bit of debugging. junk is always false for all items, even if I mark junk manually as junk in Scrap.

local junk = Scrap:IsJunk(self.info.id, online and tonumber(self:GetBag()), online and tonumber(self:GetID()))