james-quigley/ser316labcr

ser316labcr's Issues

AccountServer - CG

• File Banner Missing
• Method Banners Missing
• Method Ordering is incorrect

jaquigle issues 7-9
jhewlett issues 16-18

AccountServerFactory - CG

• File Banner Missing
• Class Banner Missing
• Method Banners Missing

jaquigle issues 10-12

ServerSolution - FD

113 - Doesn't properly iterate over hashmap
13 - Filename has no relative or absolute path, will never be reference correctly

jaquigle issues 34-35
jhewlett issue 33

ServerSolution - CG

• File Banner Missing
• Class Banner Missing
• Method Banners Missing
• All attributes must be private
• Method/Attribute ordering is incorrect
• Explicit {} Missing - 31, 51, 74

jaquigle issues 27-32
jhewlett issues 25-29

Savings - CG

• File Banner Missing
• Class Banner Missing
• Method Banner Missing
• serialVersionUID is constant but not ALLCAPS
• Method/Attribute ordering is incorrect
• Missing explicit {} - 37
• {} are on same line - 47

jaquigle issues 20-26
jhewlett issues 19-24

Account - CG

• File Banner Missing
• Class Banner Missing
• Method Banner Missing
• serialVersionUID is constanct but not ALLCAPS
• Non-public methods need _prefix
• Method/Attribute ordering is incorrect

jaquigley issues 1-6
jhewlett issues 10-15

MainFrame.java - CG

• Source Banner missing
• Class Banners missing
• Method Banners missing
• Attributes must be declared private and put at the bottom of the class (lines 16-28)
• Private variables must be prefixed with a leading underscore (lines 16-28)

jhewlett issues 4-9
jaquigle issues 40-44

MainFrame.java - FD

• DisplayAccountsButton and DisplayAllAcountsButton will never have different functionality

jhewlett issue 9
jaquigle issue 70

Test

Main.java - CG

• Source Banners Missing
• Class Banners Missing
• Method Banners Missing

jhewlett issues 1-3
jaquigle issues 37-39

Savings - FD

Deposit always returns false

jaquigle issue 33
jhewlett issue 31

Checking - CG

• File Banner Missing
• Class Banner Missing
• Method Banners Missing
• serialVersionUID is constant but not ALLCAPS
• Method/Attribute ordering is incorrect
• Missing Explicit {} - lines 46 & 48
• {} on the same line - 56

jaquigle issues 13-19