GetID3 and Php 7

[jamesheinrich]

GetID3 and Php 7

[JamesHeinrich]

The latest version is 1.9.13

The extension.cache.mysql.php extension is included for older systems needing mysql
The equivalent extension.cache.mysqli.php version is for newer systems needing mysqli

[Daniel-KM]

Hi,

I checked for list() and there is no issue with it. I don't check for other changes yet.

Sincerely,

Daniel Berthereau
Infodoc & Knowledge management

[JamesHeinrich]

I don't believe any of the usage of list() in getID3 is affected by the changes in PHP 7, but if you find any specific problems please reopen this issue.

[EventideGlow]

I get this exception (and similar ones for the other write.* classes) in a project using getID3 when running it on PHP 7:

Methods with the same name as their class will not be constructors in a future version of PHP; getid3_writetags has a deprecated constructor.

I'll try updating these constructors to __construct and will submit a pull request if things still work.

[rejhgadellaabsl]

Not sure if the cache extension is used a lot but it's still using the old mysql_** methods which were deprecated in PHP5.x and removed in 7.

I ran php7cc against the latest version (1.9.12) and this is what I got:

File: D:\Working\www\intranet-prod\www\sites\all\libraries\getid3\getid3\extension.cache.mysql.php
> Line 91: Removed function "mysql_pconnect" called
    mysql_pconnect($host, $username, $password);
> Line 97: Removed function "mysql_select_db" called
    mysql_select_db($database, $this->connection);
> Line 110: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($this->table);
> Line 111: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string(\getID3::VERSION);
> Line 115: Removed function "mysql_query" called
    mysql_query($SQLquery, $this->connection);
> Line 116: Removed function "mysql_fetch_array" called
    mysql_fetch_array($this->cursor);
> Line 130: Removed function "mysql_query" called
    mysql_query('DELETE FROM `' . mysql_real_escape_string($this->table) . '`', $this->connection);
> Line 130: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($this->table);
> Line 131: Removed function "mysql_query" called
    mysql_query('INSERT INTO `' . mysql_real_escape_string($this->table) . '` VALUES (\'' . \getID3::VERSION . '\', -1, -1, -1, \'' . \getID3::VERSION . '\')', $this->connection);
> Line 131: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($this->table);
> Line 147: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($this->table);
> Line 148: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($filename);
> Line 149: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($filesize);
> Line 150: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($filetime);
> Line 151: Removed function "mysql_query" called
    mysql_query($SQLquery, $this->connection);
> Line 152: Removed function "mysql_num_rows" called
    mysql_num_rows($this->cursor);
> Line 154: Removed function "mysql_fetch_array" called
    mysql_fetch_array($this->cursor);
> Line 164: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($this->table);
> Line 165: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($filename);
> Line 166: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($filesize);
> Line 167: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($filetime);
> Line 168: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string(time());
> Line 169: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string(base64_encode(serialize($analysis)));
> Line 170: Removed function "mysql_query" called
    mysql_query($SQLquery, $this->connection);
> Line 180: Removed function "mysql_real_escape_string" called
    mysql_real_escape_string($this->table);
> Line 187: Removed function "mysql_query" called
    mysql_query($SQLquery, $this->connection);
> Line 188: Removed function "mysql_error" called
    mysql_error($this->connection);

[rejhgadellaa]

Right, I might 've missed that last version..? Anyway, thanks for the reply. I had a feeling this would be the case but wasn't sure :)