jamesmarcogliese/sms-info-system

SMS Information System (SIS)

sms-info-system's Issues

Shorten wait times for texts

Currently sent at 5 seconds after every send. Find shortest time possible.

Stuck in main, no new texts arriving.

Text plan only supports Canada-wide.

Check country code and return explanation on failure.

Proper docstrings for all methods, classes, modules

Please add proper doc-strings to all methods, classes and modules for automatic documentation generation.

Reference: https://www.python.org/dev/peps/pep-0257/

Or see existing code within the sim900 class for examples

Timing Issues W/ init and retrieval

After adding proper logging, i discovered that the new message retrieval has been grabbing the command echoed back to it. This would make it to validation where it was dropped. The config at the beginning of sim900 wasn't going through since there was no wait after each command was sent to the module, so they've been added.

Set-Up Gas Prices Functionality

Responds to short codes

System should NOT respond to short codes. (automated or premium messages)

Automated Unit Testing Scripts

We should write some unit tests in the test folder to have checks to make sure everything work and have it done automatically.

Places crashes when place is permanently closed

Add conditions to check if closed. Closed businesses do not have much data and will crash parsing since it does not return anything.

Query 2 splitting problem

"2 195 glassco ave n"
crashes system

Retrieve movie timings for a specific movie for location specified.

Enhancement - Another query where a user can type in 6 Logan/75 Strathaven drive. Once the user send us the query, we can either web crawl or use POST and then use request to get the results returned. Due to our service being a sms service. We can return 3 close by theatres and timing for a specific movie.

Use unsolicited new message notifications instead of SIM storage

http://stackoverflow.com/questions/29257924/how-to-disable-gsm-modem-unsolicited-sms-arrival-message

Return forecasted weather data (3 days)

Gas prices crash when creditprices not available

Weather api - Type error

A type error occurs sometimes when you make a query to the weather api. I have noticed this when the query was 1 Mississauga, Ontario. when you type 1 Mississauga Ontario works fine. However, this error does not occur too often

Update ReadMe

Configurations are visible

We should either move api keys to a config file to be read by the program or have the repo private,

Logging

Logging is currently done by printing to the console directly. Perhaps a more structured logging framework can be used to save logs to a file.

Not having / crashes program

Text formatting

Seems like each API may have to undergo different text formatting styles

Places API:

The output string consists of 3 possibilities, one possibility is a string saying 'no results found'. Second possibility, each result can have 3 variables(lines) as output if the user has inputted place_type or third possibility, each result can have 5 variables (lines) if user has inputted a place_name.
So need to figure out how system will send the texts; do we send each text separately or merge 2-3 lines at a time (while still checking for 160 character count as part of validation)?

Directions API:

A step can potentially be 160+ characters long, so each line must be sent as a separate text as a precaution (while still checking for 160 character count as part of validation)

validation has a lot of duplicate code

can be refactored to use a multidimensional array to hold condition values

Add exception handling

Right now all exceptions float to the top and cause the entire program to exit. This should be avoided!

Get scores for live games

Web scrawl/post and get request to get scores for a live game. User will enter 7 Blue Jays. If the team specified has a live game going on. Our service will get that data and parse and return team1 score and team 2 score. More info will be added soon.

Messages being sent out fail if over 160 chars

Will need to check and split beforehand.