janboddez/import-bookmarks

Import HTML bookmarks files into WordPress.

import-bookmarks's Issues

Replace empty return statements with proper error messages

Uploading an invalid file will result in a 'white screen of death', or rather, cause PHP to exit. In fact, all return; lines inside the import() function should really be replaced with something like wp_redirect( admin_url( 'tools.php?page=import-bookmarks&message=warning' ) ); exit;. Upon being redirected, the user should then be shown at a least a warning that something went wrong.

Importing in Windows fails due to `wp_unslash()`

See also Strategy11/formidable-forms@0f11333

Importing as custom post type fails

Due to an undefined $post_types array in the import function.

Get rid of set_time_limit()

The set_time_limit( 0 ); inside the import() method should probably go and may actually not be needed. On a temporary shared hosting setup, the plugin is able to process a few hundred bookmarks in well under 10 seconds (the typical PHP timeout is 30 seconds).

If PHP does choke on larger sets of bookmarks, though, the 'final' solution would likely be to have JavaScript send 'chunks' of 10 or so bookmarks off to the server one by one. (This has the added benefit of being able to show a progress bar.)

Add Support to Gutenberg

@janboddez

I noticed, while testing the plugin, that it create posts that end up creating the default post content. We could add "links" in case the "block editor" is active in the WordPress instance.

Let me know if this is something that you consider for this plugin.

Assure $bookmarks isn't empty before heading into the import loop

If an HTML file containing no bookmarks at all is uploaded, this results in a couple of PHP Warnings, while the user still sees a success message. Better check ! empty( $bookmarks ) && is_array( $bookmarks ) and either wp_die() or update the notice.

Add option to detect duplicate entries

The import_bookmarks_uri custom field may be used to detect duplicate URLs for post types that support custom fields. An option to detect duplicate entries this way should be switchable, however. (There may be valid reasons to link to the same web page more than once.)

Prefix vendor namespaces/classes

Import bookmarks from other sources.

As a user, I would like to be able to integrate this bookmark with an API that is cross browser and cross platform. Firefox uses for itself Pocket by default, and that is a very interesting option for bookmarking technologies.
Because Pocket has an API, we could use it, so the user could also import from there.

Let me know your thoughts.

Parser has limited support for different newline characters

The included parser is, apparently, not platform-independent: https://wordpress.org/support/topic/you-can-make-it-work-with-last-version-of-wordpress-5-6-2/

Add ability to denylist domains

It'd be cool if one could list sites that should never be imported without having to manually trim export files.