Comments (2)
The runtime error from UBSan can probably be ignored - we rely on (/ 0 0) == qNaN
, and that should hold true on most architectures, and should for SPARC.
Janet uses the nanboxing technique internally, and relies on NaNs generated by floating point operations to be of a certain form that is different than the artificially created ones that are actually tagged pointers (quiet NaNs vs. signaling, but's it's really more about the specific bits in the signalling NaNs) . There are a bunch of fiddly macros in janet.h for dealing with this.
If I had to guess, the table has length 2, so src/core/table.c, line 135
is not properly guarding the
insertion of a NaN key in the table.
if (janet_checktype(key, JANET_NUMBER) && isnan(janet_unwrap_number(key))) return;
Some things to try:
- Compile again with
-DJANET_NO_NANBOX
. This should hopefully work. - Assert that 0.0 / 0.0 is really producing a NaN number type.
Sample diff:
diff --git a/Makefile b/Makefile
index e04662a..5b75117 100644
--- a/Makefile
+++ b/Makefile
@@ -35,6 +35,7 @@ MANPATH?=$(PREFIX)/share/man/man1/
DEBUGGER=gdb
CFLAGS=-std=c99 -Wall -Wextra -Isrc/include -fpic -O2 -fvisibility=hidden \
+ -DJANET_NO_NANBOX -fsanitize=undefined \
-DJANET_BUILD=$(JANET_BUILD)
LDFLAGS=-rdynamic
diff --git a/src/boot/system_test.c b/src/boot/system_test.c
index cf991f9..1b03a7d 100644
--- a/src/boot/system_test.c
+++ b/src/boot/system_test.c
@@ -48,5 +48,7 @@ int system_test() {
assert(janet_equals(janet_cstringv("a string."), janet_cstringv("a string.")));
assert(janet_equals(janet_csymbolv("sym"), janet_csymbolv("sym")));
+ assert(JANET_NUMBER == janet_type(janet_wrap_number(0.0 / 0.0)));
+
return 0;
}
from janet.
-DJANET_NO_NANBOX helped.
from janet.
Related Issues (20)
- The case for a context object HOT 2
- The default meson option `epoll=false` causes a busy loop and segmentation fault. HOT 10
- Proposal: Terse Chained Indices HOT 19
- Reimplement `slurp` with `os/open`. HOT 28
- A way to read standard input in the background without `file/read` in a thread. HOT 4
- `each` macro improper behavior? HOT 8
- `if-let` breaks tail call optimization. HOT 6
- false branch of `if-let` doesn't report the correct call stack information. HOT 4
- `ev/select` should not resume a dead task. HOT 4
- `try` and `defer` break tail call optimization. HOT 4
- `(= @"update" @"update")` is `false`. HOT 3
- `ev/select` still revives fibers.... HOT 2
- option to unbundle docstrings and potential consequences HOT 8
- splicing into structs/tables HOT 2
- Disasm/asm doesn't round-trip for function with unused argument HOT 1
- eventloop/networking gets stuck on musl HOT 11
- Consider making `module/paths` a dynamic variable HOT 4
- Can it run on iOS? Thank you. HOT 3
- `os/strftime` doesn't respect environment variables.
- Re-integrate jpm into janet HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from janet.