Giter Site home page Giter Site logo

Better whitelist management about ghprb HOT 5 CLOSED

janinko avatar janinko commented on July 25, 2024
Better whitelist management

from ghprb.

Comments (5)

theute avatar theute commented on July 25, 2024

You get my vote, +1 :)
Particularly interested to allow a job trigger only once for some users and not add them automatically in white list.
Org group is not very useful in my case though

from ghprb.

janinko avatar janinko commented on July 25, 2024

Allowing triggering job only once / for one pullrequest is on my todo list.

Whitelist based on organization isn't bad idea.

I don't understand what you mean with "have an explicit command for whitelisting users". There is now two ways to add user to whitelist. Manually in Jenkins job configuration (where you can also delete them) and commenting with whitelist phrase this is ok to test.

from ghprb.

maxandersen avatar maxandersen commented on July 25, 2024

"this is ok to test" for me should mean "run the build based on this PR", not "run the build based on this PR AND add the user to the whitelist".

If the guy is just a one time contributor does not mean he should be allowed to trigger automatic builds on a PR since that could be a rather massive security issue.

from ghprb.

janinko avatar janinko commented on July 25, 2024

In version 1.4 there is change in commands:
test this please starts new build
ok to test allow pullrequest for building
add to whitelist add user to whitelist

Already installed plugins still add to whitelist with commend ok to test. You can change it in Jenkins configuration.

from ghprb.

janinko avatar janinko commented on July 25, 2024

In 1.5 you can add organisation (in job configuration: List of organisations) to list and members of this organization will be considered as whitelisted.

from ghprb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.