Comments (5)
You get my vote, +1 :)
Particularly interested to allow a job trigger only once for some users and not add them automatically in white list.
Org group is not very useful in my case though
from ghprb.
Allowing triggering job only once / for one pullrequest is on my todo list.
Whitelist based on organization isn't bad idea.
I don't understand what you mean with "have an explicit command for whitelisting users". There is now two ways to add user to whitelist. Manually in Jenkins job configuration (where you can also delete them) and commenting with whitelist phrase this is ok to test
.
from ghprb.
"this is ok to test" for me should mean "run the build based on this PR", not "run the build based on this PR AND add the user to the whitelist".
If the guy is just a one time contributor does not mean he should be allowed to trigger automatic builds on a PR since that could be a rather massive security issue.
from ghprb.
In version 1.4 there is change in commands:
test this please
starts new build
ok to test
allow pullrequest for building
add to whitelist
add user to whitelist
Already installed plugins still add to whitelist with commend ok to test
. You can change it in Jenkins configuration.
from ghprb.
In 1.5 you can add organisation (in job configuration: List of organisations
) to list and members of this organization will be considered as whitelisted.
from ghprb.
Related Issues (20)
- whitelist
- update commit status error 422
- How can I get commit message out of GHPRB
- ghprb Github Pull Request Merger should update state before merge attempted
- No option to build on pull request for Organizations
- Feature: Option to report success to PR when build is not triggered. HOT 1
- GHPRB is not testing my PR
- Jenkins job is triggering for only one pull request and ignoring other PR changes
- java.lang.NullPointerException HOT 4
- Trigger when target branch changes? HOT 1
- Anyway to prevent "Seen branch... "
- auth not working when using description HOT 1
- Unable to use GHPRB in multibranch pipeline
- Disable "ok to test"
- Can't Trigger Job from Github webhook HOT 3
- How to make ghprb work with manually triggered job? HOT 3
- Git URL's are case sensitive only for triggering
- Requirement for not pulling Master branch in Jenkins work space
- Trigger plugin only on defined source branch
- What kind of "actions" does the Pull request Webhook of the Github pull request builder support?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ghprb.