janinko/ghprb

github pull requests builder plugin for Jenkins

ghprb's Issues

status fails to update after a successful build

I have the builder working and it successfully builds pull requests for the organization (though manual builds continue to fail).

It successfully updates the pull request status when it starts to build. However, on completing the build successfully it fails to update the status. So the states remains ' Determining merge status — Merged build triggered' regardless that the build completed successfully.

Here is a bit of the log

Pull request builder: pr #5 Updated Sat Oct 20 17:13:37 PDT 2012
 Setting status of 62960605e6083b01600b714d7724bc6bd83e1fc6 to PENDING with url null and mesage: Merged build triggered.
 Pull request builder: Merged build triggered.
 Setting status of 62960605e6083b01600b714d7724bc6bd83e1fc6 to PENDING with url <hidden-for-security> and mesage: Merged build started.
 Oct 20, 2012 5:17:34 PM hudson.model.Run execute
INFO: f9_wf_lib pull request builder #3 main build action completed: SUCCESS

The (perhaps) interesting bit is that the url in the triggered notification is null while the url in the success notification is a valid url

Details link in commit status incorrectly thinks Jenkins is https instead of http

We are running:
ghprb: 1.8
jenkins: 1.508
Published Jenkins URL: http://[server]
Github server api URL: https://[server]

The link entered in the comments is correct but the link in the commit status is https instead of http.

Two builds for each PR

Hi,

I have integrated this plugin into our Jenkins server and I must say it is a great plug and play component.

Only one thing is bothering me though: When I open a pull request Jenkins starts two different builds:

The earlier (#65) is the "real" build and reports real results depending if it succeeded or failed.
The later (top on this image, #66) is the problematic one: I don't have a clue why it is started.
When I check the build details it says: "Started by an SCM change"
And when I click that link this is the log shown:

This page captures the polling log that triggered this build.

Started on May 16, 2013 12:54:29 PM
Workspace is offline.
Scheduling a new build to get a workspace. (nonexisting_workspace)
Done. Took 1 ms

Changes found

This later build always fails.

Any clue as to what I am doing wrong here?

Creating an authentication key only works with github.com

We have an enterprise installation.

If we put the endpoint string in the API field, save the form, then try and generate an access token using some credentials, it attempts to authenticate against github.com.

I took a quick look at the source. And it appears to be that the createToken method calls the GitHub.connect method and doesn't take into account enterprise.

I'm in the process of creating a pull request. My current idea is to create a connect method on the GhprbGithub class that correctly delegates to the enterprise connection methods in org.kohsuke.github.GitHub. Any feedback would be appreciated.

Jenkins version

I have recently updated jenkins to 1.5 and the plugin didn't show up in the plugin manager. I tried to install it "by hand" but the plugin didn't showed up neither.

The required core is 1.476 so do I have to downgrade to this? Is there a workaround? Is there BC break that prevent this plugin from being installed on higher versions of jenkins?

Thanks in advance.

organizations don't work

having an issue getting the bot to build pull requests for my organization. the bot was in a team that had the proper access, but didn't even detect pull requests.

forking the repo to a regular user and making the bot a "collaborator" (and changing nothing but the username in the repo url in jenkins) it worked fine

is this a known problem?

Pull Requests with multiple commits trigger merge and build for only the first commit

Given a pull request that has many commits, the build is triggered when the pull request is created.

However, when the build finishes and ghprb updates github, only the first commit in the list shows a green check.

The logs show that only the first sha was used by the plugin. Why arent the remaining commits picked up?

Mark the pull request as failing the build

This isn't marking my pull request as failing the build. Shouldn't it?

server api url is ignored - plugin still tries api.github.com

Settings are correct for github project url and server api url - both point to github enterprise server. Plugin still tries to use api.github.com:

Feb 20, 2013 10:50:27 PM org.jenkinsci.plugins.ghprb.GhprbRepo checkState
SEVERE: Could not retrieve repo named MyOrg/sandbox (Do you have properly set 'GitHub project' field in job configuration?)
java.io.IOException: {"message":"Bad credentials"}
at org.kohsuke.github.Requester.handleApiError(Requester.java:341)
at org.kohsuke.github.Requester._to(Requester.java:175)
at org.kohsuke.github.Requester.to(Requester.java:139)
at org.kohsuke.github.GitHub.getRepository(GitHub.java:250)
at org.jenkinsci.plugins.ghprb.GhprbRepo.checkState(GhprbRepo.java:78)
at org.jenkinsci.plugins.ghprb.GhprbRepo.check(GhprbRepo.java:91)
at org.jenkinsci.plugins.ghprb.GhprbTrigger.run(GhprbTrigger.java:132)
at hudson.triggers.Trigger.checkTriggers(Trigger.java:261)
at hudson.triggers.Trigger$Cron.doRun(Trigger.java:209)
at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:54)
at java.util.TimerThread.mainLoop(Timer.java:512)
at java.util.TimerThread.run(Timer.java:462)
Caused by: java.io.IOException: Server returned HTTP response code: 401 for URL: https://api.github.com/repos/MyOrg/sandbox
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1436)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:234)
at org.kohsuke.github.Requester.parse(Requester.java:297)
at org.kohsuke.github.Requester._to(Requester.java:173)
... 10 more
Feb 20, 2013 10:50:27 PM org.jenkinsci.plugins.ghprb.GhprbRepo checkState
SEVERE: Could not retrieve repo named MyOrg/sandbox (Do you have properly set GitHub project field in job configuration?)

bot github user cannot be 'admin'. Why?

'Admin' comments created by bot github user have no effects .

Afais, from
https://github.com/janinko/ghprb/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java#L115
it's intentional that bot github user cannot be admin.
Why?

No access token causes stack trace

Even the access token is incorrect or missing, the plugin will try to create/update the commit status on the PR. This causes the following strack trace: http://pastebin.com/mdCySdbv

Repository is not building when I comment in pull request

When I comment in a pull request with either "retest this please" or "ok to test" a build is not triggered in jenkins but I do see it triggered in Github.

What I have seen:
After leaving a comment in github the pull request it self updates with a message that says " Determining merge status — Build started (Details)". when I click on the Details link it refers back to the original build that was done when I last pushed a changed to my pull request. But when I go into Jenkins no build has been done.

Also I am unable to merge any code while that status is showing in github. I see the message "This pull request cannot be automatically merged."

I looked at the Jenkins log and there wasn't any thing recent in there but here is what I saw:
Sep 14, 2012 7:46:49 PM hudson.model.Run execute
INFO: Push_Test_Private_Repo #67 main build action completed: SUCCESS
Sep 14, 2012 7:36:49 PM hudson.model.Run execute
INFO: Push_Test_Private_Repo #65 main build action completed: SUCCESS
Sep 14, 2012 7:16:51 PM hudson.model.Run execute
INFO: Jenkins_Public_Repo_Test1- main build action completed: SUCCESS
Sep 14, 2012 7:06:49 PM hudson.model.Run execute
INFO: Push_Test_Private_Repo #62 main build action completed: SUCCESS
Sep 14, 2012 6:41:48 PM hudson.model.Run execute
INFO: Push_Test_Private_Repo #61 main build action completed: SUCCESS
Sep 14, 2012 6:06:48 PM hudson.model.Run execute
INFO: Push_Test_Private_Repo #60 main build action completed: SUCCESS

Old builds are deleted - why? Is there a way to configure this?

Hi,

I'm maintaining jenkins for the ownCloud project (ci.tmit.eu).
ghprb is properly working - THX for this great plugin.

I have one issue: the build are deleted pretty fast which is bad as they are referenced in the pull requests.

Am I doing anything wrong?

THX a lot,

Tom

Better whitelist management

Could the whitelist be based on a organization group instead of a string list in jenkins ?

or could we at least have an explicit command for whitelisting users instead of just geting user added because his pullrequest were ok'ed ?

to avoid security issues with being able to submit anything.

NPE on configuration save

I have my github project set to http://our.github.enterprise.url/Orginization-Name/Repo-Name/
I have the Repository URL set to: [email protected]:Orginization-Name/Repo-Name.git
I have the RefSpec set to: +refs/pull/:refs/remotes/origin/pr/
I don't have the "Access Token" config set in the main jenkins configuration. Wasn't sure what that was and didn't see any documentation on it.

Here's the stack trace I'm getting back.

Dec 19, 2012 10:16:06 AM hudson.triggers.Trigger checkTriggers
WARNING: org.jenkinsci.plugins.ghprb.GhprbTrigger.run() failed for Shared (John)
java.lang.NullPointerException
at org.jenkinsci.plugins.ghprb.GhprbRepo.check(GhprbRepo.java:69)
at org.jenkinsci.plugins.ghprb.GhprbTrigger.run(GhprbTrigger.java:104)
at hudson.triggers.Trigger.checkTriggers(Trigger.java:261)
at hudson.triggers.Trigger$Cron.doRun(Trigger.java:209)
at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:54)
at java.util.TimerThread.mainLoop(Timer.java:534)
at java.util.TimerThread.run(Timer.java:484)

Thanks for your help.

Status update fails

I always end up with an error like the following when the plugin wants to trigger a job:

Created pull request #4 by gatein-bot udpdated at: Thu Jan 01 01:00:00 CET 1970 sha: f6826b04cd21ec7d5cd18b4c6057606ef8c96082
Pull request builder: pr #4 Updated Wed Sep 26 14:21:31 CEST 2012
Setting status of f6826b04cd21ec7d5cd18b4c6057606ef8c96082 to PENDING with url null and mesage: Build triggered.
Sep 26, 2012 2:40:43 PM org.jenkinsci.plugins.ghprb.GhprbTrigger run
SEVERE: null
java.io.FileNotFoundException: https://api.github.com/repos/theute/test/statuses/f6826b04cd21ec7d5cd18b4c6057606ef8c96082
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1613)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254)
at org.kohsuke.github.Requester.parse(Requester.java:293)
at org.kohsuke.github.Requester._to(Requester.java:169)
at org.kohsuke.github.Requester.to(Requester.java:135)
at org.kohsuke.github.GHRepository.createCommitStatus(GHRepository.java:486)
at org.jenkinsci.plugins.ghprb.GhprbRepo.createCommitStatus(GhprbRepo.java:128)
at org.jenkinsci.plugins.ghprb.GhprbPullRequest.build(GhprbPullRequest.java:83)
at org.jenkinsci.plugins.ghprb.GhprbPullRequest.check(GhprbPullRequest.java:64)
at org.jenkinsci.plugins.ghprb.GhprbRepo.check(GhprbRepo.java:62)
at org.jenkinsci.plugins.ghprb.GhprbTrigger.run(GhprbTrigger.java:92)
at hudson.triggers.Trigger.checkTriggers(Trigger.java:259)
at hudson.triggers.Trigger$Cron.doRun(Trigger.java:207)
at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:54)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)

The file exist though...

So status update fails and the job doesn't start.

Unable to trigger builds with private repo

This is an awesome plug in! However, it seems that this does not work with private repositories. Does this seem correct to you and if so is there a way to get around it?

Thank you for your help!

Unable to use "Test phrase" on your own pull request

It seems like the test phrase doesn't work when it's your own pull request. Even if you are an admin.

Unstable builds should not be considered failures

It would be nice if there was a setting that asks what is considered a failed build. In our environment we don't necessarily consider an unstable build a failure.

Currently GHPRB calls unstable builds a failed build on github. Maybe a setting that says "Are unstable builds considered successful?: {Yes|No}"

mvn build error

I download the zip package of the plugin. And do mvn clean package. Got the following error:

[ERROR] error: Exception thrown while constructing Processor object: com/google/common/collect/Multimap
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure
error: Exception thrown while constructing Processor object: com/google/common/collect/Multimap

[INFO] ------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.BuildFailureException: Compilation failure
error: Exception thrown while constructing Processor object: com/google/common/collect/Multimap

    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:715)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
    at org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
    at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
    at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
    at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation failure
error: Exception thrown while constructing Processor object: com/google/common/collect/Multimap

    at org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:656)
    at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128)
    at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
    ... 17 more

The new pull request hook integration does not work

I tried to configure a repository in an organization using the pull request hook integration. I see this error in the logs:

Apr 29, 2013 5:47:13 PM org.jenkinsci.plugins.ghprb.GhprbRepository createHook
SEVERE: Couldn't create web hook for repositorymy-org/my-repo
java.io.FileNotFoundException: https://api.github.com/repos/my-org/my-repo/hooks
        at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1434)
        at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:234)
        at org.kohsuke.github.Requester.parse(Requester.java:297)
        at org.kohsuke.github.Requester._to(Requester.java:173)
        at org.kohsuke.github.Requester.to(Requester.java:139)
        at org.kohsuke.github.GHRepository.getHooks(GHRepository.java:385)
        at org.jenkinsci.plugins.ghprb.GhprbRepository.hookExist(GhprbRepository.java:148)
        at org.jenkinsci.plugins.ghprb.GhprbRepository.createHook(GhprbRepository.java:160)
        at org.jenkinsci.plugins.ghprb.Ghprb$Builder.build(Ghprb.java:177)
        at org.jenkinsci.plugins.ghprb.GhprbTrigger.start(GhprbTrigger.java:61)
        at org.jenkinsci.plugins.ghprb.GhprbTrigger.start(GhprbTrigger.java:37)
        at hudson.model.AbstractProject.submit(AbstractProject.java:1952)
        at hudson.maven.MavenModuleSet.submit(MavenModuleSet.java:1115)
        at hudson.model.Job.doConfigSubmit(Job.java:1076)
        at hudson.model.AbstractProject.doConfigSubmit(AbstractProject.java:755)
        ...

Access does require authentication.

Invalid refspec

I'm getting an invalid refspec error when Jenkins tries to clone the repository.

$ git clone --progress -o +refs/pull/*:refs/remotes/origin/pr/* [email protected]:MY_REPO_HERE
Cloning into 'MY_REPO_DIRECTORY_HERE'...
fatal: Invalid refspec '+refs/heads/*:refs/remotes/+refs/pull/*:refs/remotes/origin/pr/*/*'

Make "triggered", "started" and "finished" comments optional

Sometimes it's nice to know exactly what's happening, but turning these comments off would be nice in order not to flood the comments of pull requests - just commenting on the resulting build status would be enough for many projects.

SSL Certificate error when build is triggered

This does not happen for manual builds.

When a build is triggered the following stack trace is logged: http://pastebin.com/cix0yAag

This does not happen on my local Mac OS X laptop, but does happen on my CentOS 5 server that is running Jenkins. I have already updated my ca-cert bundle on the CentOS server and confirmed that I can successfully check out the repository on the command line.

new commits on existing pull requests

it seems the plugins doesn't detect new commits onto existing pull requests (which i would imagine should trigger a new build)

Setting build status on commit does not work when using cron polling

I've set up a project which uses cron polling of pull requests. If I check to do a post-build "Set status on Github commit" the build fails, due to the github-plugin expecting the build trigger to be a GitHubPushTrigger - when it is actually a GhprbTrigger. See here

I would guess this will need to get fixed in the github plugin, rather than this plugin. But wanted to discuss it here first.

Use of the commit status api

https://github.com/blog/1227-commit-status-api

Ability to allow all pull requests to run a build

Right now if the person submitting the pull request is not whitelisted, it asks (Can any of the admins verify this patch?).

It would be nice to have a setting that allows all pull requests to run a build without the user being whitelisted.

NullPointerException

Hello,

I'm receiving this error in the Logs. I've followed the directions in the Readme.

My Jenkins instance is not accessible from the web but the polling appears to kick off the pull request builder trigger.

Using Jenkins v1.486, github-api v1.33, Git v1.1.25, github pull requests builder v1.3.1.

What am I doing wrong 😿 ?

Any help would be greatly appreciated.

Thanks!

Oct 20, 2012 2:03:57 AM hudson.triggers.Trigger checkTriggers
WARNING: org.jenkinsci.plugins.ghprb.GhprbTrigger.run() failed for pr
java.lang.NullPointerException
  at org.jenkinsci.plugins.ghprb.GhprbRepo.check(GhprbRepo.java:56)
  at org.jenkinsci.plugins.ghprb.GhprbTrigger.run(GhprbTrigger.java:101)
  at hudson.triggers.Trigger.checkTriggers(Trigger.java:261)
  at hudson.triggers.Trigger$Cron.doRun(Trigger.java:209)
  at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:54)
  at java.util.TimerThread.mainLoop(Timer.java:534)
  at java.util.TimerThread.run(Timer.java:484)

Add more information about the pull request to the environment variables

I especially would like to see the pull request number and maybe an URL to the actual pull request.

PR builder stops working after a while

Hi

I'm one of the coordinators of the MonoGame project and we recently started using the git hub pull request builder as part of our build system. Its currently hosted on a Windows 8 box and is running within Apache Tomcat 6 with Jenkins.

We have an odd situation where after start-up the integration seems to work fine for a few hours and then just stops, new PR's do not get the "verify" comment and the commands to test are not processed.

To work round this we have put in a 6 hourly restart of tomcat, but I'd rather know what the problem is so I can fix it.

Any ideas? Are they logs produced by the plugin that I can take a look at to see what the problem might be.

Pull Request Builder Verbosity Should be Configurable

Love the pull request builder - it's made build fails AFTER merging a thing of the past.

That said, Jenkins just won't shut up.

It would be great to have a configuration option to disable these messages:

Build results will soon be (or already are) available at: https://........./

The build status API on GitHub already surfaces both that link and the fact that a build is underway.

link to pull request

It would be nice it the widget (name ? then one that writes "Github pull request #nnn of commit xxxxxxxxx automatically merged."

could include a link back to the pull request on github

NPE saving configuration

Caused by: java.lang.NullPointerException
at org.jenkinsci.plugins.ghprb.GhprbProjectAction.(GhprbProjectAction.java:22)
at org.jenkinsci.plugins.ghprb.GhprbTransientProjectActionFactory.createFor(GhprbTransientProjectActionFactory.java:25)
at hudson.model.AbstractProject.createTransientActions(AbstractProject.java:727)
at hudson.model.Project.createTransientActions(Project.java:206)
at hudson.model.AbstractProject.updateTransientActions(AbstractProject.java:717)
at hudson.model.AbstractProject.save(AbstractProject.java:274)
at hudson.model.AbstractItem.setDisplayName(AbstractItem.java:156)
at hudson.model.Job.doConfigSubmit(Job.java:1061)
at hudson.model.AbstractProject.doConfigSubmit(AbstractProject.java:758)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:288)
at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:151)
at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:90)
at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:111)
at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:677)

This happens as soon as i enable "Github pull requests builder" for a project. If i uncheck "Github pull requests builder" the NPE continues. If i try to delete the project i get the same NPE.

Support [ci-skip] flag

Something like Travis CI supports. You can add [ci skip] to commit message and build will not be triggered for this commit.

P.S. Thanks for awesome plugin!

Use pull request hook instead of cron

Instead of using a cron job to find and update pull requests it would be better to listen for the pull_request hook as documented on http://developer.github.com/v3/repos/hooks/

Segregate configuration

Hi ,
I am trying to automate a jenkins server installation (including ghprb plugin) with Chef. I would like to control some part of the config ( admin list , white list id) via chef (by querying github or other external system). Given ghprb store some temporal (build data) info on its config.xml file i cant generate them from chef.
So, is it possible to segregate these tow conifgs , or provide a conf.d style configuration management, where i can tell ghprb that read any xml from a directory.

I am sorry its not pertaining to ghprb , may be i need to check the jenkins api for that?

thank you

Build complications

Hey, let me start off by thanking you for the plugin! The team I'm on has been talking about putting behavior like this in our jenkins setup for awhile now.

I'd love to try it out but I haven't been able to get the build working, it looks like it depends on an unreleased version of github-api which depends on an unreleased version of stapler... In short it greatly exceeds my familiarity with developing and building with maven.

Any chance you could throw the hpi up on your site or something like that and link to it in the README/repo url so that myself and others who don't develop jenkins plugins can give it a test drive? Thanks again!

Unable to use

Cron stops working

The Cron appears to stop working, without any errors in our logs.

It happens any time out jenkins server loosing its connection to the internet.
This seams 100% reproducible.

Even once connectivity is restored the cron remains 'dead'.
We have to restart jenkins to restart the cron which is highly annoying.

Should be easily fixable by someone with a development environment setup, by simply disconnecting your computer from the internet.

Not building when destination (master) branch is updated (e.g. master)

When master is updated the PR build still says 'Good to merge' (even when GitHub cannot automatically merge and even when there's a conflict if you manually merge).

I think the build status should be both the latest destination (master) and source (feature) branches merged. Not just the latest source (feature) branch and the SHA of master when the PR was created.

Since updating, the GitHub comment includes a `null`

Since updating to the latest ghprb plugin and other github plugins, the post-build comment on GitHub has changed. It now seems to send the following, with the null in every comment:

null
Refer to this link for build results: https://my-server/jenkins/job/my-project-build-pull/80/

Not Triggered, Manual Build Fails Too (No Candidate Revisions)

Hey there!

Just installed and configured as the readme says and I'm running into an issue: it won't pull.

From Jenkins:
Fetching upstream changes from [email protected]:Tout/pullrequest-jenkins-test.git
No candidate revisions
ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job.
Finished: FAILURE

Inside of the repository, the model is git flow, so the pull request is being held on the feature/edit_test branch. The pull request is open but if I try to manually build from within Jenkins the build fails. Also, it is not hooking whenever a new pull request is opened, but I feel that might be another ticket.

Thoughts?

Webhook doesn't work with authentication requred Jenkins

Jenkins return 403 error.
Github Plugin's webhook works fine same enviroment.

NPE on save configuration for build job

I believe this is caused by a missing value in the retest field when configuring the job. Should this field have a default value, or maybe this should be added to the tutorial in the README?

https://github.com/janinko/ghprb/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/GhprbRepo.java#L49

Stacktrace:
Caused by: java.lang.NullPointerException
at java.util.regex.Pattern.(Pattern.java:1149)
at java.util.regex.Pattern.compile(Pattern.java:840)
at org.jenkinsci.plugins.ghprb.GhprbRepo.(GhprbRepo.java:49)
at org.jenkinsci.plugins.ghprb.GhprbTrigger.start(GhprbTrigger.java:73)
at org.jenkinsci.plugins.ghprb.GhprbTrigger.start(GhprbTrigger.java:33)
at hudson.model.AbstractProject.submit(AbstractProject.java:1848)
at hudson.model.Project.submit(Project.java:197)

EDIT: This might have gone a little fast - the retest has a default value and is stored in the system conf page, but it fails when I try and save a build job

Not detecting pull request

Brand new Jenkins install, private repository, all current versions of plugins (as of 9/18/12). My install is not detecting the Github configuration.

Jenkins Configuration:
GitHub Web Hook: Manually
GitHub Pull Requests Builder: // some owner-level username:password
Admin List: jamescmartinez

Project Configuration:
GitHub project: https://github.com/jamescmartinez/jenkins-pr-plugin-test.git/
SCM Git
Repository URL: [email protected]:jamescmartinez/jenkins-pr-plugin-test.git
Refspec: +refs/pull/*:refs/remotes/origin/pr/*
Branch Specifier: ${sha1}
Github pull requests builder checked
Admin list: jamescmartinez

Two builds for each PR

Hi,

I have integrated this plugin into our Jenkins server and I must say it is a great plug and play component.

Only one thing is bothering me though: When I open a pull request Jenkins starts two different builds:

The earlier is the "real" build and reports real results depending if it succeeded or failed.
The later (top on this image) is the problematic one: I don't have a clue why it is started.
When I check the build details it says: "Started by an SCM change"
And when I click that link this is the log shown:

Started by an SCM change
Building in workspace /var/lib/jenkins/jobs/*******/workspace@2
Checkout:workspace@2 / /var/lib/jenkins/jobs/*******/workspace@2 - hudson.remoting.LocalChannel@5abe753a
Using strategy: Default
Last Built Revision: Revision 7056615177d822a68e984f612c12b417cfd5bee0 (origin/pr/2439/merge)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
No candidate revisions
ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job.
Finished: FAILURE

This later build always fails.

Any clue as to what I am doing wrong here?

Unable to manually build projects if pull request plugin is filled out.

If I attempt to build a project manually and have the pull request plugin enabled I get the following error:

Last Built Revision: Revision 6daa227a0bb360c2e330d20d1bd10c3babed2fa8 (detached)
Fetching changes from 1 remote Git repository
Fetching upstream changes from [email protected]:JenRed12/utui.git
No candidate revisions
ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job.
Finished: FAILURE

This was working correctly with public repos last week but seems to no longer work since I updated to new version this morning. It does not work for public or private repos.

Pull request comment doesn't contain status nor URL to the build

When ghprb fails to update the status of a pull request (e.g. due to lack of rights), it falls back to adding a message to the commit. In the latest version, it only logs a message (e.g. 'Merged build finished'. It would be very useful if the message also included information regardless the result (success / failure / error ) and/or a link to the build.

This is on version 1.8 of the plugin.

Manually triggered build & build against HEAD fails

build against PR's works fine, but the builds triggered against merge fails. Also any manually triggered build fail.

I have tried using the upstream github-api thinking this may be a side effect of #5

but still no success.

Configuration used:
private github repo
refspec ; +refs/pull/:refs/remotes/origin/pr/
branches to build :${sha1}

Following is the error messages:

Started by an SCM change
Building in workspace /var/lib/jenkins/jobs/XX/workspace
Checkout:workspace / /var/lib/jenkins/jobs/XXf/workspace - hudson.remoting.LocalChannel@XXXX
Using strategy: Default
Last Built Revision: Revision XXX (origin/pr/101/merge)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
No candidate revisions
ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job.
Finished: FAILURE