janjiss/conred

Embed your videos with ease

conred's Issues

Gem relies on HAML

Should add HAML as a dependency. You get an error if you do not have it installed.

The exist? method does not work for youtube videos

Hi!

The exist? method does not work properly for youtube videos. It always returns false, no matter if the link is valid. This is because gdata.youtube.com/feeds/api/videos/ is no longer available. I think you need to use YouTube Data API V3 for checking YT videos.

Adding custom classes and id to video iframe

Right now we have no possibility of adding class and id for video. This functionality should be added. I am thinking of a way of adding data atributes to. If somone has solutions for data attribute adding, you are welcome to help.

Add support for facebook videos

Add support for facebook videos

The name of the method to check whether video exists is 'c.exist?' rather than 'c.exists?'

The README or the code needs to be updated accordingly.

Change strings to haml partials

Right now iframe strings are hardcoded
<<-eos
<iframe id='vimeo_video' src='http://player.vimeo.com/video/#{vimeo_id}' width='#{@width}' height='#{@height}' frameborder='0' webkitAllowFullScreen mozallowfullscreen allowFullScreen>
</iframe>
eos

We should change this to haml, so it is better tested and it will look much cleaner

Need to fix youtube links, that are coming from related video watching

Let's say we have link like this:
http://www.youtube.com/watch?NR=1&feature=endscreen&v=CJ_ovGKN7_4
It does not render video, because regex is not recognizing video url.

Refactor tests

Fix tests with lazy load. Right now for every video I use instance, thats not cool

Changing the interface of Video class

Maybe we should consider passing hash with args for creating instance of Conred::Video, instead of simple arguments? It would be more clear (at least for me) if it looked like:

 Conred::Video(
    :url => video_url, :error_message => "Video url is not valid",
    :width => 350, :height => 350
 )

Would that be more prefferable, than current interface, where we just pass anonymous args?

Need to determine, if video is present or not

Right now, if youtube url format is ok, but it is a fake one, it shows iframe without video content. Can we determine somehow, is video present in youtube or vimeo?