`SectionMixin`: `super().__init__` should be called at the beginning of `__init__`

[janluke]

`SectionMixin`: `super().__init__` should be called at the beginning of `__init__`

[alexreg]

@janluke Just curious, is there anything in particular you are worried about with moving super().__init__ to the beginning? Or just being cautious?

[alexreg]

A more conservative fix would be to leave it where it is and add at the beginning of __init__ the following.

self.chain = kwargs.get("chain", None)
del kwargs["chain"]

It seems like a bit of a kludge though. Overall, I noticed that re Cloup types, sometimes you are calling super().__init__ at the start, sometimes at the end, and at least once somewhere in the middle.

[janluke]

@janluke Just curious, is there anything in particular you are worried about with moving super().init to the beginning? Or just being cautious?

Just being cautious. I don't remember why I put the super() call at the end. Moving the call at the beginning is probably something safe to do. Still, "formally" it deserves to be its own PR because if someone who used SectionMixin directly may have relied on this. Pragmatically, very few people (if any) use these mixins directly, so it's just a formality.

[alexreg]

@janluke Makes sense. Want me to create a PR?

[janluke]

It'd be great! Thanks :)