janstol/signal_strength_indicator

Customizable signal strength indicator widget for Flutter

signal_strength_indicator's Issues

Thresholds outside of minValue/maxValue are removed.

According to the documentation, you can specify levels like this:

SignalStrengthIndicator.bars(
  value: val,
  minValue: 0,
  maxValue: 100,
  levels: <num, Color>{
    0.25: Colors.red,
    0.50: Colors.yellow,
    0.75: Colors.green,
  },
)

However, if the minValue and maxValue do not contain the levels as specified in levels, they will be removed. This doesn't make sense, since the min/max could be an entirely different range than the levels. For example, this will not use any of the specified levels because they will be removed:

SignalStrengthIndicator.bars(
  value: client["signal"],
  spacing: 0.3,
  minValue: -88,
  maxValue: -30,
  levels: <num, Color>{
    0.12: Colors.red,   // These levels will all be removed, because they fall outside of the min/max range!
    0.21: Colors.yellow,
    0.39: Colors.green, 
    0.65: Colors.green, 
    0.87: Colors.green,
  }, 
),

I believe the one line fix is to just remove:

signal_strength_indicator/lib/src/style/bar_signal_strength_indicator_style.dart

Line 60 in 446b6a6

.removeWhere((key, _) => key < style.minValue || key > style.maxValue);

Widget not rendered on value change

Repaint will not be handled on value change. In the example case repainting is handled as you are using a Stateful widget.
Using stateless widgets together with BLoC or RxDart will prevent the widget from repainting.