janwilmans/dezynesamples

Simple examples of Dezyne models and their generated code

dezynesamples's Issues

Code generation problems

All tests were done on the version of Dezyne downloaded from the Dezyne website at Nov 2. 2017.

Generated using dzn service version 2.5.3.

without TSS (thread-safe-shell)

dzn code -l c++ -s AlarmSystem Alarm.dzn

generated two files:
Alarm.hh and Alarm.cc

In Alarm.hh:

////////////////////////////////////////////////////////////////////////////////
// #ifndef ALARMSYSTEM_HH
// #define ALARMSYSTEM_HH

//interface includes
#include "Alarm.hh"
#include "Alarm.hh"
#include "Alarm.hh"

While this does not actually cause any problems, it is a little weird to include the same files multiple times.

with TSS (thread-safe-shell)

dzn code -l c++ -s AlarmSystem Alarm.dzn

generated two files:
Alarm.hh and Alarm.cc

However, Alarm.cc tried to:

#include "AlarmSystem.hh"

So this does not compile.

with TSS (thread-safe-shell), but providing the wrong component as System

dzn code -l c++ -s Alarm Alarm.dzn

generated two files:
Alarm.hh and Alarm.cc

However, the thread-safe-shell is not actually generated at all!

Add unique transaction ID's through-out models

Could be done using shared-object in the locator

Wishlist for better workflow integration

• Namespaces!
• #Include’s and copyright comments in generated code
• No warnings in generated code at MSVC level 4
• Build system support
  • Verify all + generate all code (incremental in UI and full at command line)
  • Model <> code integrity check
  • Option to use windows (\r\n) newlines
  • Better formatting generated code (post process using clang_format if it is present, so user can customize)
  • Download runtime from command line (without doing it file-by-file)
• Visual studio UI integration support
• Generated Armors
• Custom code generation from interface models (COM, http,…)
• download multiple files / wildcards for dzn get

Warning at warning level 4 in visual studio 2017

------ Build started: Project: Alarm, Configuration: Debug x64 ------
1>main.cpp
1>c:\users\jan\dezyneworkspace\dezynesamples\alarm\vs2017project\main.cpp(44): warning C4100: 'argv': unreferenced formal parameter
1>c:\users\jan\dezyneworkspace\dezynesamples\alarm\vs2017project\main.cpp(44): warning C4100: 'argc': unreferenced formal parameter
1>runtime.cc
1>c:\users\jan\dezyneworkspace\dezynesamples\alarm\dzn\context.hh(19): warning C4458: declaration of 'state' hides class member
1>c:\users\jan\dezyneworkspace\dezynesamples\alarm\dzn\context.hh(30): note: see declaration of 'dzn::context::state'
1>c:\users\jan\dezyneworkspace\dezynesamples\alarm\dzn\context.hh(101): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data
1>pump.cc
1>c:\users\jan\dezyneworkspace\dezynesamples\alarm\dzn\context.hh(19): warning C4458: declaration of 'state' hides class member
1>c:\users\jan\dezyneworkspace\dezynesamples\alarm\dzn\context.hh(30): note: see declaration of 'dzn::context::state'
1>c:\users\jan\dezyneworkspace\dezynesamples\alarm\dzn\context.hh(101): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data
1>Alarm.cc
1>Generating Code...
1>Alarm.vcxproj -> C:\Users\jan\DezyneWorkspace\DezyneSamples\Alarm\vs2017project\x64\Debug\Alarm.exe
1>Done building project "Alarm.vcxproj".
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

Asymetrical log messages

<external>.arm -> .alarm.console.arm [0, 0]
sensor enabled
.alarm.console.return -> <external>.return [1, 0]
<external>.triggered -> .alarm.sensor.triggered [1, 0]
Detected!
siren on!

• signals on out-ports coming into a system only have an 'trace_out' entry
• signals on out-ports going out of a system do not log anything

I've added [trace_in] and [trace_out] to the messages here:

<external>.arm -> [trace_in] .alarm.console.arm [0, 0]
sensor enabled
.alarm.console.return -> [trace_out] <external>.return [1, 0]
<external>.triggered -> [trace_out] .alarm.sensor.triggered [1, 0]
Detected!
siren on!