StackOverflow error if cyclical graph

[jasminb]

StackOverflow error if cyclical graph

[jasminb]

Hey @Kylar42, tx for reporting. Approach you are suggesting is already used in deserialisation, will do the same for the serialisation.

[iamareebjamal]

Sorry, it was related to Jackson not picking up JsonIgnore property. But, still I guess it's an error if I had to include the fields :

Event contains a field

@Relationship("tickets") public List<Ticket> tickets;

And Ticket contains Event

com.github.jasminb.jsonapi.exceptions.DocumentSerializationException: java.lang.IllegalArgumentException: Infinite recursion (StackOverflowError) (through reference chain: org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayList[0]->org.fossasia.openevent.app.common.data.models.Ticket["event"]->org.fossasia.openevent.app.common.data.models.Event["tickets"]->java.util.ArrayL...

[jasminb]

Hey again @Kylar42, after looking at this again, I found that there are two problems here which need solving.

First one is related to Jackson and second one to the library itself.

To go around jackson related issue, one needs to properly annotate model classes so jackson can correctly serialise objects with cycles:

@JsonIdentityInfo(generator = ObjectIdGenerators.StringIdGenerator.class, property = "id")

Second issue was with the library itself, I've fixed it and pushed to develop.

[Kylar42]

Awesome. When do you plan on doing a 0.5 release?

[jasminb]

Hey, still no exact time for the 0.5. You can use the snapshot release in the meantime.

[Kylar42]

OK, just tested it - works great, thanks!

[iamareebjamal]

This is still an issue @jasminb

[jasminb]

Hey @iamareebjamal, Please provide a test case that reproduces the issue.