2.2.1 seems to have introduced an issue that breaks output of istanbul

2.2.1 seems to have introduced an issue that breaks output of istanbul

Daniels-MacBook-Pro:haakon-core dmartinez$ npm install [email protected]
[email protected] node_modules/jasmine
├── [email protected]
└── [email protected] ([email protected], [email protected])
Daniels-MacBook-Pro:haakon-core dmartinez$ ./node_modules/.bin/istanbul cover -x 'spec/support/**' ./spec/support/runner.js
Failed to load c++ bson extension, using pure JS version
Started
..................................


34 specs, 0 failures
Finished in 0.052 seconds
=============================================================================
Writing coverage object [/Users/dmartinez/source/haakon-core/coverage/coverage.json]
Writing coverage reports at [/Users/dmartinez/source/haakon-core/coverage]
=============================================================================

=============================== Coverage summary ===============================
Statements   : 100% ( 469/469 )
Branches     : 100% ( 0/0 )
Functions    : 100% ( 155/155 )
Lines        : 100% ( 469/469 )
================================================================================
Daniels-MacBook-Pro:haakon-core dmartinez$ npm uninstall jasmine
unbuild [email protected]
Daniels-MacBook-Pro:haakon-core dmartinez$ npm install [email protected]
[email protected] node_modules/jasmine
├── [email protected]
├── [email protected]
└── [email protected] ([email protected], [email protected])
Daniels-MacBook-Pro:haakon-core dmartinez$ ./node_modules/.bin/istanbul cover -x 'spec/support/**' ./spec/support/runner.js
Failed to load c++ bson extension, using pure JS version
Started
..................................


34 specs, 0 failures
Finished in 0.048 seconds
Daniels-MacBook-Pro:haakon-core dmartinez$ 

[slackersoft]

Interesting, the only change between 2.2.0 and 2.2.1 is the introduction of the exit module to allow jasmine to properly wait for stdout to flush on windows when run stdout is being piped.

That said, I think this has kind of problem has been fixed on master. We're now doing a better job of making sure that the reporter that causes the process to exit is the last reporter to run at the end of the suite. If you have a chance to check it out, I'd like to know if this fixes your issue as well.

Thanks for using jasmine!

@slackersoft I gave master a shot and it seems to still be an issue :/

Daniels-MacBook-Pro:haakon-core dmartinez$ npm install [email protected]
[email protected] node_modules/jasmine
├── [email protected]
└── [email protected] ([email protected], [email protected])
Daniels-MacBook-Pro:haakon-core dmartinez$ npm run test

> [email protected] test /Users/dmartinez/source/haakon-core
> istanbul cover ./spec/support/runner.js

Failed to load c++ bson extension, using pure JS version
Started
....................................


36 specs, 0 failures
Finished in 0.058 seconds
=============================================================================
Writing coverage object [/Users/dmartinez/source/haakon-core/coverage/coverage.json]
Writing coverage reports at [/Users/dmartinez/source/haakon-core/coverage]
=============================================================================

=============================== Coverage summary ===============================
Statements   : 100% ( 515/515 )
Branches     : 100% ( 0/0 )
Functions    : 100% ( 170/170 )
Lines        : 100% ( 515/515 )
================================================================================
Daniels-MacBook-Pro:haakon-core dmartinez$ npm uninstall jasmine
unbuild [email protected]
Daniels-MacBook-Pro:haakon-core dmartinez$ npm install git+https://github.com/jasmine/jasmine-npm.git
[email protected] node_modules/jasmine
├── [email protected]
├── [email protected]
└── [email protected] ([email protected], [email protected])
Daniels-MacBook-Pro:haakon-core dmartinez$ npm run test

> [email protected] test /Users/dmartinez/source/haakon-core
> istanbul cover ./spec/support/runner.js

Failed to load c++ bson extension, using pure JS version
Started
....................................


36 specs, 0 failures
Finished in 0.058 seconds
Daniels-MacBook-Pro:haakon-core dmartinez$ 

[slackersoft]

After a bit more digging, it looks like the exit module that we started using to fix #20 also has another windows specific fix for making sure the error code is set properly that is probably causing this.

We're looking into a better solution that ensures proper error codes and works with piped output on windows. We'd also be happy to review a pull request that solves this issue.

[amavisca]

Fixed with 97c67d5