jasonday/jquery-ui-dialog-extended

Responsive jQuery UI dialog, click outside close, and other extended options

jquery-ui-dialog-extended's Issues

Error: cannot call methods on dialog prior to initialization; attempted to call method 'option'

When Open, close and open again, dialog not resize with error: cannot call methods on dialog prior to initialization; attempted to call method 'option'
Problem because of window.onresize not unbinding when dialog was closed.

For fix this, need correct:

$.ui.dialog.prototype.open = function () {
.......

    // call resize()
    resize();

    //correct this
    // resize on window resize
    $(window).on("resize", resize);
    
   //add this block
    self.element.on('dialogclose', function() {
        $(window).off("resize", resize);
    });
.....
}

Uncaught Error: cannot call methods on dialog prior to initialization; attempted to call method 'option'

Trying to use this plugin by importing it through webpack.

Recentering did not work in jQuery v1.11.2, UI v1.11.4

Hi, this is a nice little add-on. I had to change a line at the recentering section to make it work under jquery v1.11.2 and jquery UI v1.11.4

            if (elem.hasClass("resizedH") || elem.hasClass("resizedW")) {
                elem.dialog("option", "position", {my: "center", at: "center", of: window});
                elem.css("overflow", "auto");
            }

clickOut: overlay needs z-index

Hey!

I came across the problem, that the overlay did not close all the time.

After I have added a z-index (in my case 20) the function worked like a charm.

Thanks for the plugin.

Jakob

var used out of bounds

jQuery-UI-Dialog-extended/jquery.dialogOptions.js

Line 108 in a1a9c07

elem.css("-webkit-overflow-scrolling", "touch");

Should this go in the condition above, otherwise elem is not defined?

Position not responding when window resize

Hi,

Why is it the position of dialog is not responding or not changing when I try to resize the window. When I load the dialog box its position is in the center and when I resize the window to smaller width the dialog box left margin or left indention is not changing position I assume that it will respond on window resize.

Dialog Extended Breaks Modal

Love the responsive feature but
I have a dialog box on a page with modal set to true. When I add this to my page the box is no longer modal. Eg. I can click on the background and the dialog will close.
Dave

The dialog no longer re-sizes once closed

The dialog re-sizes initially, but when closed bring the screen size down to a mobile resolution then open the dialog and re-size the screen to a larger resolution. The dialog will not resize when the screen size is re-adjusted to a normal desktop size, issue occurs in JSFiddle also.

Document what is needed from modernizr

With respect to this project: thankyouthankyouthankyou. It solved a serious issue in my own work.

Just a tiny niggle: would you mind explicitly documenting somewhere what exactly is needed from modernizr? Because you need to specify on download which components you want added.

Through peeking at the code and some trial and error, I concluded that only touchevents are needed. Is this correct? In any case, please document. I wish that future users of this project need not hunt and peck like I did in order to get this right.

Thanks!

Incompatibility with jQuery 1.11.0 and/or jQuery UI 1.10.4

When creating the dialog, I receive:
Uncaught TypeError: Cannot set property 'events' of undefined

Pertaining to line:
$.ui.dialog.overlay.events = $.map('focus,keydown,keypress'.split(','), function (event) {

Using the versions of jQuery and jQuery UI you use in your jsFiddle fixes the issue.