Giter Site home page Giter Site logo

jasonlg1979 / gnome-shell-extension-mpris-indicator-button Goto Github PK

View Code? Open in Web Editor NEW
158.0 11.0 22.0 1.38 MB

A full featured MPRIS indicator button extension for GNOME Shell 3.38+

Home Page: https://extensions.gnome.org/extension/1379/mpris-indicator-button/

License: GNU General Public License v3.0

JavaScript 99.50% CSS 0.50%
gnome mpris gnome-shell-extension javascript gjs linux

gnome-shell-extension-mpris-indicator-button's People

Contributors

amereyeu avatar chrislauinger77 avatar jasonlg1979 avatar mershl avatar pcm720 avatar shemgp avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

gnome-shell-extension-mpris-indicator-button's Issues

Extension won't turn on

Describe the bug

This is what I see in the journalctl log after installing the extension into GNOME Shell 3.34 via extensions.gnome.org:

Nov 06 13:13:24 jik-d42-x1 gnome-software[2200]: State change on user/*/*/shell-extension/mprisindicatorbutton_JasonLG1979.github.io/* from available to installed is not OK

I tried downloading and installing by hand and it doesn't work then either.

When I go to the main extensions.gnome.org page the add-on shows up as being installed and off. If I click the toggle button to turn it on, the toggle turns to on, but when I reload the page, it's off again. Nothing shows up in the journalctl log when I do that.

Steps To Reproduce:

Try to install the extension in GNOME Shell 3.34 on Ubuntu 19.10.

Expected behavior

It should work.

System Details (please complete the following information):

  • Extension version: 12
  • Installed from: extensions.gnome.org
  • GNOME/Shell version: 3.34
  • Distro/Release: Ubuntu 19.10
  • List of other installed and enabled Extensions*
jik@jik-d42-x1:~$ gnome-extensions list --enabled
desktop-icons@csoriano
[email protected]
[email protected]

Many features not working in 20.04 Ubuntu

Hey, so I installed it on Ubuntu 20.04, and apart from the pause, forward, backward buttons, nothing else is visible on the drop down menu. Not even the album art, playlist etc. I am using it with Spotify.

Translation doesn't work

Describe the bug

Translation doesn't work.

  • Extension version: 15
  • Installed from: GNOME Extensions Website
  • GNOME/Shell version: 3.36.4
  • Distro/Release: Manjaro Linux

In translations.js:

....
get ['PlayLists']() {return _("Плейлисты");},
....

01

Add an option to "always display the icon as a note symbol"

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
currently icon changes to something like a disk, it is hard to find if you have A LOT of icons.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Add option or change default to always show the icon as a note symbol

Exclude Chrome player

When watching a video on youtube, a player appears, but after closing the tab, he does not disappear.
To hide the player you have to close Chrome.
001

I can’t figure out where you can insert this piece of code to make it work?

let name_regex = /^org\.mpris\.MediaPlayer2\.(?!chrome)/; // exclude chrome
if (name_regex.test(player_name)) {
....
}

I don't need a Chome player.
Chrome already has a built-in.
https://i.imgur.com/xL31Oco.png

Mpris extension resets the volume to zero

Describe the bug

When the Mpris extension is used, the volume of each media player is set to zero when it starts playing a media. This behavior:

  • is not present before the installation of the Mpris extension
  • is still present just after the Mpris extension is uninstalled
  • is not present after the computer is restarted

Steps To Reproduce:

Rhythmbox:

  1. I open Rhythmbox and starts playing music
  2. for a demi second, the volume is set to the level it was the last time Rhythmbox was used
  3. then after this demi second, the volume is set to 0

I have the same issue with VLC:

  1. I open VLC and start playing a video
  2. The sound is directly set to 0
  3. I change the volume to 100
  4. I close VLC
  5. I open it again and start playing a video
  6. The sound is reset again to 0

Expected behavior

The volume level should not be reset each time a media player is reopen.

System Details (please complete the following information):

  • Extension version: 12 I guess
  • Installed from: GNOME Extensions Website
  • GNOME/Shell version: 3.32 and 3.34.1 (and maybe older versions but I cannot be sure)
  • Distro/Release: Ubuntu 19.04 (and maybe older versions but I cannot be sure), Ubuntu 19.10, Debian testing
  • List of other installed and enabled Extensions: OpenWeather, Places Status Indicator, User Themes, Workspace Indicator

Additional Notes:

I guess this issue exists ever since the first release of this extension. Before the Mpris extension, the "gnome-shell-extensions-mediaplayer" did not have this issue. I noticed this some months ago when I switched to the Mpris extension, but I did not get the time to investigate it before.

Rectangle stretched covers

Describe the bug

The covers of the musics aren't square. Instead, they are horizontal stretched rectangles.

Steps To Reproduce:

  1. Simply click in the mpris icon and you'll see it. Not much secret.

Expected behavior

The music cover turns into vertical stretched rectangles like in the picture

Screenshots

image

Logs

I think that this doesn't have anything with mpris, but this is what i found when i searched for mpris

kdeconnect.core: LanLinkProvider received reply: "{\"id\":1592229189750,\"type\":\"kdeconnect.identity\",\"body\":{\"deviceId\":\"87825a5a-53b2-45d7-9f3e-3794fdc228e0\",\"deviceName\":\"this-pc\",\"deviceType\":\"laptop\",\"protocolVersion\":7,\"incomingCapabilities\":[\"kdeconnect.contacts.response_uids_timestamps\",\"kdeconnect.contacts.response_vcards\",\"kdeconnect.battery\",\"kdeconnect.battery.request\",\"kdeconnect.runcommand\",\"kdeconnect.runcommand.request\",\"kdeconnect.clipboard\",\"kdeconnect.clipboard.connect\",\"kdeconnect.systemvolume.request\",\"kdeconnect.photo\",\"kdeconnect.photo.request\",\"kdeconnect.mousepad.echo\",\"kdeconnect.mousepad.request\",\"kdeconnect.mousepad.keyboardstate\",\"kdeconnect.mpris\",\"kdeconnect.mpris.request\",\"kdeconnect.share.request\",\"kdeconnect.sftp\",\"kdeconnect.sms.messages\",\"kdeconnect.telephony\",\"kdeconnect.ping\",\"kdeconnect.notification\",\"kdeconnect.notification.request\",\"kdeconnect.findmyphone.request\",\"kdeconnect.presenter\"],\"outgoingCapabilities\":[\"kdeconnect.contacts.request_all_uids_timestamps\",\"kdeconnect.contacts.request_vcards_by_uid\",\"kdeconnect.battery\",\"kdeconnect.battery.request\",\"kdeconnect.runcommand\",\"kdeconnect.runcommand.request\",\"kdeconnect.clipboard\",\"kdeconnect.clipboard.connect\",\"kdeconnect.systemvolume\",\"kdeconnect.photo\",\"kdeconnect.photo.request\",\"kdeconnect.mousepad.echo\",\"kdeconnect.mousepad.request\",\"kdeconnect.mousepad.keyboardstate\",\"kdeconnect.mpris\",\"kdeconnect.mpris.request\",\"kdeconnect.share.request\",\"kdeconnect.sftp.request\",\"kdeconnect.sms.request\",\"kdeconnect.sms.request_conversation\",\"kdeconnect.sms.request_conversations\",\"kdeconnect.telephony.request\",\"kdeconnect.telephony.request_mute\",\"kdeconnect.ping\",\"kdeconnect.notification\",\"kdeconnect.notification.action\",\"kdeconnect.notification.reply\",\"kdeconnect.notification.request\",\"kdeconnect.findmyphone.request\"],\"tcpPort\":1716}}\n"

System Details (please complete the following information):

  • Extension version: 15
  • Installed from: GNOME Extensions Website
  • GNOME/Shell version: 3.36
  • Distro/Release: Ubuntu 20.04
  • List of other installed and enabled Extensions:* Arc menu, Dash to Panel, Blyr, GSConnect
  • Theme: Arc dark

Additional Notes:

This bug happens with non-spotify apps too.
image

Gnome 3.34.2 on ubuntu 19.10 can't display the indicator button of the latest update

Describe the bug

Gnome 3.34.2 on ubuntu 19.10 can't display the indicator button of the latest update on 27/3/2020

There exists 'a' indicator in the date submenu of gnome shell that i think it's supposed to be the default one.

Steps To Reproduce:

  1. run any player
  2. See error

Logs

journalctl says this:

mar 27 20:07:32 AIVAS gnome-shell[6647]: Received property Shuffle with type d does not match expected type b in the expected interface
mar 27 20:07:32 AIVAS gnome-shell[6647]: Received property Shuffle with type d does not match expected type b in the expected interface
mar 27 20:07:32 AIVAS gnome-shell[6647]: JS ERROR: Error: 3 is not a valid value for enumeration StAlign
                                         _init@/home/i30817/.local/share/gnome-shell/extensions/[email protected]/widgets.js:
                                         Player@/home/i30817/.local/share/gnome-shell/extensions/[email protected]/widgets.js
                                         _init/<@/home/i30817/.local/share/gnome-shell/extensions/[email protected]/widgets.j
                                         _addPlayer/</<@/home/i30817/.local/share/gnome-shell/extensions/[email protected]/db
                                         onProxyReady@/home/i30817/.local/share/gnome-shell/extensions/[email protected]/dbus
                                         makeProxy/<@/home/i30817/.local/share/gnome-shell/extensions/[email protected]/dbus.

ALT+F2 followed by lg says '[email protected] has not emitted any errors' on the extension though.

System Details (please complete the following information):

  • Extension version:
  • Installed from: GitHub
  • GNOME/Shell version: 3.34.2
  • Distro/Release: Ubuntu 19.10
  • List of other installed and enabled Extensions* Activities Configurator, Applications Menu, Desktop Icons, KStatusNotifierItem/AppIndicator Support, OpenWeather, Places Status Indicator, Radeon DPM Control (github version), Removable Drive Menu, gistnotes

Accessibility audit

I need help testing the accessibility of this extension. I've tried my best to make this extension accessible to persons with disabilities by providing keyboard shortcuts, mouse actions and making it so that the screen reader will read aloud the player's name and the track's artist and title and what not but I'm unsure if what I've done is enough and/or fits with convention. I guess what I would like is an accessibility audit by someone who actually uses accessibility features on a regular basis and is versed in the conventions. Knowing how to code would be helpful but not necessary.

Option to put Indicator in the center of the panel

So I know, settings are big no no in the new paradigm but I think that once you will add the current song that will be relevant as of where I want to see the current song.

I personally would like to have it in the center (moved the clock aside) instead of "competing" with other extensions for real estate and alignment priority

Thoughts?

Doesn't work with yandex music flatpak.

Distro Name & Version

Ubuntu 18.04 LTS

GNOME Shell Version

3.28.3

Other Installed Extensions

Dash to Panel
Drop Down Terminal X
OpenWeather
User Themes
Workspace Indicator

Expected Behavior

Indicator should appear in tray

Current Behavior

Indicator does not appear in tray. It works with VLC though

Enhancement: Monochrome Icons

Currently, the Spotify icon is the only outsider in my top bar by being green. Having a toggle to enable monochrome icons would fix this problem.

I've read your stance on user configurable options here, but in this case there isn't a sane default I'm afraid.

Possible to disable all artwork?

I know this kind of seems like an odd request, but on Pop!_OS 20.04, using some .deb and some flatpak apps, most do not display the album artwork. I'm actually starting to like just seeing the applications icon in the drop down menu of this extension instead of the artwork. It's simple, it's clean, and it's consistent, and all my application icons load just fine, nothing to fuss about. So I was wondering if it's possible to add like an *exclude artwork parameter or something? I notice the extension doesn't have any settings so it comes as is, so if it's possible then, would you be able to tell me if this is at all possible to do, aka hide/don't show artwork? Is there maybe a .json file or something where I could add or remove a line to achieve this? Don't know if this is at all possible, but I figured it couldn't hurt to ask since none of my apps want to play nice lol. Btw, here's a screenshot below to show most apps doesn't show artwork, so if I could disable artwork or prevent it from showing to only show just the application icon, that would be awesome! Thanks for taking the time to read this comment.

Screenshot from 2020-10-09 03-12-33

On the google-chrome: 79.0.3945.130 control buttons are gone.

Describe the bug

On the google-chrome: 79.0.3945.130 control buttons are gone:
https://i.imgur.com/UfIonOA.png
The built-in mpris control also appeared.
Single video:
https://i.imgur.com/c91jxYG.png
Playlist:
https://i.imgur.com/xL31Oco.png
Allows you to not only switch tracks (only when playing a playlist), but also has scroll buttons on the track.

With google-chrome: 78.0.3904.70 and below everything is fine:
https://i.imgur.com/6ptinWf.png

System Details:

  • Extension version: master
  • Installed from: GitHub
  • GNOME/Shell version: 3.34.2
  • Distro/Release: Manjaro

Enlarged album cover.

Requesting a function:
It would be nice if, when you hover over the album / track icon, an enlarged cover is shown.
https://i.imgur.com/oT8vIjs.jpg

Indicator status text support

Distro Name & Version

Ubuntu 19.04

GNOME Shell Version

3.32.0

Other Installed Extensions

N/A

Expected Behavior

Simply the defined behaviour defined in the wiki here for the old extension

Current Behavior

N/A (Not implemented)

Detailed Description

Whether this is baked in, or provided by allowing for plugins (EG/ provide a settings panel to just pull in extra plugins that implement extra behaviors like how it renders to the shell etc) is (in my opinion) up for discussion, but would be great to be able to have this functionality back. (Main thing I'm missing from the previous mpris extension)

If this task is something you'd be open to letting other people undertake, I might be able to undertake this in the near future.

Add Gnome Podcasts to display artwork?

Currently on Pop!_OS 20.04 fully updated, Gnome 3.36.3, using Gnome Podcasts flatpak v0.4.8 and the MPRIS extension does show the Podcast icon in the top panel (as well as any other icon that is currently being used; vivaldi, rhythmbox, etc), which I think is great (works for my Tauon music box player flatpak app as well), but when I click the extension Gnome Podcasts doesn't display the artwork for the currently playing podcast, it just shows the Gnome Podcast application icon. Now I understand (or rather maybe assume) that Pop!_OS is a mixture of Gnome versions or something like that, so this may not even be able to be fixed for me, but if it is even possible, I will still give it a try to at least ask you since it can't hurt after all. Below is a screenshot just to illustrate what I'm seeing.

Screenshot from 2020-10-04 17-04-16

Detecting shuffle or loop status is broken

Describe the bug

Reading the code, it seems that the function _testShuffleLoopStatus toggles the shuffle and loop to test if these are working. I have an MPRIS player (Headset) that has both shuffle and loop implemented correctly but they only work when a song is playing, otherwise, they don't do anything.
So, when starting Headset and playing a song, this extension doesn't show either the loop or shuffle buttons. After toggling shuffle or loop from within the app, both buttons are shown in this extension but only the one that was toggled works. For example, if I shuffle within Headset, only the shuffle button will work in the extension, so pressing the loop button doesn't work even though my app can receive that mpris message.

So, maybe detecting that this._playerProxy.Shuffle !== null and this._playerProxy.LoopStatus !== null might be enough. Or maybe, it'll be better to run _testShuffleLoopStatus inside _updatePlayerProps?

Steps To Reproduce:

  1. Start Headset
  2. Play any song
  3. Check that this extension doesn't show either loop or shuffle buttons
  4. Toggle shuffle from within the app (or using any other mpris controller (i.e. playerctl)
  5. See that both shuffle and loop buttons are displayed in the extension but only shuffle works.

Expected behavior

After playing a song, both loop and shuffle buttons should be displayed and working.

System Details (please complete the following information):

  • Extension version: 15
  • Installed from: GNOME Extensions Website
  • GNOME/Shell version: 3.36.1
  • Distro/Release: Ubuntu 20.04

Additional Notes:

From my player's point of view, there's no reason to change either the shuffle or loop status when nothing is playing (stopped not just paused). This will open the alternative that toggling shuffle/loop when nothing is playing will de-synchronize the internal status of the player with mpris. Not a lot of people will do this, but it's better to prevent this situation rather than introduce weird behavior.

Lollypop - Secondary Click to "Raise/Minimize Toggle" also toggles Lollypop window minimise/maximise

Steps to reproduce

Case 1:
Lollypop window is maximised.
-> Secondary click on the mpris-indicator-button
Expected result: mpris indicator maximises to show current song etc.
Actual result: mpris indicator maximises to show current song etc. as well as minimises Lollypop window.
-> Secondary click on the mpris-indicator-button
Expected result: mpris indicator minimises
Actual result: mpris indicator minimises as well as maximises Lollypop window.

Case 1:
Lollypop window is minimised.
-> Secondary click on the mpris-indicator-button
Expected result: mpris indicator maximises to show current song etc.
Actual result: mpris indicator maximises to show current song etc. as well as maximises Lollypop window.
-> Secondary click on the mpris-indicator-button
Expected result: mpris indicator minimises
Actual result: mpris indicator minimises as well as minimises Lollypop window.


Nothing too major, other than this the functionality of the indicator is really good.

Chromium/Chrome 75 exposes a broken MPRIS interface.

As the title says Chromium/Chrome 75 exposes a broken interface. The only thing that currently works is metadata (limited to artist and title) and playback status. All other properties and methods seem to be nonfunctional. (rendering the controls in the extension also nonfunctional) On top of that once the interface shows up it never goes away even after navigating away from a supported sites like YouTube or PlayMusic.

Screenshot from 2019-06-05 17-54-32

Until it actually works I think the best thing to do is blacklist Chromium/Chrome for now.

Do not show indicator when there is nothing to control

I am taking chromium as an example here: As soon as chromium is started the indicator button is shown, although there is not yet anything to control, as I don't have an tab playing audio open yet.

Screenshot from 2019-09-20 20-19-57

It would be great if the indicator button would only show up, if there is actually something to control, when all buttons are grayed out, it should not be visible.

Doesn't work in Gnome Shell 3.34

Distro Name & Version

Arch Linux (rolling)

GNOME Shell Version

3.34

Other Installed Extensions

Default extensions, Freon, Gsconnect, TopIcons Plus,

Expected Behavior

Working just like in Gnome 3.32.

Current Behavior

Icon doesn't show at all.

Detailed Description

Since I upgraded to Gnome 3.34 this extension and TopIcons Plus stopped working. Disabling TopIcons Plus doesn't help.

Extension causes Gnome-shell to crash when locking

Distro Name & Version

Archlinux (latest packages as of Jan 24th)

GNOME Shell Version

3.30.2

Other Installed Extensions

Tried with just this one enabled, same behavior. Tried with other extensions enabled without this one, no problem.

Expected Behavior

After clicking the lock button, session locks and asks for password.

Current Behavior

After trying to lock the session, gnome-shell crashes, no lock dialog is generated, gnome-shell reloads (or sometimes crashes the session). I have not found any other instances where this extension causes gnome-shell to crash.

Detailed Description

I'm not too handy with core dumps, but this seems to be the relevant line:

Using host libthread_db library "/usr/lib/libthread_db.so.1".
Core was generated by `/usr/bin/gnome-shell'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007f0da29f6a58 in st_widget_get_theme_node () from /usr/lib/gnome-shell/libst-1.0.so

[Feature Request] Auto-pause when new source is playing

Is your feature request related to a problem? Please describe.
When I you play a song and then play a second one, the first one isn't paused

Describe the solution you'd like
Pause the first one and make it work in the other sens

Album art not displayed in GNOME 3.34 in some distributions

Distro Name & Version

Fedora 31 nightly and Arch

GNOME Shell Version

3.34

Other Installed Extensions

None

Expected Behavior

Cover art showing up in this extension and the default MPRIS controls when it is available.

Current Behavior

Non-local album art is not shown in the extension nor the default MPRIS controls.

Detailed Description

As mentioned in #13 (comment) and https://bugs.archlinux.org/task/62860

Ubuntu 19.10 daily appears to be unaffected.

Below are screenshots of both this extension and the default MPRIS controls from the latest Fedora 31 nightly as of the date of the creation of this issue.

Pithos provides local images for cover art where as Spotify does not.

Screenshot from 2019-09-26 13-06-13
Screenshot from 2019-09-26 13-06-47

Mpris indicator didn'T recognise ANoise

Mpris indicator didn't recognize ANoise
https://anoise.tuxfamily.org/

Steps To Reproduce:

Install and start ANoise

Expected behavior

Anoise could be controlled via mpris indicator

System Details (please complete the following information):

  • Installed from:GNOME Extensions Website
  • GNOME/Shell version:3,36
  • Distro/Release: Ubuntu 20.04

Additional Notes:

I don't know if this is an issue or a feature request, Thanks for checking

Possible Feature: Indicator Tootip

A lot of users expressed interest in having track info in the panel, and it get it, it's nice to be able to see it at a glance. But I did not implement that feature because of how it would possibly affect other indicators in the panel.

As a compromise I thought that maybe users would like a tool tip that showed that info on mouse over of the indicator?

Something like this:
Screenshot from 2019-10-16 18-00-16
Screenshot from 2019-10-16 17-59-30

GNOME Shell has no built in tool tip functionality that I know of, so before I finish writing it from scratch I thought I'd get your thoughts.

Icon for Chrome (notes) is low resolution

The icons for lollypop and other players are nice, but the default notes one that shows up when something's playing on Chrome is very low resolution.

image

That is on a 1080p screen. Maybe replace that icon with something else -- maybe even browser-specific?

I'm using the latest version of the extension.

Indicator icons

Describe the bug

It's not really a bug I guess, neither an idea for extra features. In my current theme all the icons in the top panel are displayed in light grey. The icons of this extension are displayed in a darker grey. (see image)

Expected behavior

From where are the icons fetched? If I know where the icons are located, I can manually edit them. Another option is that you tell me where the gicon's are assigned for the top panel icon in the code.

Screenshots
image

Thanks in advance!

Reanimate gnome-shell-extensions-mediaplayer for gnome 3.34

Hello.

The gnome-shell-extensions-mediaplayer project is in the archive and I can’t leave the issue there, so I give a request here.

I understand that you are tired of supporting gnome-shell-extensions-mediaplayer, but I want to ask you to reanimate it for gnome 3.34.

No doubt gnome-shell-extension-mpris-indicator-button is a good plugin, but sometimes gnome-shell-extensions-mediaplayer does exactly what need.

I am ashamed to ask you to do this, but if I knew javascript and GJS well, I would do it myself.

Possibly misbehaving with the mpd-mpris service

Describe the bug

I'm using this service/daemon called mpd-mpris, which implements the MPRIS protocol for the Music Player Daemon (MPD).

It works almost perfectly with this extension. There are two issues I'm experiencing right now:

  1. Upon restarting the mpd-mpris daemon, some playback flags are randomly enabled/disabled in MPD (for example: shuffle mode, random mode, single mode).
  2. If I leave a song playing on MPD; Then lock my screen (Super+L); Then unlock it, MPD's volume will be set to zero, for some odd reason.

Initially, I thought this was an issue with the mpd-mpris daemon (and I reported it to their developer), but if I actually disable this extension, I'm unable to reproduce these two bugs!

Since it's not clear if this is a bug with mpd-mpris or this extension, @natsukagami (the creator of mpd-mpris) suggested me to report it here, and it's also willing to help on a possible fix.

Steps To Reproduce:

Note: This needs both MPD and mpd-mpris set up.

The first issue can be reproduced by either:

  1. Keep restarting mpd-mpris daemon: Some playblack flags will be randomly enabled/disabled. Here's a video I recorded showing this behavior.
  2. Disable this extension temporarily; Then run the mpd-mpris service (and make sure to not have any playback flags enabled in MPD. You can use ncmpcpp to check which flags are enabled); Then re-enable this extension. Playblack flags will be randomly set/unset each time you do this.

The second issue:

  1. Run mpd-mpris like normal
  2. Lock your session: Super+L
  3. Unlock it
  4. MPD's Volume will be set to zero

Expected behavior

  • Don't touch MPD's playback flags
  • Don't mute MPD after the user unlocks the session

System Details (please complete the following information):

Feature porting from gnome-shell-extensions-mediaplayer

Not an exhaustive list of all of the features and settings from gnome-shell-extensions-mediaplayer, more of a general list of features I have seen people asking about or features that I personally like/use. If you don't see a feature specifically listed the answer is most likely going to be "Not happening."

You are of course free to takeover maintainership of gnome-shell-extensions-mediaplayer or fork it and/or this extension and do the work yourself if you see anything on this list that you don't like.

Position Slider: Not happening.

Ratings in any form: Not happening.

Changing position of the indicator or putting it in the system menu: Not happening.

Album covers in the panel: Not happening.

Playback status in the panel: Not happening.

Track info text in the panel: Maybe. See here

Repeat and random buttons: Maybe. DONE

TrackList and PlayList interfaces: Maybe.

Translations

This extension has a few user visible strings and strings that will be read a loud by screen readers that require translation.

It would be of great if someone would help me make that possible.

Add functionali exclude player

Please add functionali exclude player for developers!!!!!

Let it be in code like this._ignoredPlayers = ['olivia']; developers will take advantage of it, and ordinary users won't even know about it.

Extension mpris-indicator-button with the olivia player works disgustingly. If you do not enable MPRIS, then the mpris-indicator-button is not active but there is no control from the multimedia keys.

I tried to hack bus.js through this._ignoredPlayers = []; replace on this._ignoredPlayers = ['olivia'];
But I didn't succeed.

Although judging by this codeif (busName.startsWith(MPRIS_PREFIX) && !this._ignoredPlayers.includes(this._stripInstanceNumber(busName))) {
Where !this._ignoredPlayers.includes(this._stripInstanceNumber(busName)) should work.

Song not updated

Describe the bug

Song not updated. Only reloading the extension will show the new song.

Steps To Reproduce:

  1. Change song

Expected behavior
New song shown.

System Details (please complete the following information):

  • Extension version: 336d0fe
  • Installed from: Arch AUR / git
  • GNOME/Shell version: 3.34.2
  • Distro/Release: Arch
  • List of other installed and enabled Extensions*

What can I do to debug this?

Extra / non-standard padding around icon

Describe the bug

I noticed that the icon looks a ever so slightly out of place next to my other indicators. After taking screenshots to measure, it appears to have a 52px width vs 46px for the others. I don't know if something is adding 3px of extra padding or if it's up to each extension and purely a coincidence that the others appear to be similar. (Coming from Ubuntu AppIndicators?) I would just love to see everything blend together seamlessly.

image

Icon indicator not showing after launching audacious

Describe the bug

Icon indicator not showing after launching audacious until the this extension re-enabled or (alt+f2)(r).

Steps To Reproduce:

  1. Launch audacious
  2. The icon indicator not showing
  3. Re-enable this mpris extension or (alt+f2)(r)

Expected behavior

Launching audacious should immediately show the icon indicator without having to re-enable the extension or restarting shell.

Screenshots

Logs

JS ERROR: Exception in callback for signal: hide: Error: Impossible to remove untracked message
removeMessage@resource:///org/gnome/shell/ui/messageList.js:677:19
_addPlayer/<@resource:///org/gnome/shell/ui/mpris.js:273:18
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:133:47
_updateState@resource:///org/gnome/shell/ui/mpris.js:231:22
_onPlayerProxyReady@resource:///org/gnome/shell/ui/mpris.js:181:14
_makeProxyWrapper/</<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:262:21

System Details (please complete the following information):

  • Extension version: 16
  • Installed from: GNOME Extensions Website
  • GNOME/Shell version: 3.36.4
  • Distro/Release: Ubuntu 20.04
  • List of other installed and enabled Extensions*
    • Arc Menu version 4
    • Dash to Panel version 40
  • Audacious version: 3.10.1

Additional Notes:

Center the controls under the button

Distro Name & Version

Ubuntu Gnome 18.10. (Soon to be upgraded to 19.04 with 3.32).

GNOME Shell Version

3.30.

Other Installed Extensions

Expected Behavior

When clicking the button, open the little window with the play controls centered under it, so the user only has to move the mouse pointer a bit down to play/pause.

Current Behavior

Currently, there is an offset, especially when the button is located a bit to the left in the bar because there are some other indicators already there (for example a system-monitor). So, when I click the button, right down from the mouse pointer the leftmost border of the controls window appears, and I have to move the pointer 'quite a bit' to actually click the pause button.

Detailed Description

See above :)

Thanks for supporting 3.32! Came here after seeing the Media Player Indicator being unsupported from now on.

When using in concert with GSConnect MPRIS indicator sets the volume to maximum.

Describe the bug

When GSConnect is setup and you have a music already playing and you either power on your device or resume, MPRIS plugin sets the volume at full causing audio to unexpectedly rise on mobile phone.

Steps To Reproduce:

(Requires GSConnect to be configured)

  1. Play music on phone with volume less than full.
  2. Turn on/resume your computer.
  3. The volume rises to full on mobile phone once MPRIS indicator loads

Expected behavior

MPRIS plugin should show the actual volume set instead of increasing it to full by default.

Logs

Jun 24 13:36:15 stormstar systemd[1496]: Started Forward bluetooth midi controls via mpris2 so they.
                                             _getIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1911:45
                                             _getSymbolicIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1901:21
                                             refreshIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1547:26
                                             _updateMprisProps@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1708:18
                                             _finish_init@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1659:14
                                             _init@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1388:14
                                             _addPlayer/</<@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:447:29
                                             onProxyReady@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:268:17
                                             makeProxy/<@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:171:21
                                             _getIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1911:45
                                             _getSymbolicIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1901:21
                                             refreshIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1547:26
                                             _updateMprisProps@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1708:18
                                             _finish_init/<@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1639:18
                                             _getIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1911:45
                                             _getSymbolicIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1901:21
                                             refreshIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1547:26
                                             _updateMprisProps@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1708:18
                                             _finish_init/<@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1639:18
                                             _getIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1911:45
                                             _getSymbolicIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1901:21
                                             refreshIcon@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1547:26
                                             _updateMprisProps@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1708:18
                                             _finish_init@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1659:14
                                             _init@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:1388:14
                                             _addPlayer/</<@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:447:29
                                             onProxyReady@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:268:17
                                             makeProxy/<@/home/rmishra/.local/share/gnome-shell/extensions/[email protected]/dbus.js:171:21
                                                                        "type": "kdeconnect.mpris",
                                                                        "type": "kdeconnect.mpris",
                                                                        "type": "kdeconnect.mpris.request",
                                                                        "type": "kdeconnect.mpris",
                                                                        "type": "kdeconnect.mpris",
                                                                        "type": "kdeconnect.mpris",

(the type kdeconnect lines are GSConnect)
(GSConnect gets its volume data from the phone , the last line)

Jun 24 13:46:34 org.gnome.Shell.Extensions.GSConnect[1816]: [/service/protocol/core.js:receive/<:298]: winterbell: {
                                                              "id": 1593020793537,
                                                              "type": "kdeconnect.mpris",
                                                              "body": {
                                                                "player": "YouTube Music",
                                                                "nowPlaying": "Starley - Call on Me (Ryan Riback Remix)",
                                                                "title": "Call on Me (Ryan Riback Remix)",
                                                                "artist": "Starley",
                                                                "album": "Call on Me (Remixes)",
                                                                "isPlaying": true,
                                                                "pos": 49800,
                                                                "length": 222000,
                                                                "canPlay": true,
                                                                "canPause": true,
                                                                "canGoPrevious": true,
                                                                "canGoNext": true,
                                                                "canSeek": true,
                                                                "volume": 44
                                                              }
                                                            }

System Details (please complete the following information):

Additional Notes:

Gnome 3.38 Support?

Gnome 3.38 has been released recently and Ubuntu 20.10 will have it and Pop!_OS should follow withe an update shortly after that too, and I would love to see this extension gain support for the latest version at some point in the future, I've grown very fond of it, thank you!

Doesn't work on Gnome Shell 3.32

Distro Name & Version

Arch Linux

GNOME Shell Version

3.32

Other Installed Extensions

No other third party extensions.

Expected Behavior

An icon appears on the top right corner of the screen.

Current Behavior

The icon does not appear.

Detailed Description

Notifications work, but icon doesn't appear.

Scrolling on the icon to change the volumen

I found more intuitive to use the mouse wheel to volume up and down and the mouse forward and back buttons to go next and previous song, usually when someone click forward or back want to go just one song at time, so one button seems better option, and using the wheel fits better with changing the volume.

I modified a little the "widgets.js" file to match this behaviour, but it would be nice to have it for everyone and as default behaviour.

Looking for Gnome 3.30 compatible release...

I know it's a long shot but would anyone happen to have this version? I'm using the retired version of this extension usually with both Spotify and VLC open and for some reason it captures VLC even with the dbus setting turned off. I wanted to see if the new version will only show Spotify so my media player buttons only control it and not VLC if it was the last active/focused.

After update to latest version extension doesn't work on Gnome 3.34

Describe the bug

Mpris indicator icon doesn't show in panel

Steps To Reproduce:

Update to latest version or install fresh on Gnome 3.34

Logs

JS ERROR: Error: 3 is not a valid value for enumeration StAlign
_init@/home/castorp/.local/share/gnome-shell/extensions/[email protected]/widgets.js:819:28
Player@/home/castorp/.local/share/gnome-shell/extensions/[email protected]/widgets.js:997:28
_init/<@/home/castorp/.local/share/gnome-shell/extensions/[email protected]/widgets.js:1594:39
_addPlayer/</<@/home/castorp/.local/share/gnome-shell/extensions/[email protected]/dbus.js:446:21
onProxyReady@/home/castorp/.local/share/gnome-shell/extensions/[email protected]/dbus.js:268:17
makeProxy/<@/home/castorp/.local/share/gnome-shell/extensions/[email protected]/dbus.js:171:21

System Details (please complete the following information):

Fedora 31

Additional Notes:

After reading this github I'm confused, title states extension works for 3.34+, README states 3.36+. I'm assuming this just doesn't work on 3.34 anymore?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.