Giter Site home page Giter Site logo

Comments (5)

andrew-cybsafe avatar andrew-cybsafe commented on August 16, 2024 4

Looks like @Tenzer and @ddabble fixed this in the master branch ~5 months ago. Can we get a new point release issued to fix this for those affected (includes me)?

from django-simple-history.

rjschave avatar rjschave commented on August 16, 2024 1

We encountered the same error this week. We use Wagtail 5.2 and django-simple-history in a project. After upgrading to django-simple-history 3.4.0 we encountered this error when attempting to preview a Wagtail page while editing the page. We do not encounter this error if we revert to django-simple-history 3.3.0.

from django-simple-history.

corentinbettiol avatar corentinbettiol commented on August 16, 2024 1

Hi, I'm the maintainer of Django Check SEO.

I tried to re-add the if hasattr ... condition in the middleware of django-simple-history, and I can confirm that it solves the problem encountered with django-check-seo.

from django-simple-history.

alejandro-perez avatar alejandro-perez commented on August 16, 2024

I'm seeing the same issue here. Works fine with 3.3.* but fails as described with 3.4.0.

from django-simple-history.

djowett avatar djowett commented on August 16, 2024

Previously the middleware made this check before deleting the request property from context, but with the refactor done in 3.4.0 it's gone

        if hasattr(HistoricalRecords.context, "request"):
            del HistoricalRecords.context.request

from django-simple-history.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.