Comments (5)
Looks like @Tenzer and @ddabble fixed this in the master branch ~5 months ago. Can we get a new point release issued to fix this for those affected (includes me)?
from django-simple-history.
We encountered the same error this week. We use Wagtail 5.2 and django-simple-history in a project. After upgrading to django-simple-history 3.4.0 we encountered this error when attempting to preview a Wagtail page while editing the page. We do not encounter this error if we revert to django-simple-history 3.3.0.
from django-simple-history.
Hi, I'm the maintainer of Django Check SEO.
I tried to re-add the if hasattr ...
condition in the middleware of django-simple-history, and I can confirm that it solves the problem encountered with django-check-seo.
from django-simple-history.
I'm seeing the same issue here. Works fine with 3.3.* but fails as described with 3.4.0.
from django-simple-history.
Previously the middleware made this check before deleting the request property from context, but with the refactor done in 3.4.0 it's gone
if hasattr(HistoricalRecords.context, "request"):
del HistoricalRecords.context.request
from django-simple-history.
Related Issues (20)
- Access foreign key of historic instance from model methods HOT 1
- [Question] How to prevent history from being created for a new object? Also how to set user to history after it has been created? HOT 2
- Updating M2M relations causes unnecessary DB queries HOT 11
- How to annotate the historical model to the QuerySet HOT 3
- not working abstract model HOT 1
- "update_fields" option to "bulk_create" not supported? HOT 1
- Add optimized update_or_create Manager method
- HistoricForeignKey is very slow HOT 2
- Release current main branch to PyPi HOT 1
- Remove the "not created" condition from post_save when skipping history creation HOT 1
- m2m historical records are saved even when SIMPLE_HISTORY_ENABLED = False
- skip_history_when_saving if model has no any changes HOT 3
- Sending create_historical_record() to celery tasks HOT 8
- Integration with admin.Models failing
- Not null constraint fails with inheritance and m2m fields
- Django polymorphic compatibility
- create_historical_record_m2ms does not respect model's excluded_field_kwargs
- Convenience Method and naming clarification for as_of
- Incorrect rendering of history entry (with editable fields) if changing is disallowed HOT 1
- bulk_update_with_history should use update_fields: history log incorrectly showing phantom changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-simple-history.