save_without_historical_record() Does not work

[jazzband]

save_without_historical_record() Does not work

[treyhunner]

Thanks for submitting this issue @IliynT. This looks like a bug. At first I thought this might be related to #59, but they look like different issues.

We have a test for save_without_historical_record and it seems to work.

A broken test would be ideal for figuring out how to troubleshoot and fix this issue. If you want to try tackling that, see instructions for running the tests here.

Alternatively if you narrow down the issue enough that you're willing to share a whole project that doesn't work someone might be able to devise a test from the broken project and a subsequent fix.

[treyhunner]

On further inspection it looks like the code example you gave would cause infinite recursion.

save_without_historical_record actually calls save.

The correct way to save without a historical record from the save function is to mimick the save_without_historical_record code and temporarily set skip_history_when_saving to True.

[treyhunner]

@IliynT did you ever overcome this issue? I'm still not sure whether the problem you were experiencing was due to a bug in django-simple-history.

[macro1]

Using save_without_historical_record directly in the save method is not currently supported.

If there is call for a feature like this, maybe we should consider save_with_historical_record() as well, and add a flag such as 'auto_track_saves' to the HistoricalRecords class __init__ method?